OpenDocument('Filename') - doesn't ?

[Zvoni]

@Zvoni  -  My argument about 10 or 1000 lines IS relevant because if the writing of data to the CSVFile is included in the 'Create' Proc then it is no longer a generic Proc.

And that's where i disagree.
But that might be, because i differentiate between "creating" a file, and "writing" to a file.

At the moment of creation of a file (the "rewrite"), the file itself doesn't care, WHAT you are going to write to it.
Thusly implying you can "outsource" any "differing" versions of your Write-Procedure

[J-G]

@Zvoni  -  My argument about 10 or 1000 lines IS relevant because if the writing of data to the CSVFile is included in the 'Create' Proc then it is no longer a generic Proc.

And that's where i disagree.
But that might be, because i differentiate between "creating" a file, and "writing" to a file.

At the moment of creation of a file (the "rewrite"), the file itself doesn't care, WHAT you are going to write to it.
Thusly implying you can "outsource" any "differing" versions of your Write-Procedure

I'm just a little confused now    Though we are surely just discussing 'semantics' .

The sole point of my approach is to separate the 'Creation' from the 'Writing'.

The inclusion of the section :

Code: Pascal  [Select][+][-]

1. if Result then begin
2.     /// write your stuff here ///
3.     system.Close(CSVFile);
4.   end

in the 'Create' implies (to me) that the work of writing the data to the file happens here.   There could of course be some conditional code in there which points to further external working but I concider that the calling proc should have that locally. All I need the 'Create' proc to do is create (open) the file if possible and flag the user if not.

That (to me) keeps the creation generic so that it can be called from multiple places within the main code with disparate file-names.

[Zvoni]

@Zvoni  -  My argument about 10 or 1000 lines IS relevant because if the writing of data to the CSVFile is included in the 'Create' Proc then it is no longer a generic Proc.

And that's where i disagree.
But that might be, because i differentiate between "creating" a file, and "writing" to a file.

At the moment of creation of a file (the "rewrite"), the file itself doesn't care, WHAT you are going to write to it.
Thusly implying you can "outsource" any "differing" versions of your Write-Procedure

I'm just a little confused now    Though we are surely just discussing 'semantics' .

The sole point of my approach is to separate the 'Creation' from the 'Writing'.

The inclusion of the section :

Code: Pascal  [Select][+][-]

1. if Result then begin
2.     /// write your stuff here ///
3.     system.Close(CSVFile);
4.   end

in the 'Create' implies (to me) that the work of writing the data to the file happens here.   There could of course be some conditional code in there which points to further external working but I concider that the calling proc should have that locally. All I need the 'Create' proc to do is create (open) the file if possible and flag the user if not.

That (to me) keeps the creation generic so that it can be called from multiple places within the main code with disparate file-names.

It's more like this

Code: Pascal  [Select][+][-]

1. Interface
2. Procedure MyWriteProcWhichIsinadifferentUnit(Const AFile:File; Data:Pointer);
3. .......
4.  
5. //Somewhere else
6. if Result then begin
7.     MyWriteProcWhichIsinadifferentUnit(CSVFile, Pointer(@MyData));
8.     system.Close(CSVFile);
9.   end

EDIT: And instead of sending a Pointer, you could even use a "generics" approach

Code: Pascal  [Select][+][-]

1. Type
2.    Generic TWriteProc<T>=Procedure(Const AFile:File; Data:T);
3.  
4. Var
5.    MyWriteProcWhichIsinadifferentUnit : specialize TWriteProc<String>;  //Or record-Type or whatever

[cdbc]

Hi
So all you need from this, is:

Code: Pascal  [Select][+][-]

1. function CreateCSVFile(Var FN : String;TS : Boolean; out theIOResult: Integer): boolean;    // TS = 'Time-Stamped' | result = success
2. begin
3.   Result:= False;  //I like to initialize Result explicitely, though i'm aware, Boolean defaults to 0/False
4.   if TS then
5.     FN := FN+TimeStamp+'.CSV'
6.   else
7.     FN := FN+'.CSV';
8.  
9.   Assign(CSVFile,FN);
10.   {$I-} rewrite(CSVFile); {$I+}
11.   theIOResult:= IOResult; { courtesy to user }
12.   Result:= (theIOResult = 0); { the actual result }
13. end;
14.  

-- It opens the file for writing and returns true if successful, while at the same time spitting out the IOResult, or returns false & again the IOResult, for the user to peruse and show appropriate error-message --
I don't think it can be more generic, without actual generics 
Just my 2 cent's worth
Regards Benny