Is it timing of a dataset?

[CraigC]

I have a table that I have an edit form setup for. When I go back to edit a couple fields and press save and exit, I get dataset not in dsEdit or dsInsert.  If I go and try to do a refresh, I can't because it has pending updates.   Anything I can do to sync the data components?

Lazarus 4.6, Linux  SQLdb components.

Thanks,

Craig

[CraigC]

As soon and I press send, I remembered to mention the database.  SQLite 3.

[JanRoza]

Show some code and not just an error message.
I think the second message says it all, did you do an AplyUdates after posting?

[CraigC]

I don't call qry.post.  Never have with SQLite and Lazarus.  Trying to eliminate the error "Not in Edit or Insert mode"

Here is my procedure for Saving or Canceling updates. 

procedure SaveData(qry: TSQLQuery; bSave: Boolean);
var
  s: string;
begin
  s := qry.Name;
  try
    if not dmCommonData.transLedger.Active then
      dmCommonData.transLedger.StartTransaction;
    if bSave then
    begin
      if DataState(qry) then
      begin
        qry.ApplyUpdates;
        dmCommonData.transLedger.Commit;
      end;
    end
    else
    begin
      qry.CancelUpdates;
      dmCommonData.transLedger.Commit;
    end;
  except
  on E: EDatabaseError do
     begin
       dmCommonData.transLedger.Rollback;
       MessageDlg('Error', 'DataBase error: '+ E.Message, mtError, [mbOK], 0);
     end;
  end;
end;

[cdbc]

Hi
Are you using Db-Aware-components?
If so -- alas, I can't help you.
I'm running SQLite3 in more apps without db-aware and it all goes like stink...
Regards Benny

[CraigC]

Yes, these are TDBEdits.  I'm finding that in one instance, I use TEdits and found I had issues with TDBEdits and TDBgrid.  I'm getting close to finding something else to update my old code from Delphi 7.  DBedits that were for string fields, would go blank and integers edits would be just fine. 

Frustrated beyond belief.

[CraigC]

I'm also finding that doing an insert goes great, but updates are really where Lazarus is buggy.

[LemonParty]

Code: Pascal  [Select][+][-]

1.     begin
2.       qry.CancelUpdates;
3.       dmCommonData.transLedger.Commit;
4.     end;

I don't think you have to do Commit after you CancelUpdates.

[cdbc]

Hi
You could take a look at the attached demo, for inspiration...
Regards Benny

[rvk]

Code: Pascal  [Select][+][-]

1.     begin
2.       qry.CancelUpdates;
3.       dmCommonData.transLedger.Commit;
4.     end;

I don't think you have to do Commit after you CancelUpdates.

I think you can... but I would do a rollback there. But even so.... before Commit or Rollback I always check the state first.

Code: Pascal  [Select][+][-]

1.     begin
2.       qry.CancelUpdates;
3.       if dmCommonData.transLedger.Active then dmCommonData.transLedger.Rollback;
4.     end;

And if you need to edit it directly again I would use CommitRetaining or RollbackRetaining.

BTW. Also check the SQL component for the options (AutoApplyUpdates, AutoCommit, ImplicitTransaction, etc).

[LemonParty]

Commiting changes whan you don't want them look like mistake in programs logic. Let's say we have 2 tables and we edited the first one then we edited the second table and than we want to discard changes from both tables. Rollback in this situation is reasonable, but if we do Commit then changes from the first table will be saved and from the second one will be lost. This logic is not intuitive for user, so Commit should be avoided.

[CraigC]

I modified the code for Rollback.

Are you saying I should not use Commit for applying updates?  Most of my issues are getting updates to save and not so much for inserting.

[rvk]

Are you saying I should not use Commit for applying updates?  Most of my issues are getting updates to save and not so much for inserting.

No, you schouldn't use Commit after a cancel. With cancel you want to rollback any changes made in the transaction.

Besides that, we don't see the complete (flow of) code. When is this called? What does DataState() do? What does the local variable s do? etc.

You also have "if not dmCommonData.transLedger.Active then dmCommonData.transLedger.StartTransaction;" in there... but... when calling SaveData I assume the dataset is already in edit mode (it switches to edit mode as soon as you begin editing). So starting a transaction there is far too late (I suspect the StartTransaction is never called there because the transaction should already have been started at first edit of the data-aware edit-box).

[CraigC]

function DataState(ds: TDataSet): Boolean;
begin
  if ds.State in [dsEdit, dsInsert] then
    Result := True
  else
    Result := False;
end;

Yeah, dataset should be in dsEdit or dsInsert.  I don't call post anywhere.   Transaction should be active but I get errors that the dataset is not in dsEdit or dsInsert.  The indicator on the dbgrid, tells a different story.  It shows edit mode.

[rvk]

Transaction should be active but I get errors that the dataset is not in dsEdit or dsInsert.  The indicator on the dbgrid, tells a different story.  It shows edit mode.

On what line do you get the error?

BTW. not sure about SQLite, but it could be that Commit and Rollback also closes the dataset.
(unless you have sqoKeepOpenOnCommit in the TSQLQuery.Options)

You can trace/debug through the program and see where the qry.Sate flips to dsInactive or dsBrowse.