TDirectoryEdit with OnAfterDialog event?

[dsiders]

After fiddling with TDirectoryEdit for a while, I find myself in need of a way to determine whether the dialog for the control changed anything after the dialog was executed. TDirectoryEdit does not provide a ModalResult for the dialog execution. I thought the Boolean value used in RunModal might be useful in an OnAfterDialog(ASuccess: Boolean) event - where ASuccess is the Boolean value captured in RunDialog. It could be called as the last action in RunDialog.

TDirectoryEdit is not present in VCL - so it shouldn't be a compatibility issue (not that really matters to me).

Have I missed something else that might already be available? OnChange is key-by-key changes during direct input. OnAcceptDir only happens if the dialog was successfully executed (not cancelled). I'm primarily interested in the fact that it was cancelled.

Opinions?

[jamie]

The "Modified" property does not work for you?

P.s.
 How about the OnAcceptDirectory?

Jamie

[dsiders]

The "Modified" property does not work for you?

No it doesn't.

How about the OnAcceptDirectory?

See above.

[Bart]

I'm primarily interested in the fact that it was cancelled.

That makes me curious: why?
What's your use case?

Bart

[dsiders]

I'm primarily interested in the fact that it was cancelled.

That makes me curious: why?
What's your use case?

I'm trying to build a navigation panel for TShellListView. It's a composite of TToolbar and TDirectoryEdit. Click on the client area of the toolbar and it displays a directory edit. Run the dialog for the directory edit and it returns to the toolbar. There is an event for successful completion of the dialog (OnAcceptDir) but nothing for cancellation. Both conditions should return to the toolbar.

See attached.

[JuhaManninen]

Maybe a "OnCancelButton" event should be added. It should be in the base class and available for other similar controls, too.

[dsiders]

Maybe a "OnCancelButton" event should be added. It should be in the base class and available for other similar controls, too.

I may be interested in the Cancel action... but I think it would be more generally useful for after dialog execution. Actually, it would be better if RunDialog returned a modal result instead of a Boolean that could be signalled to an OnAfterDialog event. But I'm not trying to redesign the whole control.

Maybe TDirectoryEditEx for ExCtrls. Just thinkin' out loud...

[JuhaManninen]

Actually, it would be better if RunDialog returned a modal result instead of a Boolean that could be signalled to an OnAfterDialog event.

Currently procedure TDirectoryEdit.RunDialog;
does not return anything but TCommonDialog.Execute inside it return a Boolean.
A new OnAfterDialog event could have a ModalResult parameter indeed. However OnAcceptDirectory is still needed not to break existing code. Thus a new OnCancelDialog event could suffice.
Something like in the attached patch.

[Bart]

For consistency it then should be added to each and every TCustomAbstractGroupedEdit derived control that has it's Buddy exectue aome kind of dialog.
I don't think I really like the idea.

Bart

[dsiders]

For consistency it then should be added to each and every TCustomAbstractGroupedEdit derived control that has it's Buddy exectue aome kind of dialog.

TCustomAbstractGroupedEdit might be a little too far up the ancestry. Not every TCustomAbstractGroupedEdit descendant runs a dialog. TCustomEditButton might be a better candidate - but I'm not sure if all of those actually run a dialog.

I don't think I really like the idea.

I wasn't asking for the change. Just tossing an idea around. I'm more than likely going to create my own descendant.

[Bart]

I'm more than likely going to create my own descendant.

Yeah, probably the way to go for now.

Bart