[workaround found] How to get the sender within a frame?

[Nicole]

There is a method, which I shifted into a frame:

Code: Pascal  [Select][+][-]

1. // ruft die Berichterstellung und übergibt damit Modus Tag
2. procedure TFrame_BerichteF.SpeedButton_TagesberichtErstellenClick(Sender: TObject);
3. begin
4.    Berichte_erstellen(self);
5. end;

Bericht = report in English
The problem: "self" does not point at the calling Speedbutton any more, but on the frame, which holds it.

The thing generates different reports dependent to the button, which calls it.
It would be easy to give a parameter alike 'daily report' or so. Unfortunately the click event does now allow to pass parameters other than sender. Or does it?

How to solve it?
Yes, I can write a calling rountirne, but this becomes more and more ugly.
Is there a smart solution?

What I need:
A information of which button a certain report is asked for.

[Fibonacci]

Am I missing something? Sender is the button, Self is the frame containing it.

[rvk]

Berichte_erstellen isn't an event so you can change it to receive multiple parameters.

So:

Code: Pascal  [Select][+][-]

1. // ruft die Berichterstellung und übergibt damit Modus Tag
2. procedure TFrame_BerichteF.SpeedButton_TagesberichtErstellenClick(Sender: TObject);
3. begin
4.    Berichte_erstellen(self, Sender);
5. end;

In Berichte_erstellen you can examine the Sender and act accordingly.

[Nicole]

I read "wrong number of parameters" and if I use a dot instead of a comma "does not have such a member".

[rvk]

I read "wrong number of parameters" and if I use a dot instead of a comma "does not have such a member".

I said you needed to change the definition of the procedure Berichte_erstellen. Did you do that???
Berichte_erstellen doesn't seem to be a click event so you could change it.

(if it is a event then you need to show a lot more code)

So:

Code: Pascal  [Select][+][-]

1. procedure Berichte_erstellen(Sender: TObject; ButtonPressed: TObject);

[Thaddy]

Isn't it simply:

Code: Pascal  [Select][+][-]

1. // ruft die Berichterstellung und übergibt damit Modus Tag
2. procedure TFrame_BerichteF.SpeedButton_TagesberichtErstellenClick(Sender: TObject);
3. begin
4.    Berichte_erstellen(sender);
5. end;

[Nicole]

@Thaddy, thank you for the solution, but this does not work, I tried before.
The sender is "TSpeedButton", but not the specific speed button.

In the meanwhile, I change it to a combination of all and special rvk's inspirations.
If I must change the function, I can change sender to string as well.

Code: Pascal  [Select][+][-]

1. // ruft die Berichterstellung und übergibt damit Modus Tag
2. procedure TFrame_BerichteF.SpeedButton_TagesberichtErstellenClick(Sender: TObject);
3. begin
4.    Berichte_erstellen('TagesberichtErstellen');
5. end;

works.

[Martin_fr]

"Self" should never have been the speedbutton. (Unless you had subclassed TMySpeedbutton = class(TSpeedButton) )

"Self" most likely (almost certain) was the TForm.

"Sender" should be the clicked speedbutton. If not, then you must have something very unexpected somewhere else.

[Nicole]

oh yes, this had worked for years.
After the re-shaping of panels and frames, I clicked the usual button and - nothing happened any more.

This "Sender" always has been mysteriously to me.
It does not behave in the usual way parameters do. And just deleting it brings troubles sometimes.
I bet it comes from the stone-age of programming.

[rvk]

It does not behave in the usual way parameters do.

Sure it does. It's just that it you want to know who called the event and want to use it's parameters you need to cast it to the correct class.

And just deleting it brings troubles sometimes.

Why would you delete it? It's part of the defined procedures in event.
It's a parameter so you know who called the event.
You can delete is but then you also need to change a lot more from where it's called, usually a doclick in the inherited class which you then need to override. But it's not advised (even if you don't use the sender in your event handler).

I bet it comes from the stone-age of programming.

Nope, you just need to know why it's passed and how to use it.
I guess you skipped those parts of all the beginner guides you needed to read 

[egsuh]

Sender is TObject. So, if you want to do anything meaningful, you have to type case it.

For example,

Code: Pascal  [Select][+][-]

1. procedure TFrame_BerichteF.SpeedButton_TagesberichtErstellenClick(Sender: TObject);
2. begin
3.     ShowMessage((Sender as TSpeedButton).caption);
4.  
5.      // or you may write as follows if you are reading caption, as property Caption is available from TControl in the inheritance tree.  
6.  
7.     ShowMessage((Sender as TControl).caption);
8.  
9.     Berichte_erstellen(Sender);
10. end;

So if the Sender of Berichte_erstellen is always TSpeedButten, then you can define and call as :

Code: Pascal  [Select][+][-]

1. procedure  Berichte_erstellen(SpeedButton:TSpeedButton);
2. begin
3.      with SpeedButton do begin
4.          // do Something;
5.       end;
6. end;
7.  
8. // And calll
9.  
10. procedure TFrame_BerichteF.SpeedButton_TagesberichtErstellenClick(Sender: TObject);
11. begin
12.     Berichte_erstellen(Sender as TSpeedButton);
13. end;

OR,

Code: Pascal  [Select][+][-]

1. procedure  Berichte_erstellen(SpeedButton:TObject);
2. begin
3.      with SpeedButton as TSpeedButton do begin
4.             // do Something
5.      end;
6. end;
7.  
8. // And calll
9.  
10. procedure TFrame_BerichteF.SpeedButton_TagesberichtErstellenClick(Sender: TObject);
11. begin
12.     Berichte_erstellen(Sender);
13. end;

[Thaddy]

You can put that in concrete by also using

Code: Pascal  [Select][+][-]

1. if sender is TSpeedButton then

I have to test that for actions, though: I always program through actions when writing a user interface and that does not work: Sender is TAction, not TSpeedButton.
You need to be aware of that.

[creaothceann]

Code: Pascal  [Select][+][-]

1. if sender is TSpeedButton then

Would silently fail if some other component is calling that function by mistake.

[egsuh]

I always program through actions when writing a user interface and that does not work: Sender is TAction, not TSpeedButton.

Hmmm... I think I had experienced the same issue, and defined at ButtonClick, etc. instead of Action. I needed to recognize which button called the event handler.

[Thaddy]

The name....
With actions that is basically irrelevant, otherwise:

Code: Pascal  [Select][+][-]

1.  TSpeedButton(sender).name