Hints for method name missing comments

[dsiders]

Glad it's solved... but I'm confused.
Why does a variable declared as Boolean not default to False?

[CM630]

Yep, you have fixed it Juha, now works as it should !  Once again, I thank you !

Lets hear from CM630 ?
...

Sorry, I did not understand what I shall say or do?

[dbannon]

Sorry, I did not understand what I shall say or do?
[/quote]

I'm wondering if that solves https://forum.lazarus.freepascal.org/index.php/topic,70369.msg548794.html#msg548794

Davo

[dbannon]

Glad it's solved... but I'm confused.
Why does a variable declared as Boolean not default to False?

No default is applied if its declared in a method as I understand it.

Davo

[CM630]

I'm wondering if that solves https://forum.lazarus.freepascal.org/index.php/topic,70369.msg548794.html#msg548794

Hm, how could I test it?
Run FCUPDeluxe, select FPC Version = Trunk, Lazarus Version = fixes-4.0 , the press Install / update FPC + Lazarus?

...
I fixed it in 95eaa30d4e. Please test. I merged it to fixes_4.

No idea what the bold things mean, so I am guessing.

[dbannon]

Sorry CM, was not trying to get you to do things outside your comfort zone.

Yep, fpupdeluxe would work if you like that. Would you consider using that rather than your existing install in future ?   If not, maybe its not worth the effort ?  Your call.

Davo

[CM630]

Lazarus 4.1 (rev lazarus_4_0-77-gc52a98dba2) FPC 3.3.1 i386-win32-win32/win64
Trying to compile my control, that builds in Lazarus 4.0.
I get :
scales.pas(99,31) Error: This kind of property cannot be published for   

Code: Pascal  [Select][+][-]

1.   property Format : TFormat read FDisplayFormat write SetDisplayFormat;

in:

Code: Pascal  [Select][+][-]

1. TDisplayFormat = class(TPersistent)
2.   private
3.     FParent : TWinControl;
4.  
5.     FDisplayFormat: TFormat;
6.     FPrecision : UInt8;
7.   public
8.     constructor Create(aParent: TWinControl); //override;
9.     destructor Destroy; override;
10.     procedure SetDisplayFormat(Value: TFormat);
11.     procedure SetPrecision(Value: UInt8);
12.   published
13.     property Format : TFormat read FDisplayFormat write SetDisplayFormat;
14.     property Precision : UInt8 read FPrecision write SetPrecision;
15. end;    

TFormat is   

Code: Pascal  [Select][+][-]

1. TFormat =              (FloatingPoint = 0, Scientific = 1, Binary = 3, Octal = 4, Hexadecimal = 5, RelativeTime = 6, AbsoluteTime = 7, SINotattion = 8, AutomaticFormatting = 9, Decimal = 9);

Then I tried TLazSerial, added comments for two properties (one with a space after // and another without a space), and they are shown, so the issue seems to be fixed (see the image attached).

Another oddity that I noticed is that loading APKs is very slow (the time from selecting an LPK from the file dialogue until the LPK window is shown).

[MarkMLl]

edit : wow, that issue has a history !  Your persistence paid off Juha.

Regrettably, I'll have to leave my unit generator at https://github.com/MarkMLl/dynamod unchanged since it is going to be a very long time before it's safe to assume that the average Github user is on a fully-fixed v4.

I know that I'm being reactionary (or something) here, but if I publish Pascal code I want it to be usable by anybody, not just by those committed enough to ignore the version of Lazarus made available by their distro/store and work out how to use the very latest version published by the Lazarus project itself.

MarkMLl

[MarkMLl]

Martin no, I am not using fpdoc. And my problem is not duplicate comments, its no comments !

OK, particularly noting the machine-generated example at https://forum.lazarus.freepascal.org/index.php/topic,71559.msg558705/topicseen.html this looks like something I need to be aware of. Where is the markup format documented?

MarkMLl

[dsiders]

Martin no, I am not using fpdoc. And my problem is not duplicate comments, its no comments !

OK, particularly noting the machine-generated example at https://forum.lazarus.freepascal.org/index.php/topic,71559.msg558705/topicseen.html this looks like something I need to be aware of. Where is the markup format documented?

MarkMLl

What markup format? It's a comment.

The example you point to is not fpdoc tagging... even though it says it is. It pidgin PasDoc, and fpdoc knows nothing about PasDoc. So unless you're using PasDoc and not FPDoc to generate help... there is no markup for in-source comments.

[JuhaManninen]

I fixed it in 95eaa30d4e. Please test. I merged it to fixes_4.

No idea what the bold things mean, so I am guessing.

https://gitlab.com/freepascal.org/lazarus/lazarus/-/commit/95eaa30d4e183636f12e791128ea983d5605cfb0
https://gitlab.com/freepascal.org/lazarus/lazarus/-/commit/59d8be35fd76497695f64d2722a4ec499bcbbadd

Regrettably, I'll have to leave my unit generator at https://github.com/MarkMLl/dynamod unchanged since it is going to be a very long time before it's safe to assume that the average Github user is on a fully-fixed v4.

How is that related to the comment hints?

[MarkMLl]

Regrettably, I'll have to leave my unit generator at https://github.com/MarkMLl/dynamod unchanged since it is going to be a very long time before it's safe to assume that the average Github user is on a fully-fixed v4.

How is that related to the comment hints?

An earlier posting queried fpdoc

Maybe https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/14384

Though yours don't seem to have fpdoc info...

which I assumed related to markup in comments relating to parameters and return value.

MarkMLl

[JuhaManninen]

which I assumed related to markup in comments relating to parameters and return value.

Ah, OK.
No markup there. The comment shown in a hint is kind of a fallback plan when there is no fpdoc XML documentation.

[MarkMLl]

No markup there. The comment shown in a hint is kind of a fallback plan when there is no fpdoc XML documentation.

The comment-used-as-hint I obviously knew about. But from the link I posted https://forum.lazarus.freepascal.org/index.php/topic,71559.msg558705/topicseen.html I assumed that there was a very small amount of internal markup... or was that related strictly to his project?

MarkMLl