Recent

Author Topic: Action List Editor - RH frame not scaled  (Read 6852 times)

dgrhoads

  • New Member
  • *
  • Posts: 39
Action List Editor - RH frame not scaled
« on: December 27, 2024, 07:41:27 pm »
My computer is a Windows 10 laptop with a PPI of 240.

On display of the ActionList Editor, there are two frames, the left one containing the action category, the right one containing the action item.  The left one is scaled correctly.  The list of items in the right hand frame overlap substantially, leading me to conclude that the list of items in that frame are not scaled.

I have looked hgh and low for a solution but without sucess.  I suspect that somewhere in the guts of the LCL, there exists the design of the frame and that its scaling of the RH frame was not set to true. 

How do I deal with this issue?

wp

  • Hero Member
  • *****
  • Posts: 12593
Re: Action List Editor - RH frame not scaled
« Reply #1 on: December 27, 2024, 08:07:04 pm »
How do I deal with this issue?
Ideally you should post a bug report (https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues). Please mention your Lazarus version. And you should add a screenshot at 240 ppi.

dgrhoads

  • New Member
  • *
  • Posts: 39
Re: Action List Editor - RH frame not scaled
« Reply #2 on: December 27, 2024, 09:25:54 pm »
Lazarus version  3.6

Screenshot enclosed.

lainz

  • Hero Member
  • *****
  • Posts: 4686
  • Web, Desktop & Android developer
    • https://lainz.github.io/
Re: Action List Editor - RH frame not scaled
« Reply #3 on: December 28, 2024, 01:25:45 am »
And where's the bug report?

dgrhoads

  • New Member
  • *
  • Posts: 39
Re: Action List Editor - RH frame not scaled
« Reply #4 on: December 28, 2024, 03:58:09 am »
I apologize for not knowing the protocol for submitting bug reports.  In fact when I started this, I was not sure that what I was observing was a bug.  However as you can tell, I am a "New User" here even though I've been using Lazarus intermittently for many years. 

As requested, I did go to the bug tracker for Lazarus to submit the bug report.  However I found it to be intimidating and confusing.  wp had asked me to submit images.  I didn't see where I could include them in the bugtracker.  So I have returned here to submit my bug report.

Windows 10 laptop   240 PPI.  Lazarus 3.6, FPC 3.2.2
Optimal scale factor:  3.6x to place 16x16 images in TToolButtons (55h x 58w)

On rethinking my bug report, I find two scaling issues and a request.

1) the initial issue that the lines in the RH frame of the ActionList editor overlap.  This is illustrated in the first jpg file.  There should be no overlap.

2) I also find that none of the images in the ImageList editor are scaled. Not after selection and not during the display of icons during Add phase.  All images should be scaled.  A second jpg file is attached.

3) A request.  As shown in the ImageList editor jpg file, the images are simply displayed without their names.  It would be helpful if the image file names could be listed next to the image.

Thank you for your dedication and effort to developing and maintaining this excellent development system.  I very much appreciate it.

wp

  • Hero Member
  • *****
  • Posts: 12593
Re: Action List Editor - RH frame not scaled
« Reply #5 on: December 28, 2024, 10:15:13 pm »
I think I found the issue. But since I don't have access to such a high screen resolution I would like you to make the following check before I commit to the repository:
  • Unzip the attached file into the folder "components/ideintf" of your Lazarus 3.6 installation. It will replace the file "actionseditor.pas" (I'd recommend to make a backup copy of this file before doing this).
  • Open the IDE and go to "Tools" > "Build Lazarus with Profile ..." - this will rebuild the IDE to contain the modified file.
  • After a while the IDE restarts, and you can check if the issue has been solved.
As for your imagelist issues, you should read https://wiki.freepascal.org/TImageList#How_to_create_a_multi-resolution_ImageList_in_the_application.
« Last Edit: December 28, 2024, 10:35:10 pm by wp »

dgrhoads

  • New Member
  • *
  • Posts: 39
Re: Action List Editor - RH frame not scaled
« Reply #6 on: December 29, 2024, 04:33:30 am »
I did as you specified but it did not fix the problem.  It looked just the same as before.

Sorry.

Thanks for pointing me to that writeup on images.

wp

  • Hero Member
  • *****
  • Posts: 12593
Re: Action List Editor - RH frame not scaled
« Reply #7 on: December 29, 2024, 12:16:43 pm »
I checked again (Win 11, 144 ppi or 168 ppi, ease of access font size 100% or 150%), it should work.

Probably you did not assign the new OnActivate handler. Because I did not tell you... In my first version of my post, I listed all the individual steps to patch the file, but this became very complicated, and I decided to send the completely modified unit instead. But I forgot about the lfm file which was modified by my steps as well.

So, please try again with the new attachment which now contains also the lfm file (unzip into components/ideintf of your Laz3.6 installation).

dgrhoads

  • New Member
  • *
  • Posts: 39
Re: Action List Editor - RH frame not scaled
« Reply #8 on: December 30, 2024, 03:09:39 am »
It works.  The thing I had to do was to delete the old ActionList and then create a new one.  At that point, it worked.  It did not work with the previous ActionList.

Just to recap, what I did was:
- Unzipped the files in the component\identf folder.
- Checked to make sure the two current files were new ones from you.
- From Lazarus, executed the "Build..." command.
- Restarted my computer (probably unnecessary)
- Launched Lazarus
- Open the app which included the ActionList.
- Tested the ActionList - failed.
- Deleted the ActionList
- Added a new ActionList component and added a few actions. - Worked.

I agree with your experience that giving instructions is not easy.  Thank you for your effort and your patience.

wp

  • Hero Member
  • *****
  • Posts: 12593
Re: Action List Editor - RH frame not scaled
« Reply #9 on: December 30, 2024, 12:20:09 pm »
The thing I had to do was to delete the old ActionList and then create a new one.  At that point, it worked.  It did not work with the previous ActionList.
Strange. I don't understand why this is necessary.

Anyway, I committed the new version (with slightly different code) to the Laz/main, Laz/Fixes_4 and Laz/Fixes_3 branches.

 

TinyPortal © 2005-2018