How single procedure ends in different results

[Marion]

I have a procedure that dynamically adds controls to a TScrollBox with the ChildSizing.ControlsPerLine = 1 so the controls stack from top to bottom. When the ScrollBox starts empty then the child controls are the correct height (See image with empty TEdit). Once a user enters text and saves the dialog, the next time they come back to the form, I repopulate the rows and add the text but now the TEdits are short. When I add a new (empty) row, all of the rows (including the previous ones) stretch to the right height. I'd like to fix this if someone knows what's going on.

Below is the procedure used to add all of the rows to the ScrollBox:

Code: Pascal  [Select][+][-]

1. function TfrmOptions.DiceTrayRowAdd: TPanel;
2. var
3.   pnlRow: TPanel;
4.   txtName, txtFormula: TEdit;
5. begin
6.  
7.   pnlRow := TPanel.Create(boxDiceTray);
8.   pnlRow.Parent := boxDiceTray;
9.   pnlRow.Tag := FDiceRow;
10.   pnlRow.BevelOuter := bvNone;
11.   pnlRow.ChildSizing.ControlsPerLine := 2;
12.   pnlRow.ChildSizing.EnlargeHorizontal := crsHomogenousChildResize;
13.   pnlRow.ChildSizing.Layout := cclLeftToRightThenTopToBottom;
14.   //pnlRow.Name := Format('pnlDiceRow%d', [FDiceRow]);
15.   pnlrow.Caption := '';
16.   pnlRow.OnEnter := @DiceTrayRowEnter;
17.  
18.   txtName := TEdit.Create(pnlRow);
19.   txtName.Parent := pnlRow;
20.   //txtName.Name := Format('txtDTName%d', [FDiceRow]);
21.   txtName.Text := '';
22.   txtName.MaxLength := 20;
23.   txtName.OnKeyUp := @DiceTrayRowKeyUp;
24.  
25.   txtFormula := TEdit.Create(pnlRow);
26.   txtFormula.Parent := pnlRow;
27.   //txtFormula.Name := Format('txtDTFormula%d', [FDiceRow]);
28.   txtFormula.Text := '';
29.   txtFormula.MaxLength := 40;
30.   txtFormula.OnKeyUp := @DiceTrayRowKeyUp;
31.  
32.   if txtName.CanFocus then txtName.SetFocus;
33.   FDiceRow := FDiceRow+1;
34.   result := pnlRow;
35. end;
36.  

[CharlyTango]

You will certainly have a reason why you choose a solution with a TScrollbos, which is significantly more complex and problematic than other controls.

I would try to solve such “simple” inputs with a TStringgrid, for example

[jamie]

AutoSize is set to true maybe?

in any case, I am not sure how the child sizing works but best guess is it may use the FONT height. Maybe you need to set that in the EDIT fields.

[Marion]

I finally fixed it. I had to add a Contraints.MinHeight = 40 to each of the TEdits and now it works as expected.