GetFileSizeEx function missing

[440bx]

Hello,

The definition of GetFileSizeEx is missing in Windows.pas.

Possible definitions:

Code: Pascal  [Select][+][-]

1. const
2.   kernel32 = 'kernel32';
3.  
4. { missing definitions                                                         }
5.  
6. function GetFileSizeEx
7.            (
8.             InFileHandle : THANDLE;
9.             OutFileSize  : PLARGE_INTEGER
10.            )
11.          : BOOL; stdcall; external kernel32;   { no need to specify the name  }
12.  
13.  
14. function GetFileSizeEx
15.            (
16.             InFileHandle : THANDLE;
17.             OutFileSize  : pint64
18.            )
19.          : BOOL; stdcall; external kernel32; overload;
20.  
21.  

The first definition mirrors the MSDN definition exactly (except the parameter names which are of no relevance.)  The second one would be a "nice to have" overload since FPC supports 64 bit integers without having to resort to the LARGE_INTEGER structure.

Two more overloads are possible using "var" to eliminate the need for pass a pointer to either function.

ETA:

forgot to mention, this applies to FPC v3.2.2.  I don't know if the definition has already been added in an upcoming version.

[paweld]

function is available in FPC 3.2.2 - attach JwaWinBase unit to uses section

[Thaddy]

Or simply jwaWindows which solves more than that problem.
And yes, It can be replaced with var, but you have to convince Marcov and I did not succeed in doing that in the past odd 20 years or so.
Just that the API can not express var. The - OLD - Delphi developers were a bit more analytic about those calls and made them safe from the start.

[440bx]

function is available in FPC 3.2.2 - attach JwaWinBase unit to uses section

I know that but, that should not be necessary.  GetFileSizeEx is documented and defined in kernel32 which is a "bread and butter" dll.  For that reason it should not be necessary to include some other unit/file to access a very common API.

[Thaddy]

Posts crossed, was editting...
(Marcov did provide a compat unit, btw, so I do not blame him for everything)

[440bx]

(Marcov did provide a compat unit, btw, so I do not blame him for everything)

Just for the record, I'm not blaming anybody for anything.

I would just like to see that function included in the Windows unit because it is a common, documented and often used function.  That's all, no more, no less.

[AlexTP]

I posted the bugreport https://gitlab.com/freepascal.org/fpc/source/-/issues/40996

[Thaddy]

It was a light harted remark that Marcov understands.

[440bx]

Thank you Alex.

I was going to wait for @marcov's view on the matter but, as you have probably noticed, I do believe it should be included in the Windows unit.


@Thaddy, ok, no harm done.

[Thaddy]

Knowing Marcov a bit he possibly add it to the compat unit.

[marcov]

Done. redef.inc  with special overloads is just an include file, not an unit btw. 440bx probably knows since he is a regular submitter of windows unit issues.

Note that recommending jwa* should be clearly marked as temporary solution. I'm not sure how 64-bit ready the JWA* units  are.

[440bx]

Done.

Thank you Marco.

Note that recommending jwa* should be clearly marked as temporary solution. I'm not sure how 64-bit ready the JWA* units  are.

and in addition to that, I've seen a few errors in the definitions of ntdll functions.  I should have reported those but, I was focused on something else then forgot and now I don't remember which functions.  I do remember that a fair number of them were in definitions of functions in ntdll (some documented, some not.)  The same for internal Windows structures, a fair number of them have not been updated to reflect more recent versions of Windows.

Personally, I'd recommend leaving the Jwa* definitions alone.  They were probably fine at one time but, I think that now they are outdated and, as a result, a bit risky to use.

[Thaddy]

Tnx Marco, also for the fix.