Broken Icon Display on macOS

[msintle]

Try the attached icon (for example), it does not display correctly with Trunk, Stable, 3.4, or Fixes (FPCUPDLX).

Used to work in earlier versions (pre-3.4 timeline).

Any thoughts?

[paweld]

And can you specify what according to you is wrong with this icon in Lazarus trunk? I checked with myself on the trunk version and according to me everything is fine

[msintle]

macOS.

[circular]

How do you use the icon? It would help to provide a test project.

[msintle]

Just load it into a TImage, and you will see the problem.

[circular]

Ok, so this seems to be an LCL bug.

Checking it has not been reported yet:
https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/?sort=created_date&state=opened&label_name%5B%5D=WS%3A%20Cocoa&search=icon&first_page_size=20
https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/?sort=created_date&state=opened&search=icon&search=macOS&first_page_size=20

The bug seems it hasn't been reported yet. I suggest to make a bug report there:
https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues

Regards

[msintle]

Done:

https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/41131

Upvotes appreciated, given the severity of the issue.

[wp]

Try the attached icon (for example), it does not display correctly [...]

What do you expect? Are you aware that an icon file can contain several images, and maybe you just see one of them that you do not expect? Load the ico file as icon of a test application ("Project options" > "Load icon"; there is a scroller below the displayed icon which you can use to look at the other images in the ico.

[circular]

Done:

https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/41131

Upvotes appreciated, given the severity of the issue.

Thank you very much for posting the bug report. The bug is now correctly identified and being fixed.

As the developer taking care of it says, it is helpful to have a screenshot when it comes to visual bugs. Is it that you have difficulty making a screenshot? On MacOS, this can be achieved by pressing Shift+Cmd+4 and selecting an area of the screen.

[msintle]

Didn't realize it would be such a big deal to nail down the appearance.

I have attached both appearances herewith, hope it helps.

First image is incorrect, the second is correct.

Edit: The bug report has already reproduced the exact issue I am seeing.

[circular]

That's great! We can clearly see what part is not drawn.

It reduces the ambiguity about what the problem is and whether it will be solved.

Thank you very much indeed. 

[msintle]

That's great! We can clearly see what part is not drawn.

It reduces the ambiguity about what the problem is and whether it will be solved.

Thank you very much indeed. 

You are absolutely very welcome, can we be hopeful for any fix ETA?

[wp]

ETA = estimated time of arrival?

Don't ask, we're all volunteers without payment. You could help by working on the issue yourself and send a patch. That's "open source".

[msintle]

ETA = estimated time of arrival?

Don't ask, we're all volunteers without payment. You could help by working on the issue yourself and send a patch. That's "open source".

Yeah I know. We've sponsored some bug bounties for the aarch64 build of Lazarus on Windows, and we could also sponsor bug bounties here too, I suppose.

It's just disappointing to have to deal with so many regressions all at once, on top of actually shipping our own code, if you know what I mean?

I mean this - and https://forum.lazarus.freepascal.org/index.php/topic,68506.0.html - are regressions pure and simple.

One would hope it'd be a matter of just rolling back the errant changes, but what do I know, right?

There could be many underlying reasons of which I am currently totally unaware.

[wp]

If you use Lazarus/FPC in production you should not base your software on the main (trunk) versions. They are in active development, and it is always possible that bugs creep in.