Proper way to terminate a thread?

[alpine]

Just to make sure we're talking about the same thing: I'm speaking about TThread.Finished, not TThread.Terminated.

You're right. Finished is just what I've meant by 'Completed'. It goes True just before FreeOnTerminate check in ThreadFunc. No need to introduce anything new.
Sorry, my bad.

[rvk]

BTW. What's wrong with using TThread.WaitFor on a terminated, but net yet freed TThread ??

This works for me:

Code: Pascal  [Select][+][-]

1. type
2.   TMyThread = class(TThread)
3.   private
4.   protected
5.     procedure Execute; override;
6.   end;
7.  
8. procedure TMyThread.Execute;
9. begin
10. end;
11.  
12. //...
13. var
14.   T: TMyThread;
15. begin
16.   T := TMyThread.Create(false);
17.   Sleep(2000);
18.   T.Terminate;
19.   T.WaitFor; // even though there is no Execute (or has finished) WaitFor should still work but passthrough
20. end;

So the original problem, where WaitFor is a problem when the thread has already terminated, but not freed, lies somewhere else.

[alpine]

BTW. What's wrong with using TThread.WaitFor on a terminated, but net yet freed TThread ??

Nothing wrong! Otherwise it will be almost useless ...
As a matter of fact it works from the very moment of TThread.Create until finally freed.

[Thaddy]

Indeed.