Velthuis.Console.pas - Won't compile in Lazarus

[Atak_Snajpera]

Another incompatibility. This time I'm trying to compile project which uses Velthuis.Console.pas
https://i.postimg.cc/zD9Lk4p1/Capture.png

I'm real noob when it comes to porting from old to new code in lazarus.

[jamie]

There are two defines to chouse from.

 One is a direct variable of your smallRect and the other is a Pointer..

 Type case the questionable Rect like this

 PSmall_Rect(@Rect);
 
 or maybe remove the "@" and try that.

[cdbc]

Hi
From the looks of things, you should skip the '@' in the second 'Rect' parameter?!?
The compiler says, it expects a 'smallrect', but gets a pointer(@Rect) instead...
Regards Benny

[TRon]

The headers are defined incorrectly for that function, at least in jwawincon. I do not know about which include file gets dragged in for windows because the redef.inc file also seem to define the function header incorrect.

Both rects should be pointers to small_rect.

see also ms

[marcov]

The headers are defined incorrectly for that function, at least in jwawincon. I do not know about which include file gets dragged in for windows because the redef.inc file also seem to define the function header incorrect.

Redef.inc contains overloads for functions that are either specified as VAR in Delphi or at some point in FPC (the original header conversion favoured changing to VAR) and are kept for historic reasons. Most have pointer definitions elsewhere, in this case in ascfun.inc.

440bx and others have pointed out many remaining problems, and each new release a few more are fixed. If you encounter problems, search trunk rtl/win/wininc for the identifier and see if there is a valid prototype (overload selection is a different problem). If there isn't, report a bug.

[Thaddy]

I never had problems using Rudy's code in FPC using my own translation for this particular code and have been using it intensively. As long as the declarations are correct - and they are for Delphi style. Maybe constref?
Note that there is also a rect function, not structure, and as far I can recall that causes problems depending on unit order. We can't asked him, because he passed away a couple of years ago, way to young. Good programming friend. We used to work on C++ interop.
I will look up what I did shortly after the date he published it.
There also exist at least two versions of it: one without dotted notation (older) and the onne with the dotted notation. I have both.

[TRon]

OK, noted marcov. Thank you for the explanation(s).

@Atak_Snajpera

Change line where it reads:

Code: Pascal  [Select][+][-]

1. ScrollConsoleScreenBufferA(StdOut, Rect, @Rect, NewPos, Fill);
2.  

to

Code: Pascal  [Select][+][-]

1.   ScrollConsoleScreenBufferA(StdOut, @Rect, @Rect, NewPos, @Fill);
2.  

Then the next problem:

Code: Pascal  [Select][+][-]

1.   ReadPtr := T.BufPtr;
2.  

to

Code: Pascal  [Select][+][-]

1.   ReadPtr := PChar(T.BufPtr);
2.  

Then you would have to implement your own setinoutres procedure (because I was unable to find it implemented for Free Pascal), see also embarcadero and FPC inoutres var

something like:

Code: Pascal  [Select][+][-]

1. procedure SetInOutRes(NewValue: Integer);
2. begin
3.   InOutRes := NewValue;
4. end;
5.  

And finally in the WaitForProcess.lpr file:

Code: Pascal  [Select][+][-]

1.     info:STARTUPINFO;
2.  

to

Code: Pascal  [Select][+][-]

1.     info:STARTUPINFOA;
2.  

And then the code you posted seem to (cross) compile for me.

edit: updated answer to reflect marcov's explanation(s)

[Thaddy]

I looked it up. There are very few changes, a cast and a FPC define.
(I already wondered why people had some much trouble with it, sigh, even diehards)
Here is the working code, I tested it and still works:

[Atak_Snajpera]

I copied your updated Velthuis.Console.pas and I get this instead
https://i.postimg.cc/PJt8mDTF/Capture.png

[Thaddy]

That is very strange, because that is 16 bit code . I compiled 64bit Windows 11. I will have a look.
Found it: The cheeky dentist made it also Delphi 1 compatible.
Corrected version attached. Both of us did not find that in 2008! We also had a Linux version discussed (Kylix), but was never fnished.
Still using 32 bit Windows? Anyway, I kept it still  somewhat Delphi1 compatible.
In honor of the author.
Try this one, I only changed the order of the Winversion test to be exact:

[Atak_Snajpera]

Still the same error. I'm on win7 x64.
https://i.postimg.cc/0NrQqqCj/Capture.png

[Thaddy]

No clue and no time: it will compile 32/64 bit and there are no win7 specifics involved.
The code simply compiles for those two targets. You can remove the hardware calls altogether, but I won't do that.

[jamie]

Code: Pascal  [Select][+][-]

1. var
2.   NewPos:TCoord;
3.   Fill:TCharInfo;
4.   Rect:Small_Rect;
5. begin
6. //.......
7. Windows.ScrollConsoleScreenBuffer(StdOutPutHandle, Rect,Rect, NewPos,Fill)
8. end;                                                                         [
9. [code]
10.  
11. Compiles.
12.  

[Fibonacci]

Still the same error. I'm on win7 x64.
https://i.postimg.cc/0NrQqqCj/Capture.png

Try adding "assembler" keyword, like this:

Code: Pascal  [Select][+][-]

1. procedure xxx; assembler;
2. asm
3. // ...
4. end;

And {$asmmode intel} somewhere at the top

[marcov]

If you try to get Delphi code compiling, make sure you use {$mode delphi}