[SOLVED] Conditional Defines in PQConnection.pp in branch fixes_3_2

[chrisv5]

I have finally given up working around the countless bugs in PQConnection in FPC "stable". I had decided to start using fixes_3_2, but that has yet another problem:

Code: Pascal  [Select][+][-]

1.     {$IFNDEF VER3_2}
2.     SEVERITY:=PQresultErrorField(res,PG_DIAG_SEVERITY);
3.     SQLSTATE:=PQresultErrorField(res,PG_DIAG_SQLSTATE);
4.     MESSAGE_PRIMARY:=PQresultErrorField(res,PG_DIAG_MESSAGE_PRIMARY);
5.     MESSAGE_DETAIL:=PQresultErrorField(res,PG_DIAG_MESSAGE_DETAIL);
6.     MESSAGE_HINT:=PQresultErrorField(res,PG_DIAG_MESSAGE_HINT);
7.     STATEMENT_POSITION:=PQresultErrorField(res,PG_DIAG_STATEMENT_POSITION);
8.     SCHEMA_NAME:=PQresultErrorField(res,PG_DIAG_SCHEMA_NAME);
9.     TABLE_NAME:=PQresultErrorField(res,PG_DIAG_TABLE_NAME);
10.     COLUMN_NAME:=PQresultErrorField(res,PG_DIAG_COLUMN_NAME);
11.     DATATYPE_NAME:=PQresultErrorField(res,PG_DIAG_DATATYPE_NAME);
12.     CONSTRAINT_NAME:=PQresultErrorField(res,PG_DIAG_CONSTRAINT_NAME);
13.     {$ENDIF}
14.  

Why is this important piece of code essentially commented out?

[marcov]

I asked around, and some people used trunk fcl-db with FPC 3.2.2, and those tests got merged back to fixes 3.2.

I'll have a look and test if I can remove them in fixes tonight.

[marcov]

Done

[chrisv5]

Many, many thanks! Awesome service!