[SOLVED] TButton's missing caption bugfix

[lagprogramming]

Add a tbutton on a form. In linux-customdrawn the caption of the tbutton doesn't appear. To fix this bug update the following routines with the following content.

Code: Pascal  [Select][+][-]

1. class procedure TCDWSButton.InjectCDControl(const AWinControl: TWinControl; var ACDControlField: TCDControl);
2. begin
3.   TCDIntfButton(ACDControlField).LCLControl := TCustomButton(AWinControl);
4.   ACDControlField.Caption := AWinControl.Caption;
5.   ACDControlField.Parent := AWinControl;
6.   ACDControlField.Align := alClient;
7.   {$ifdef VerboseCDInjectedControlNames}ACDControlField.Name := 'CustomDrawnInternal_' + AWinControl.Name;{$endif}
8. end;
9.  

Code: Pascal  [Select][+][-]

1. class function TCDWSButton.CreateHandle(const AWinControl: TWinControl;
2.   const AParams: TCreateParams): TLCLHandle;
3. var
4.   lCDWinControl: TCDWinControl;
5. begin
6.   Result := TCDWSWinControl.CreateHandle(AWinControl, AParams);
7.   lCDWinControl := TCDWinControl(Result);
8.   lCDWinControl.CDControl := TCDIntfButton.Create(AWinControl);
9. end;
10.  

Now the caption of the button appears. It is not centered in the middle of the button, but that's a different bug.

A note:
lCDWinControl.CDControl := TCDXXX.Create(AWinControl); is the line that has to exist in createhandle according to commits like:
LCL-CustomDrawn: Starts BitBtn implementation
LCL-CustomDrawn: Adds initial TScrollBar and SpinEdit implementations

Here is a patch.

[AlexTP]

Posted to https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/40638

Applied today.