[SOLVED] Simplified function TPasRecordType.IsAdvancedRecord: Boolean;

[lagprogramming]

packages/fcl-passrc/src/pastree.pp has

Code: Pascal  [Select][+][-]

1. function TPasRecordType.IsAdvancedRecord: Boolean;
2.  
3. Var
4.   I : Integer;
5.   Member: TPasElement;
6.  
7. begin
8.   Result:=False;
9.   I:=0;
10.   While (Not Result) and (I<Members.Count) do
11.     begin
12.     Member:=TPasElement(Members[i]);
13.     if (Member.Visibility<>visPublic) then exit(true);
14.     if (Member.ClassType<>TPasVariable) then exit(true);
15.     Inc(I);
16.     end;
17. end;

The while loop contains a useless "(Not Result)" condition. The result is false at the loop entry and it's changed only using "exit(true);" statements.
The attached patch changes "While (Not Result) and (I<Members.Count) do" to "While I<Members.Count do".

[AlexTP]

Reported to https://gitlab.com/freepascal.org/fpc/source/-/issues/40539