Lazarus
Home
Help
TinyPortal
Search
Login
Register
Lazarus
»
Forum
»
Programming
»
LCL
»
TSynEdit crashes when loading text
Free Pascal
Website
Downloads
Wiki
Documentation
Bugtracker
Mailing List
Lazarus
Website
Downloads (Laz+FPC)
Packages (OPM)
FAQ
Wiki
Documentation (RTL/FCL/LCL)
Bugtracker
CCR Bugs
GIT
Mailing List
Other languages
Foundation
Website
Useful Wiki Links
Project Roadmap
Getting the Source
Screenshots
How to use the forum
About donations (wiki)
Bookstore
Computer Math and Games in Pascal
(preview)
Lazarus Handbook
Search
Advanced search
Recent
RTL: export/import WriteL...
by
marcov
[
Today
at 02:41:33 pm]
Why free pascal suppress ...
by
DragoRosso
[
Today
at 02:27:04 pm]
my programs crash
by
jamie
[
Today
at 01:22:58 pm]
Is there a way to emphasi...
by
dpap
[
Today
at 12:53:57 pm]
Custom self drawn compone...
by
cdbc
[
Today
at 12:50:10 pm]
IsNan
by
robert rozee
[
Today
at 12:07:43 pm]
MQTT made easier...
by
cdbc
[
Today
at 12:01:58 pm]
Reading and writing AVIF ...
by
Boleeman
[
Today
at 12:01:52 pm]
Reading FLIF images in La...
by
Boleeman
[
Today
at 11:58:25 am]
FLIF and FUIF Formats (Fr...
by
Boleeman
[
Today
at 11:42:17 am]
efficiency problem
by
photor
[
Today
at 11:33:05 am]
Treeview: full-width back...
by
d7_2_laz
[
Today
at 11:06:34 am]
Failed to connect to a si...
by
jcmontherock
[
Today
at 10:54:36 am]
making default event hand...
by
egsuh
[
Today
at 10:03:37 am]
TmemTable has not onCalcF...
by
egsuh
[
Today
at 08:46:27 am]
Simple mouse solution for...
by
Lauriet
[
Today
at 08:15:34 am]
Scrollbox, scrollbar Back...
by
ASerge
[
Today
at 08:14:46 am]
"extended" real type prec...
by
LV
[
Today
at 06:48:44 am]
FPC can't link screen_dem...
by
mccfrank
[
Today
at 12:06:32 am]
ThemeServices.DrawText in...
by
regs
[February 08, 2025, 11:25:01 pm]
Gradient with fcl-image
by
wp
[February 08, 2025, 10:46:18 pm]
using RunCommand to wrap ...
by
nomorelogic
[February 08, 2025, 10:39:37 pm]
ellipse ? off topic
by
BubikolRamios
[February 08, 2025, 10:15:18 pm]
Basic canvas drawing
by
Jonny
[February 08, 2025, 09:31:17 pm]
Transparent animation
by
majolika
[February 08, 2025, 08:17:52 pm]
« previous
next »
Print
Pages: [
1
]
Author
Topic: TSynEdit crashes when loading text (Read 1660 times)
domasz
Hero Member
Posts: 554
TSynEdit crashes when loading text
«
on:
June 01, 2023, 08:13:29 pm »
When I click this button twice the program crashes. Might be something with highlighters (TSynMultiSyn, TSynPHPSyn, TSynHTMLSyn).
Code: Pascal
[Select]
[+]
[-]
procedure
TForm1
.
Button1Click
(
Sender
:
TObject
)
;
var
Str
:
String
;
L
:
TStringList
;
begin
L
:
=
TStringList
.
Create
;
L
.
LoadFromFile
(
'test.htm'
)
;
Str
:
=
L
.
Text
;
L
.
Free
;
SynEdit1
.
Text
:
=
Str
;
//crashes
end
;
Code: Pascal
[Select]
[+]
[-]
object
SynMultiSyn1
:
TSynMultiSyn
Enabled
=
False
Schemes
=
<
item
StartExpr
=
'<style>'
EndExpr
=
'</style>'
Highlighter
=
SynCssSyn1
MarkerAttri
.
Background
=
clNone
MarkerAttri
.
Foreground
=
16744448
end
item
StartExpr
=
'<\?php'
EndExpr
=
'\?>'
Highlighter
=
SynPHPSyn1
MarkerAttri
.
Background
=
clNone
MarkerAttri
.
Foreground
=
16512
end>
DefaultHighlighter
=
SynHTMLSyn1
Left
=
592
Top
=
40
end
Attached is super simple demo.
Logged
Martin_fr
Administrator
Hero Member
Posts: 10792
Debugger - SynEdit - and more
Re: TSynEdit crashes when loading text
«
Reply #1 on:
June 01, 2023, 08:25:21 pm »
I can reproduce...
It seems something in the Multi-HL. Not sure yet
Logged
From the wiki:
Ide Tools, Code completion and more
/
IDE cool features
/
Debugger Status
Martin_fr
Administrator
Hero Member
Posts: 10792
Debugger - SynEdit - and more
Re: TSynEdit crashes when loading text
«
Reply #2 on:
June 01, 2023, 08:30:46 pm »
Ideally report on the bug tracker please
Logged
From the wiki:
Ide Tools, Code completion and more
/
IDE cool features
/
Debugger Status
domasz
Hero Member
Posts: 554
Re: TSynEdit crashes when loading text
«
Reply #3 on:
June 01, 2023, 08:35:39 pm »
Quote from: Martin_fr on June 01, 2023, 08:30:46 pm
Ideally report on the bug tracker please
Not sure if I did it right. Don't know how to post files there.
https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/40292
Logged
Martin_fr
Administrator
Hero Member
Posts: 10792
Debugger - SynEdit - and more
Re: TSynEdit crashes when loading text
«
Reply #4 on:
June 01, 2023, 08:40:39 pm »
ok, thanks
Logged
From the wiki:
Ide Tools, Code completion and more
/
IDE cool features
/
Debugger Status
Martin_fr
Administrator
Hero Member
Posts: 10792
Debugger - SynEdit - and more
Re: TSynEdit crashes when loading text
«
Reply #5 on:
June 02, 2023, 07:34:05 pm »
A temporary patch. I still need to do some testing.
Code: Diff
[Select]
[+]
[-]
diff --git a/components/synedit/synhighlightermulti.pas b/components/synedit/synhighlightermulti.pas
index 1343e
5d554
..ca662dc37d
100644
--- a/components/synedit/synhighlightermulti.pas
+++ b/components/synedit/synhighlightermulti.pas
@@ -
845
,
22
+
845
,
22
@@ procedure TSynHLightMultiVirtualLines.RealLinesDeleted
(
AIndex, ACount: Integer
)
;
// Real-lines starting in the middle of the Section
CountInSection := Min
(
AIndex + ACount, p^.EndPos.y +
1
)
- AIndex;
FirstVLine := p^.VirtualLine + AIndex - p^.StartPos.y;
- PrevEndVLine := p^.VirtualLine + p^.EndPos.y - p^.EndPos.y;
+ PrevEndVLine := p^.VirtualLine + p^.EndPos.y - p^.StartPos.y;
p^.EndPos.y := p^.EndPos.y - CountInSection;
inc
(
i
)
;
if i = FSectionList.Count then begin
DelVLines;
exit;
end;
p := FSectionList.PSections
[
i
]
;
VLineCount := CountInSection;
end;
while p^.EndPos.y < AIndex + ACount do begin
// Completly delete node
(
All Real lines deleted
)
VLineCount := VLineCount + p^.EndPos.y - p^.StartPos.y +
1
;
if PrevEndVLine = p^.VirtualLine then
dec
(
VLineCount
)
;
- PrevEndVLine := p^.VirtualLine + p^.EndPos.y - p^.EndPos.y;
+ PrevEndVLine := p^.VirtualLine + p^.EndPos.y - p^.StartPos.y;
FSectionList.Delete
(
i
)
;
if i = FSectionList.Count then begin
DelVLines;
Logged
From the wiki:
Ide Tools, Code completion and more
/
IDE cool features
/
Debugger Status
domasz
Hero Member
Posts: 554
Re: TSynEdit crashes when loading text
«
Reply #6 on:
June 02, 2023, 08:46:13 pm »
Seems to work great, thank you for such a quick fix!
I tried it with hundreds of files from real websites and I found no problems.
«
Last Edit: June 02, 2023, 09:55:33 pm by domasz
»
Logged
Martin_fr
Administrator
Hero Member
Posts: 10792
Debugger - SynEdit - and more
Re: TSynEdit crashes when loading text
«
Reply #7 on:
June 03, 2023, 09:37:47 pm »
Found a few other issues too. For patch, see the commit mentioned in the reported issue.
Logged
From the wiki:
Ide Tools, Code completion and more
/
IDE cool features
/
Debugger Status
Print
Pages: [
1
]
« previous
next »
Lazarus
»
Forum
»
Programming
»
LCL
»
TSynEdit crashes when loading text
TinyPortal
© 2005-2018