30sec Freeze per click in GTK3 file dialog under QT5 widgetset

[AlexTP]

Please see, Zeljko:
https://github.com/Alexey-T/CudaText/issues/4674
Can you do something here?

[zeljko]

No, sorry, I cannot follow / debug each theme for qt. It is known (from Qt bugtracker) that there are some issues with gtk2/3 themes since Qt uses gtk libs to paint controls and also gtk native dialogs. I've spotted that it might have something with our clipboard implementation (qtobjects.pas) since gtk dialog triggers enormous number of clipboard selection events when shown and maybe that could be the reason.
Open dialog does not have such problem, only saveDialog (if you provided filename). Try saveDialog without provided filename and see if it lags also and let me know.

[AlexTP]

I told the user to test save-dialog without initial filename. He confirmed: click on filenames freezes there (not in open-dialog).
What can we do?

[zeljko]

Debug our lclqt (4,5,6) clipboard selection implementation and create patch. qtobjects.pas
procedure TQtClipboard.signalSelectionChanged; cdecl;
function TQtClipboard.EventFilter(Sender: QObjectH; Event: QEventH): Boolean; cdecl;
That's what I remember that was bottleneck with gtk theme and gtk dialogs, but didn't have time to investigate and fix it.
Same routines are used in qt/qtobjects.pas , qt5/qtobjects.pas and qt6/qtobjects.pas.

[dbannon]

Might help other users if we spell out what is, and is not, a problem.

• Debian Bullseye, Bookworm, Ubuntu 22.04 (Qt5 5.15)  not a problem.
• Ubuntu 20.04 (Qt5 5.12) with Mate or KDE Desktop is a problem with some dialogs (SaveAs, Font), even if no Qt5 theme is set.

I don't have any VMs at present with a Qt5 between 5.12 and 5.15, maybe everyone except the long termers have moved on and thats a really good thing.

So, a summary, probably best to avoid Qt5 if the underlying Qt5 is less that 5:15, thats especially so if you a Qt5 theme of gtk3. But the native Qt theme looks heaps better anyway !

Davo

[AlexTP]

2 PCs with Ubuntu.
1) Ubuntu 20.04 has a problem.
2) Ubuntu 22.04 with Qt5 5.15 - no problem (even if I set GTK3 dialogs in qt5ct).

[dbannon]

Yes Alex, its U20.04 thats the problem, Debian Bullseye has a later Qt5 so, no issues.

Sadly, U20.04 still has some time to go !  I tell my users to use GTK2 version on U20.04, even if they are using Plasma/KDE !

Davo

[rca]

Try disabling QtUseNativeEventLoop in lcl/interfaces/qt5/qtdefines.inc

Code: Pascal  [Select][+][-]

1. {.$DEFINE QtUseNativeEventLoop}

Go back to Build Lazarus and recompile the applications.

[AlexTP]

@rca, what is the 'price' of such LCL change? LCL breaks in other places?

[rca]

@rca, what is the 'price' of such LCL change? LCL breaks in other places?

I have already recompiled several applications that I have, and so far everything is OK.

[rca]

In the lazarus_2_2_4 or lazarus_2_2_6 (stable) branch, in lcl/interfaces/qt5/qtdefines.inc, QtUseNativeEventLoop is only enabled for MacOSX cocoa 64.

Code: Pascal  [Select][+][-]

1.   {$IF DEFINED(LINUX) or DEFINED(FREEBSD) or DEFINED(NETBSD)}
2.     {$DEFINE HASX11}
3.   {$ENDIF}
4.  
5.   {Qt must use native event loop at least under MacOSX cocoa 64}
6.   {$IFNDEF HASX11}
7.   {$DEFINE QtUseNativeEventLoop}
8.   {$ENDIF}

I see that the change was made to the main (trunk) branch about three months ago:
"Qt5: use native event loop on all platforms."

https://gitlab.com/freepascal.org/lazarus/lazarus/-/commit/df5754c7f4ff8a16b62eaadb0053b9a74f8dc6fa

Code: Pascal  [Select][+][-]

1.   {Qt must use native event loop at least under MacOSX cocoa 64}
2.   {.$IFNDEF HASX11}
3.   {$DEFINE QtUseNativeEventLoop}
4.   {.$ENDIF}

By leaving QtUseNativeEventLoop enabled for all platforms, in my case I have linux, tested with Fedora 37, Debian 12 the problem appears when opening the dialogs both in Lazarus IDE and in the created applications.

[zeljko]

That can highly rely on current Qt theme. I don't spot any slowness with dialogs here (Fedora 35, KDE, so Breeze is default style).

[rca]

This behavior only affects save dialogs that are native to both Qt5 and Qt6:

Parsing the file lazarus/lcl/interfaces/qt5/qtwsdialogs.pp

Inside TQtWSOpenDialog.CreateHandle

Code: Pascal  [Select][+][-]

1. class function TQtWSOpenDialog.CreateHandle(const ACommonDialog: TCommonDialog): THandle;
2.  
3.     {$ifndef QT_NATIVE_DIALOGS}
4.     QFileDialog_setOption(QFileDialogH(FileDialog.Widget),
5.       QFileDialogDontUseNativeDialog, True);
6.     FileDialog.initializePreview(TPreviewFileDialog(ACommonDialog).PreviewFileControl);
7.     {$endif}

But inside TQtWSFileDialog.CreateHandle

Code: Pascal  [Select][+][-]

1. class function TQtWSFileDialog.CreateHandle(const ACommonDialog: TCommonDialog): THandle;
2.  
3.   QFileDialog_setOption(QFileDialogH(FileDialog.Widget),
4.     QFileDialogDontUseNativeDialog, False);

I changed from

Code: Pascal  [Select][+][-]

1.   QFileDialog_setOption(QFileDialogH(FileDialog.Widget),
2.     QFileDialogDontUseNativeDialog, False);

for this

Code: Pascal  [Select][+][-]

1.   {$ifndef QT_NATIVE_DIALOGS}
2.   QFileDialog_setOption(QFileDialogH(FileDialog.Widget),
3.     QFileDialogDontUseNativeDialog, True);
4.   {$endif}

Rebuild Lazarus and recompile your applications.

[AlexTP]

Please apply this patch to the Git.

[rca]

Please apply this patch to the Git.

Posted to bugtracker:
https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/40206