Bugs in Example Projects window

[Aruna]

@JuhaManninen and @dbannon I was wondering since we now have an examples window that works is it really necessary to keep testall?

My brain and logic says get rid of it so the repository stays slim and trim but my heart says that testall has some "Guys, look how clever I am.." type of code that I do not usually prescribe to but it does demonstrate techniques that can benefit a more advanced user ( even a determined and very keen beginner I would think ) so I am drawn two ways with this.

So what do I do? Keep hacking away as and when time permits me to and then send in a pull request or forget about keeping testall alive in the repository but keep it alive on my local system? Please do advise and guide.

[dbannon]

@JuhaManninen and @dbannon I was wondering since we now have an examples window that works is it really necessary to keep testall?

No, not in my opinion. But I was looking for "examples" not "test apps". From memory it uses some depreciated techniques and, probably as you say, clever code. But clever code is often hard to make cross platform and maintain.

If you have some available time, I think, personally, it would be far better spent dealing with some of the "needs work" example projects. They are ones that I thought demonstrated useful techniques but had (usually) minor issues that detracted from the overall "gloss".

Just my humble opinion.

Davo

[JuhaManninen]

@JuhaManninen and @dbannon I was wondering since we now have an examples window that works is it really necessary to keep testall?

We classified it as a test instead of an example. It can be added to lcl/tests. Just fix the clear bugs you found, no need to improve it further.
Even if you plan to improve it more later, you should publish it soon. FOSS development, remember.
Yes, there is plenty of other code to improve, in examples and elsewhere. For example Lazarus project has now 2153 open issues.
 https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/?sort=updated_desc&state=opened

[Aruna]

@JuhaManninen and @dbannon I was wondering since we now have an examples window that works is it really necessary to keep testall?

We classified it as a test instead of an example. It can be added to lcl/tests. Just fix the clear bugs you found, no need to improve it further.
Even if you plan to improve it more later, you should publish it soon. FOSS development, remember.
Yes, there is plenty of other code to improve, in examples and elsewhere. For example Lazarus project has now 2153 open issues.
 https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/?sort=updated_desc&state=opened

I will try to send you a pull request by this weekend. Since I started working again time has become a very limited commodity for my personal projects.

[Aruna]

@JuhaManninen and @dbannon I was wondering since we now have an examples window that works is it really necessary to keep testall?

No, not in my opinion. But I was looking for "examples" not "test apps". From memory it uses some depreciated techniques and, probably as you say, clever code. But clever code is often hard to make cross platform and maintain.

If you have some available time, I think, personally, it would be far better spent dealing with some of the "needs work" example projects. They are ones that I thought demonstrated useful techniques but had (usually) minor issues that detracted from the overall "gloss".

Just my humble opinion.

Davo

Juha said put it under lcl/tests so that is what I am going to do and I will start working on the "needs work" example projects soon.

[Aruna]

@JuhaManninen and @dbannon I just moved all 'testall' files to lcl/tests in branch fixes_2_2 on my local repository and pushed to my remote everything went well. Now when I try to create a merge request gitlab starts complaining please see attached screenshot. Do I start a new thread or this is related so it is ok to discuss this here?

Another issue is how do I keep 'my' forked repository in 'sync' with FPC / Lazarus / Lazarus please?

[dbannon]

I find gitlab a great deal harder to work with than github I am afraid. While you can sync the remote from the web view on github, on git lab you need to fetch from the official lazarus and push that up to your own remote gitlab repo. Its very messy IMHO.

Sorry, I don't have my notes available right now so cannot be explicate. The broad idea is that you must try and keep your remote close to the Lazarus one. These changes you made to testall should be contained all in the one directory ?  If so, I'd consider tucking them away some where safe locally and cleaning out your repo, and, maybe even your remote one !

I know its not the git way of thinking but your changes will be self contained, easily grafted back into a fresh repo when you have tidied up.

Davo

[Aruna]

I find gitlab a great deal harder to work with than github I am afraid. While you can sync the remote from the web view on github, on git lab you need to fetch from the official lazarus and push that up to your own remote gitlab repo. Its very messy IMHO.

Sorry, I don't have my notes available right now so cannot be explicate. The broad idea is that you must try and keep your remote close to the Lazarus one. These changes you made to testall should be contained all in the one directory ?  If so, I'd consider tucking them away some where safe locally and cleaning out your repo, and, maybe even your remote one !

I know its not the git way of thinking but your changes will be self contained, easily grafted back into a fresh repo when you have tidied up.

Davo

Yes, I fully agree GitLab can be a royal pain most times. So.. *nuke* my forked repo? Blow it away and start with a fresh clean fork? You are right you know... I have probably messed up my local repo. But how does one fetch/pull from lazarus main/trunk and make changes and push to 'my fork?' If you have any notes now is a good time to share them mate..   

[dbannon]

Oh, you do not have to blow it away, there will definitely be a 'git way' to get to where u need be. But that might take more reading than you want to do ....

Davo

[Aruna]

Oh, you do not have to blow it away, there will definitely be a 'git way' to get to where u need be. But that might take more reading than you want to do ....

Davo

I think it will be easier to start from scratch instead of wasting any more time trying to fix whatever it was that I must have done that has caused git to hiccup. And then hopefully try and keep everything synced daily. I do not mind reading but right now with work and other daily involvements, time has become scarce and very limited.

So I have to
- fork the Lazarus Repo, then..
- clone the fork to my local system, then..
- somehow get the local repo to fetch/pull from the original Lazarus main/trunk.

David, how did you go about doing this, please? I am stumped ( for now.. )

[JuhaManninen]

Do I start a new thread or this is related so it is ok to discuss this here?

We have the "TestAll" project issues thread. I answer there.
 https://forum.lazarus.freepascal.org/index.php?topic=61546

@dbannon, I added a modified version of the ListViewFilterEdit example project. See issue:
 https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/40035