FPCUnit returns 2 error level if tests failed

[zamtmn]

FPCUnit returns an error code when detecting failed tests. At the same time, many free CI servers (like appveyor) interrupt build process when error codes appear, we have to go to the trick and receive them. I think we need add a command line option to consoletestrunner.pas for suppress this behavior so that it is possible to return 0 regardless of failures, and results can be viewed in the report.

[PascalDragon]

If I see it correctly then the console TTestRunner only sets the ExitCode, but does not terminate the process. So you should be able to simply do ExitCode := 0 at the end of the main program file of the test.

[zamtmn]

  Yes, it is, I had to run tests through an additional wrapper bat file. to cheat a server script that I don't have access to. I think an additional command line key to configure the behavior would be a good solution.
  I also ran into a problem in the time format. FPCUnit does not have a time format setting, always HH:MM:SS.FF but most test systems (like junit) wait time in seconds SS.FF It is also desirable to add this setting to FPCUnit
  I solved these problems separately, but if you are interested, I will do it for consoletestrunner.pas

[PascalDragon]

  Yes, it is, I had to run tests through an additional wrapper bat file. to cheat a server script that I don't have access to. I think an additional command line key to configure the behavior would be a good solution.

You don't need a wrapper, you simply need to adjust your main program file:

Code: Pascal  [Select][+][-]

1. var
2.   Application: TTestRunner;
3.  
4. begin
5.   Application := TTestRunner.Create(nil);
6.   Application.Initialize;
7.   Application.Title := 'My unit tests';
8.   Application.Run;
9.   Application.Free;  
10.   ExitCode := 0;
11. end.
12.  

Whether you do this or Application.UpdateExitCode := False or whatever isn't that much of a difference...

  I also ran into a problem in the time format. FPCUnit does not have a time format setting, always HH:MM:SS.FF but most test systems (like junit) wait time in seconds SS.FF It is also desirable to add this setting to FPCUnit

And using the JUnit format is no solution for you? (using --format=junit)

[zamtmn]

>>You don't need a wrapper, you simply need to adjust your main program file:
I know that. I want to run the same source code in different situations in different ways. If you think it's superfluous, I don't insist

>>And using the JUnit format is no solution for you? (using --format=junit)
This was added recently, I haven't seen it yet. Great, thanks!

[PascalDragon]

>>You don't need a wrapper, you simply need to adjust your main program file:
I know that. I want to run the same source code in different situations in different ways. If you think it's superfluous, I don't insist

Well, you can file a bug report if you want. It's mainly MvC who maintains FPCUnit...

>>And using the JUnit format is no solution for you? (using --format=junit)
This was added recently, I haven't seen it yet. Great, thanks!

Ah, hadn't seen that it was only added recently...

[zamtmn]

>>Well, you can file a bug report if you want. It's mainly MvC who maintains FPCUnit...
You sound like you're suggesting I play the lottery. I don't understand such a policy

[PascalDragon]

I'm saying that I'm not the one maintaining FPCUnit. So if you want to have something changed there then ask someone who does and MvC is the one. However as he doesn't frequent this forum the place to ask is the bug tracker which is the place anyway to do feature requests.

[zamtmn]

OK, thanks!

[n7800]

Just for reference: the patch was proposed in #39587 by the author, edited and applied by Michael, and slightly fixed by me. We're a great team ))