Can't create text file using assign() [Solved]

[BrokenMemory]

Greetings,I was handling my Computer Science project and this problem had me stopped for like half an hour,I wanted to create a text file for each time I click the button, however using assign() function didn't seem to work,here's the code.

procedure TForm1.Button1Click(Sender: TObject);
var f : text;
    fn : string;
begin
  memo1.Clear;
  fn := 'C:\SBA(ICT) 7_2\Fault Reports\Pending\' + datetimetostr(now) + '.txt';
  if Rm <> ''
  then if Eq <> ''
       then if Er <> ''
            then begin
                   Assignfile(f,fn);
                   rewrite(f);
                   showmessage('Creation successful');
                   writeln(f,Rm);
                   writeln(f,Eq);
                 end
            else showmessage('You have not select the fault yet!')
       else showmessage('You have not select the equipment yet!')
  else showmessage('You have not select the room yet!')
end;

P.S. I'm new to this forum,so if I violated some rules,be sure to let me know and it won't happen next time.

[marcov]

Note that all directories must exist for this to work. Assignfile won't create directories.

[eny]

Assuming this is in windows, datetimetostr() might insert illegal characters (slashes, colons).

[BrokenMemory]

Note that all directories must exist for this to work. Assignfile won't create directories.

Got it, is there any way to do so then, have been searching for quite a while now.

[BrokenMemory]

Assuming this is in windows, datetimetostr() might insert illegal characters (slashes, colons).

I have checked the variable fn, it doesn't seem to have any illegal characters.

[marcov]

Get the directory part in a string (e.g. "path") and then do a

Code: Pascal  [Select][+][-]

1. ForceDirectories(Path);

Eny is right though to look into that , your program might fail on a different machine this way.

[BrokenMemory]

Get the directory part in a string (e.g. "path") and then do a

Code: Pascal  [Select][+][-]

1. ForceDirectories(Path);

I have added the forcedirectories() into the program, however, there is still a run time error during rewrite(f), and the file is still not created, here's the code. Apologies if I misunderstood anything.

Code: Pascal  [Select][+][-]

1. procedure TForm1.Button1Click(Sender: TObject);
2. var f : text;
3.     fn : string;
4. begin
5.   memo1.Clear;
6.   fn := 'C:\SBA(ICT) 7_2\Fault Reports\Pending\' + datetimetostr(now) + '.txt';
7.   if Rm <> ''
8.   then if Eq <> ''
9.        then if Er <> ''
10.             then begin
11.                    Forcedirectories(fn);
12.                    Assignfile(f,fn);
13.                    rewrite(f);
14.                    showmessage('Creation successful');
15.                    writeln(f,Rm);
16.                    writeln(f,Eq);
17.                  end
18.             else showmessage('You have not select the fault yet!')
19.        else showmessage('You have not select the equipment yet!')
20.   else showmessage('You have not select the room yet!')
21. end;
22.  

[winni]

Hi!

As said above: DateTimeToStr contains slashes and colons.
Both are forbidden in a filename.
Use hyphens or underscores instead.

Replace the DateTimeToStr with

Code: Pascal  [Select][+][-]

1. FormatDateTime('yyyy-mm-dd hh-nn-ss',now)

Winni

[BrokenMemory]

Hi!

As said above: DateTimeToStr contains slashes and colons.
Both are forbidden in a filename.
Use hyphens or underscores instead.

Replace the DateTimeToStr with

Code: Pascal  [Select][+][-]

1. FormatDateTime('yyyy-mm-dd hh-nn-ss',now)

Winni

This method works,thank you very much.

[dpremus]

Your code is very hard to read, here is the same code written in another way and it's more readable.

Code: Pascal  [Select][+][-]

1. procedure TForm1.Button1Click(Sender: TObject);
2. var
3.    f  : text;
4.    fn : string;
5. begin  
6.   if Rm = '' then begin
7.     showmessage('You have not select the room yet!');
8.     exit
9.   end;
10.  
11.   if Eq = '' then begin
12.     showmessage('You have not select the equipment yet!');
13.     exit
14.   end;
15.  
16.   if Er = '' then begin
17.     showmessage('You have not select the fault yet!');
18.     exit
19.   end;  
20.  
21.   memo1.Clear;
22.   fn := 'C:\SBA(ICT) 7_2\Fault Reports\Pending\' + FormatDateTime('yyyy-mm-dd hh-nn-ss', now) + '.txt';
23.   Assignfile(f,fn);
24.   rewrite(f);
25.   showmessage('Creation successful');
26.   writeln(f,Rm);
27.   writeln(f,Eq);
28.   closefile(f);   // <- missing in original code
29. end;