Access Denied

[user5]

    Is the code below an acceptable way to use a try statement with OpenDialog?
    I'm trying to provide protection against an Access Denied error. Thanks.

   

Code: Pascal  [Select][+][-]

1. try
2.  try
3.   begin
4.    if opendialog1.Execute = true then
5.     begin
6.      filename := opendialog1.FileName;
7.     end
8.   end;
9.   except
10.   On E: Exception do
11.    begin
12.     sound(350);
13.     newerror := true;
14.    end;
15.  end;
16. finally;
17. end;

[Thaddy]

empty finally sections are never acceptable. (Same goes for empty except statements)
I also miss a specialized exception EAccessDenied and a re-raise if it is something else......
Bad programming, sorry.

[user5]

    Thank you for your response. Could you give me a brief example of something that is better?

[ASerge]

    Thank you for your response. Could you give me a brief example of something that is better?

In Windows, "OpenDialog" handles access denied errors before closing, so the code:

Code: Pascal  [Select][+][-]

1. OpenDialog1.Execute;

Until you tell us more, it's better than your code.

[Thaddy]

Indeed It would help a great deal.