[Solved] Out of Memory

[marcov]

Change to 64-bit.

[bobonwhidbey]

If I change to 64 bit, will the app run on 32-bit PCs. Most of my users only have them.

[marcov]

If I change to 64 bit, will the app run on 32-bit PCs. Most of my users only have them.

True. Maybe you can differentiate between those who have large datasets and not.

The trouble is copying of a tstringlist takes twice the memory. Around 1GB you are thus hitting the 2GB limit of 32-bit.

You can go a bit further with {$peflags IMAGE_FILE_LARGE_ADDRESS_AWARE}, but you are skirting the edge, and the next increase might bump you over again.

[lucamar]

[...]

However, I RUN OUT OF MEMORY when I tried to execute SL.SaveToFile after the main loop.

I need another approach to create the output file. Any suggestions?

Just a thought: you could try writing directly to the file instead of using a TStringList as a kind of stepping-stone. That will surely use quite a lot less memory.

It all depends on what you're really trying to do.

[bobonwhidbey]

I've solved my problem by using TFileStream. I've replaced every SL.Add() with AddtoStream() . Then

Code: Pascal  [Select][+][-]

1. procedure AddToStream(s : string):
2. begin
3.   s := s+#13#10; // carriage return/line feed
4.   fs.Write(s[1], length(s));
5. end;

Of course fs is created and freed in the appropriate spot.

[lucamar]

Unless you need a specific line termination you should use LineEnding:

Code: Pascal  [Select][+][-]

1. procedure AddToStream(s : string):
2. begin
3.   s := s + LineEnding; // platform dependant line termination
4.   fs.Write(s[1], length(s));
5. end;

[bobonwhidbey]

Thanks

[Thaddy]

If you write strings to a stream why not use TStream.WriteAnsiString;

[bobonwhidbey]

When I tried to use

Code: Pascal  [Select][+][-]

1. s := s + LineEnding;
2. fs.WriteAnsiString(s);

 
3 bytes of non-text info (or something like that) was put in front of every line in my output file.

How would I use WriteAnsiString to achieve an output line that looks like

Code: Pascal  [Select][+][-]

1. fs.Write(s[1],length(s));

[Thaddy]

TStream.WriteAnsiString already adds a line ending......
So:

Code: Pascal  [Select][+][-]

1. fs.WriteAnsiString(s);

is enough...

You are doubling it up...

[wp]

If you write strings to a stream why not use TStream.WriteAnsiString;

Be careful. This writes the string length in front of the character array. Maybe this is not wanted. The code posted above definitely writes only the characters.

[bobonwhidbey]

Without Lineending, the file is not easily readable or editable in something like Notebook. Weird characters still appear. I haven't been able to get WriteAnsiString to provide output like Write(s[1],length(s)), after adding LineEnding to "s".

[Zoran]

Without Lineending, the file is not easily readable or editable in something like Notebook. Weird characters still appear. I haven't been able to get WriteAnsiString to provide output like Write(s[1],length(s)), after adding LineEnding to "s".

You didn't notice what Werner said. So, stick to what you originally wrote, there is nothing wrong in your code. Here is what I would do:

Code: Pascal  [Select][+][-]

1. procedure AddToStream(S: String):
2. const
3. { Yes, you can use platform dependent LineEnding constant, as Lucamar suggested;
4.  but I guess you probably want your files to be consistent on all platforms, so: }
5.   CRLF = #13#10;
6.   L = Length(CRLF);
7. begin
8.   if S > '' then
9.     fs.Write(S[1], Length(S));
10.   fs.Write(CRLF[1], L);
11. end;
12.