Send email with attachments

[Przemyslav]

Hello everybody I have big problem with sending email with attachment. My example program you can see in attachment.

When i close my program with Button, program saves all texts from ComboBoxes, Edits, Memos to file called report.txt. File report.txt in his name contains date and time when file was generated for example: 22.08.2018_15.02.20_report.txt. I can generate multiple report files in one hour. I have problem with add last generate file to email.

My code for button:

Code: Pascal  [Select][+][-]

1. procedure TForm1.BitBtn1Click(Sender: TObject);
2. const
3.   OutputFileName = 'report.txt';
4. var
5.   OutputFile: TStringList;
6.   time: TFormatSettings;
7.   Mail: TSendMail;
8. begin
9.   GetLocaleFormatSettings(1045, czas);
10.   time.TimeSeparator := '.';
11.  
12.   if (Application.MessageBox('Allert!', 'Raport', MB_ICONQUESTION + MB_YESNO) <> IDYES) then Exit;
13.  
14.   OutputFile := TStringList.Create;
15.  
16.   OutputFile.Add('');
17.   OutputFile.Add('-----------------------------------------------------------------------------------------------------------------');
18.   OutputFile.Add('');
19.   OutputFile.Add('Dyżur pełnili:');
20.   (......)
21.   OutputFile.SaveToFile('reports\\' + DateToStr(Now, time) + '_' + TimeToStr(Now, time) + '_' + OutputFileName);
22.  
23.   Mail := TSendMail.Create;
24.  
25.   try
26.       Mail.Sender := '*************' <'*************'>;
27.       Mail.Receivers.Add('*************');
28.       Mail.Subject := 'Hello';
29.       Mail.Message.Add('How are you');
30.       Mail.Attachments.Add('reports\\report.txt');  // for send files, optional
31.       Mail.Smtp.UserName := '*************';
32.       Mail.Smtp.Password := '*************';
33.       Mail.Smtp.Host := 'smtp.gmail.com';
34.       Mail.Smtp.Port := '587';
35.       //Mail.Smtp.SSL := True;
36.       mail.Smtp.FullSSL:=false;
37.       Mail.Smtp.TLS := True;
38.       Mail.Send;
39.       ShowMessage('SUCCESS :) ');
40.     finally
41.       Mail.Free;
42.     end;
43.  
44. end;

   

I created file in this line:

Code: Pascal  [Select][+][-]

1. OutputFile.SaveToFile('reports\\' + DateToStr(Now, time) + '_' + TimeToStr(Now, time) + '_' + OutputFileName);

       

And i have problem to select the last generated file from line above iin this section:

Code: Pascal  [Select][+][-]

1.  Mail.Attachments.Add('reports\\report.txt');  // for send files, optional    

[fred]

Put the filename in a var and use it for both cases:

Code: Pascal  [Select][+][-]

1. filename := 'reports\\' + DateToStr(Now, time) + '_' + TimeToStr(Now, time) + '_' + OutputFileName;
2.  
3. OutputFile.SaveToFile(filename);
4.  
5. Mail.Attachments.Add(filename);  // for send files, optional

[tudi_x]

hi,
i would also separate the view / GUI layer and the send email functionality.
in model - view - controller this separation is the norm.
has advantages.

[Przemyslav]

I put this code in var:

Code: Pascal  [Select][+][-]

1. const
2.   OutputFileName = 'report.txt';
3. var
4.   OutputFile: TStringList;
5.   time: TFormatSettings;
6.   Mail: TSendMail;
7.   filename: string;
8.  
9. begin
10.   ....
11.   filename := 'reports\\' + DateToStr(Now, time) + '_' + TimeToStr(Now, time) + '_' + OutputFileName;
12.   OutputFile.SaveToFile(filename);
13.  
14.   Mail := TSendMail.Create;
15.  
16.   try
17.      ....
18. Mail.Attachments.Add(filename);  // for send files, optional
19.     finally
20.       Mail.Free;
21.     end;
22.  
23. end;  
24.  
25.  
26.  
27.  

But i have errors:

Code: Pascal  [Select][+][-]

1. unit1.pas(372,48) Error: Incompatible type for arg no. 2: Got "TDateTime", expected "TFormatSettings"
2. unit1.pas(372,77) Error: Incompatible type for arg no. 2: Got "TDateTime", expected "TFormatSettings"

[MichaelBM]

DateToStr(Now, time)

"time" is not valid.

See https://www.freepascal.org/docs-html/rtl/sysutils/datetostr.html

[Przemyslav]

OK thank you it's working now Thank you very much