(SOLVED) Merge cells example bug?!

[xinyiman]

Hi guys, I wanted to report a non-working example released with lazarus. This is the example to merge cells in TStringGrid. I have also attached the example, but if you compile and run mac (carbon) and double-click on a blank cell, it generates an exception in the DoEditorShow procedure. Does anyone know how to solve?

[wp]

I am the author of this example, but don't have access to Mac/carbon, and thus cannot reproduce on Win.

Double-click behavior of the standard grid was not modified in this example. Does the bug also occur with a standard string grid? There is a comment in TCustomGrid.DoEditorShow regarding carbon, but it has been there since at least version 1.6.4.

What exactly is the error message? Can you provide a stack trace?

[xinyiman]

See if the images are clear enough.

[xinyiman]

Other

[wp]

Probably there is no editor. Modify TmcGrid.DoEditorShow like this and try again:

Code: Pascal  [Select][+][-]

1. procedure TMCStringGrid.DoEditorShow;
2. var
3.   R: TRect;
4. begin
5.   inherited;
6.   if goColSpanning in Options then begin
7.     CalcCellExtent(Col, Row, R);
8.     if Assigned(Editor) then   // <--- NEW
9.       Editor.SetBounds(R.Left, R.Top, R.Right-R.Left-1, R.Bottom-R.Top-1);
10.   end;
11. end;

[xinyiman]

He did not solve. But I do not understand a thing, if you look at the image 3 you will see that the right and the bottom of R are really great. Does not it seem strange?

[wp]

Ah, uninitialized variable! Try this

Code: Pascal  [Select][+][-]

1. procedure TMCStringGrid.DoEditorShow;
2. var
3.   R: TRect;
4. begin
5.   inherited;
6.   if (goColSpanning in Options) and Assigned(Editor) then begin
7.     R := CellRect(Col, Row);
8.     CalcCellExtent(Col, Row, R);
9.     Editor.SetBounds(R.Left, R.Top, R.Right-R.Left-1, R.Bottom-R.Top-1);
10.   end;
11. end;
12.  

[xinyiman]

Perfect. Thank you

[wp]

Applied to trunk. Thanks for reporting.