ct4laz

[wp]

avra, I ask for removal of px_mapviewer because we have LazMapViewer, in OPM already. I compared them, px_mapViewer is the same as our LazMapViewer. After the original authors have left the community I am maintaining this package, and PilotLogic just copies our version to their repository and does the usual renamings which lead so strange confusion: looking at mvmapviewer.pas I see that I am a user of the "Typhon forum https://forum.lazarus.freepascal.org".

[avra]

avra, I ask for removal of px_mapviewer because we have LazMapViewer, in OPM already. I compared them, px_mapViewer is the same as our LazMapViewer. After the original authors have left the community I am maintaining this package, and PilotLogic just copies our version to their repository and does the usual renamings which lead so strange confusion: looking at mvmapviewer.pas I see that I am a user of the "Typhon forum https://forum.lazarus.freepascal.org".

Only pl_* packages will end up in OPM. Since px_mapviewer has px_* prefix, it will not end up in OPM for sure. It was meant to end up only in ct4laz. I am not sure if you are aware of this and you ask to remove px_mapviewer from OPM only, or also remove from ct4laz? Neither is the problem - I just want to clarify your request.

p.s. I also do not like CT's massive automatic renaming and fully understand if you wish to remove package from both.

[wp]

The Excel file says "TMapViewer enhanced: OPM version doesn't work with trunk any more (CT version does) https://sourceforge.net/p/roadbook/code/ci/master/tree/mapviewer/, 2019: trunk does not work any more (deprecated after LazMapViewer was added to OPM)"

Is this still up-to-date? Which "trunk": Laz-trunk or FPC-trunk? And what is "deprecated"?

Maybe this is a left-over from the time before LazMapViewer was available in OPM. I remember that it took rather long until I finally released the package to OPM because there was a memory leak, and I waited until this was luckily fixed by a forum user.

I just installed LazMapViewer on FPC-trunk/Laz-trunk, no problem, the sample project is running fine. Therefore there is no benefit in duplicating LazMapViewer in ctlaz any more.

[avra]

The Excel file says "TMapViewer enhanced: OPM version doesn't work with trunk any more (CT version does) https://sourceforge.net/p/roadbook/code/ci/master/tree/mapviewer/, 2019: trunk does not work any more (deprecated after LazMapViewer was added to OPM)"

Is this still up-to-date? Which "trunk": Laz-trunk or FPC-trunk? And what is "deprecated"?

Maybe this is a left-over from the time before LazMapViewer was available in OPM.

Yes. There were issues in 2019 with pl_mapviewer and trunk. Once you published LazMapViewer, pl_mapviewer became deprecated and I renamed it to px_mapviewer and removed it from OPM (but left it in ct4laz).

Therefore there is no benefit in duplicating LazMapViewer in ctlaz any more.

Ok, then I will remove it also from ct4laz.

EDIT: Removed.

[balazsszekely]

@avra

The resource files are missing. Take a look at the attached picture.
It has nothing to do with OPM, if I extract the zip downloaded from your repo and open/compile the package, same things happen.
I tested with the first 5-6 package and 3 failed. Can you please include the resource files too?

[avra]

I will take a look.

[avra]

I have just tested with 32bit Lazarus 2.0.11 and FPC 3.2.1 on Win10x64. First I uninstalled all my pl_packages and recompiled IDE. Then downloaded just pl_excontrols.zip from ct4laz repo, extracted it, opened package, compiled and installed. IDE was rebuilt without any problems.

If I open downloaded pl_excontrols.zip I can find all *.res files where they should be.

Could you please check if \pl_components\pl_excontrols\source\TplSmartGridCursors.res file exists and could be accessed?

[balazsszekely]

Yes, if I download pl_excontrols.zip separately, the resource file is there. If I try to download the whole repository, the resource files are not included(see attachment).

[avra]

Yes, if I download pl_excontrols.zip separately, the resource file is there. If I try to download the whole repository, the resource files are not included(see attachment).

Aaah, I see now. It must have been my .gitignore settings being too restrictive. Until I fix that, please use zip files.

[avra]

This file needs an update:
https://github.com/github/gitignore/blob/master/Global/Lazarus.gitignore

I've been using it as a template. For some reason it is set to ignore *.res and *.lrs.

[balazsszekely]

@avra

It must have been my .gitignore settings being too restrictive.

It also remove some library files from pl_0_lib.

Anyways I updated the packages. Everything works out of the box. The only package that failed to install on my system(Lazarus Trunk/FPC 3.2.0) is pl_Win_Media, with the following message:
"Media.AMVideo.pas(287,53) Error: Identifier not found "SIZE_PREHEADER""

[avra]

It must have been my .gitignore settings being too restrictive.

It also remove some library files from pl_0_lib.

Yes, I've seen that and prepared new gitignore but have not been able to test it yet.

Anyways I updated the packages. Everything works out of the box. The only package that failed to install on my system(Lazarus Trunk/FPC 3.2.0) is pl_Win_Media, with the following message:
"Media.AMVideo.pas(287,53) Error: Identifier not found "SIZE_PREHEADER""

It works on Lazarus 2.0.11. Strange is that pl_Win_Media is unchanged CT package, and CT uses trunks so it should work. At the moment I do not see why it fails since everything in line 287 resides in that same unit so it should compile. I have found in DirectShow9.pas this:

Code: Pascal  [Select][+][-]

1. SIZE_PREHEADER = 48; // offset TVideoInfoHeader.bmiHeader

Could you please test if compilation and demos work if you replace line 287 with this? If it does then I could ifdef it for Laz trunk and fix it that way.

[balazsszekely]

It works on Lazarus 2.0.11. Strange is that pl_Win_Media is unchanged CT package, and CT uses trunks so it should work. At the moment I do not see why it fails since everything in line 287 resides in that same unit so it should compile. I have found in DirectShow9.pas this:

Code: Pascal  [Select][+][-]

1. SIZE_PREHEADER = 48; // offset TVideoInfoHeader.bmiHeader

Could you please test if compilation and demos work if you replace line 287 with this? If it does then I could ifdef it for Laz trunk and fix it that way.

Issue fixed! I updated the package in OPM. Thanks.

[avra]

Issue fixed! I updated the package in OPM. Thanks.

Nice. Thank you! 

[avra]

Strange. I wanted to make a proper ifdef so I have just checked both FPC 3.2.1 + LazTrunk and FPC 3.2.0 + LazTrunk and there was no SIZE_PREHEADER problem during compilation. LazTrunk is from today (SVN64137).

Tested on Win10x64 with 32bit Lazarus, using latest fpcupdeluxe.