[SOLVED] TFPTimer.Stop

[aradeonas]

Hi,
For first time I want to test TFPTimer but when I want to disable timer, application will be freeze.
Can any one test this code and tell me why?

Code: [Select]

  var
  Timer:TFPTimer; 

procedure TForm1.Button4Click(Sender: TObject);
begin
 timer:=TFPTimer.Create(self);
 timer.OnTimer:=@TimerTick;
 Timer.Interval:=100;
 timer.StartTimer;
end;

procedure TForm1.TimerTick(Sender: TObject);
begin
self.Caption:='Finished';
Timer.StopTimer;
end; 


[engkin]

Calling StopTimer inside the thread of the timer (read: its OnTimer) is like asking the thread to wait for itself to finish (which will never happen)

1-Never call StopTime inside OnTimer.
2-Call Terminate instead.

[aradeonas]

Thank you,
1- How can I AutoDisable timer after 1 tick?
2- How can I terminate a TFPTimer?(I have not access to its driver terminate)

[Leledumbo]

1- How can I AutoDisable timer after 1 tick?

Set Enabled to false in the OnTimer.

2- How can I terminate a TFPTimer?(I have not access to its driver terminate)

Set Enabled to false anytime you want to terminate it.

[aradeonas]

@Leledumbo please read my question and engkin answer.
With TFPTimer application will be freeze if I change enabled in OnTimer.

[Blaazen]

IMO you will have to create your own driver or maybe your own unit.

I copy - pasted fpTimer to a new unit MyfpTimer with following modifications:

Code: [Select]

TFPTimerThread = class(TThread)
  private
    FTimerDriver: TFPTimerDriver;
    Function Timer : TFPCustomTimer;
  public
    counter: Integer;  //<-- new field
    procedure Execute; override;
    constructor CreateTimerThread(ATimerDriver: TFPTimerDriver);
  end; and

Code: [Select]

procedure TFPTimerThread.Execute;
...
    If Assigned(T) and not terminated then
        begin  //this
        Synchronize(@T.Timer);
        inc(counter);  //this
        if counter=2 then begin  //<--  here are hardcoded 2 but you can define public property Count
          T.FEnabled:=False; //this
          Terminate;  //this
          end;  //this
        end;  //this
With this modification (added 8 lines) it triggers two timer events, no mem. leaks, no freezing.

[aradeonas]

Thank you Blaazen.