New version of BGRABitmap

[Phoenix]

Thanks for the current version and also for the previous releases  !

[circular]

You're very welcome 

[funlw65]

New OS installed, Linux Debian 11 based. Lazarus 2.2.2., fpc 3.2.3 fixes.
I try to install BGRA from OPM, I get an error in the .inc auto generated files:

generatedcolorspace.inc:

Code: Pascal  [Select][+][-]

1. class function TColorColorspace.GetChannel(AColor: Pointer; AIndex: integer): single;
2. begin
3.   case AIndex of
4.   0: result := TColor(AColor^).red;

Error is:
generatedcolorspace.inc(2684,32) Error: Illegal qualifier
pointing to red (green and blue).

[circular]

Seems that in dev version of FPC type helpers don’t work with scalar. Not sure if this is a bug or a feature.

[ginky]

Hi

I found a bug but not sure.

Loading BMP image file with compresson method OS22XBITMAPHEADER: Huffman 1D (Offset 1E, Value 3) results in colors artifacts on drawed image.
With HEX editor I've changed Value to 0 (Compression method - none). After that the image drawed perfect.

Lools like BGRABitmap does not have support for older compression methods.

edit1. How I can fix that?

Thanks

[circular]

Hi,

I am a bit confused. Are you saying that changing the number indicating the compression method shows the image perfectly? That would mean that in fact the bitmap is not compressed.

Can you provide the image as attachment?

It is possible to change the reader to handle new formats.

Regards

[ginky]

Hi,

I am a bit confused. Are you saying that changing the number indicating the compression method shows the image perfectly? That would mean that in fact the bitmap is not compressed.

Can you provide the image as attachment?

It is possible to change the reader to handle new formats.

Regards

I don't know bmp format well enough but image viewers open my file without errors (before and after editing).

File too big so compressed (it's texture).

https://drive.google.com/file/d/1EvXnqMiJkYZ79Qw3BQaKcD6f-HdYA1pn/view?usp=sharing

[circular]

Ok so this is not a compressed image. Method 3 indicated at position 30 is BI_BITFIELDS which specifies where to get the red/green/blue components in each pixel data. But those bit fields (at position 138) are not set properly, they indicate RGB order whereas this file, as it is generally the case for BMP, is in BGR order. So when you load it you get those colors swapped.

In LazPaint, you can see that by swapping red and blue colors using "filter function". Or by code using SwapRedBlue function.

You can indeed fix the file either by setting 0 as compression method, or by changing the bit fields to 0000FF00 00FF0000 FF000000 instead of FF000000 00FF0000 0000FF00.

[ginky]

Hi,

Thanks for explanation.

I have no way to fix the file in production so is there any way to fix this by BGRABitmap?

[circular]

Yes, as I mentioned, you can call bmp.SwapRedBlue after loading the file where bmp is your TBGRABitmap object.

[ginky]

Yes, as I mentioned, you can call bmp.SwapRedBlue after loading the file where bmp is your TBGRABitmap object.

Hmm....but how I can detect wrong RGB order?

edit.1 Solved a problem. Before displaying the file, first I read it in memory and change the compression flag.

[circular]

Ok yeah that's one way to solve the problem as it seems anyway the data is always in the BGR order.

[Josh]

Hi

Just tried to update my fpc and laz fixes to latest using fpcupdeluxe
andam getting

Code: Pascal  [Select][+][-]

1. M:\LazarusFixes32\config_lazarus\onlinepackagemanager\packages\bgrabitmap-master\bgrabitmap\generatedcolorspace.inc(2684,32) Error: (3205) Illegal qualifier
2. (3104) Compiling fpdbghardcodedfreepascalinfo.pas
3. (3104) Compiling syncompletion.pas
4. (3104) Compiling synedit.pp
5. (3104) Compiling lazsynimmbase.pas
6. (3104) Compiling lazsynimm.pas
7. (3104) Compiling syntextdrawer.pp
8. M:\LazarusFixes32\config_lazarus\onlinepackagemanager\packages\bgrabitmap-master\bgrabitmap\generatedcolorspace.inc(2685,32) Error: (3205) Illegal qualifier
9. M:\LazarusFixes32\config_lazarus\onlinepackagemanager\packages\bgrabitmap-master\bgrabitmap\generatedcolorspace.inc(2686,32) Error: (3205) Illegal qualifier
10. M:\LazarusFixes32\config_lazarus\onlinepackagemanager\packages\bgrabitmap-master\bgrabitmap\generatedcolorspace.inc(2694,22) Error: (3205) Illegal qualifier
11. M:\LazarusFixes32\config_lazarus\onlinepackagemanager\packages\bgrabitmap-master\bgrabitmap\generatedcolorspace.inc(2695,22) Error: (3205) Illegal qualifier
12. M:\LazarusFixes32\config_lazarus\onlinepackagemanager\packages\bgrabitmap-master\bgrabitmap\generatedcolorspace.inc(2696,22) Error: (3205) Illegal qualifier

Any fix for this

[circular]

Hello Josh,

This is a bug with development version of FPC:
https://gitlab.com/freepascal.org/fpc/source/-/issues/38678

You can avoid this problem by replacing the functions TColorColorspace.GetChannel and TColorColorspace.SetChannel by the following:

Code: Pascal  [Select][+][-]

1. class function TColorColorspace.GetChannel(AColor: Pointer; AIndex: integer): single;
2. begin
3.   case AIndex of
4.   0: result := {$IFDEF TCOLOR_BLUE_IN_LOW_BYTE}(TColor(AColor^) shr 16) and $ff{$ELSE}TColor(AColor^) and $ff{$ENDIF};
5.   1: result := (TColor(AColor^) shr 8) and $ff;
6.   2: result := {$IFDEF TCOLOR_BLUE_IN_LOW_BYTE}TColor(AColor^) and $ff{$ELSE}(TColor(AColor^) shr 16) and $ff{$ENDIF};
7.   else raise ERangeError.Create('Index out of bounds');
8.   end;
9. end;
10.  
11. class procedure TColorColorspace.SetChannel(AColor: Pointer; AIndex: integer; AValue: single);
12. var channelValue: byte;
13. begin
14.   channelValue := Round(Clamp(AValue,0,255));
15.   case AIndex of
16.   0: TColor(AColor^) := {$IFDEF TCOLOR_BLUE_IN_LOW_BYTE}(LongWord(AColor^) and $00ffff) or (channelValue shl 16){$ELSE}(LongWord(AColor^) and $ffff00) or channelValue{$ENDIF};
17.   1: TColor(AColor^) := (LongWord(AColor^) and $ff00ff) or (channelValue shl 8);
18.   2: TColor(AColor^) := {$IFDEF TCOLOR_BLUE_IN_LOW_BYTE}(LongWord(AColor^) and $ffff00) or channelValue{$ELSE}(LongWord(AColor^) and $00ffff) or (channelValue shl 16){$ENDIF};
19.   else raise ERangeError.Create('Index out of bounds');
20.   end;
21. end;

I have patched temporarily the file on the dev branch:
https://github.com/bgrabitmap/bgrabitmap/commit/fe96b8371178cf9cd8c980ced92f3d2f4051e457

[circular]

New version of BGRABitmap (11.5.3) :
https://github.com/bgrabitmap/bgrabitmap/releases

It is an update to handle latest version of LibAvif. Thanks to DomingoGP for the pull request