TDBGrid Enhansement (Add all columns from the dataset)

[BigChimp]

quick note:
1. svn client
fpcup has already downloaded an svn client for you
It should be in a subdirectory of c:\development\fpcbootstrap\; it's called svn.exe

If you want a graphical SVN client which is very nice, you can download and install TortoiseSVN.

2. changes
Yes, you go ahead and change everything the way you want it, recompile Lazarus, check everything looks ok.
Then you can go to c:\development\lazarus and run svn diff to list the differences/show the patch; do svn diff > thepatch.diff to save the patch etc.

[zgabrovski]

OK, I an ready with the patch file.
But I check, it contains only changes into DBPropedits.pas. The new .pas and .lfm file for property editor form is not included in the patch.diff file.
Must I attach those two other files in the bug tracker? 

[BigChimp]

OK, I an ready with the patch file.

Great work!

But I check, it contains only changes into DBPropedits.pas. The new .pas and .lfm file for property editor form is not included in the patch.diff file.

Yes, that's normal with patch files.

Must I attach those two other files in the bug tracker?

Yes, please attach them along with the patch (or zip them up first if they're a bit bigger).

[zgabrovski]

I hope that I upload the patch successfully. Can you please check?

http://bugs.freepascal.org/view.php?id=25219

[BigChimp]

Great, thanks.

Some remarks:
- it's often useful to indicate in which directory the new files should go (i.e. $(lazarusdir)\components\ideintf)
- Typo: you spelled the filenames DBGrigColumns... instead of DBGfid. Also, the rest of the files there use lowercase, so probably best to use the same convention
- your indentation in the patch (TDBGridColumnsPropertyEditor = class (TCollectionPropertyEditor)) does not match the rest of the code
- typo in function name, some vertical linespace.
Minor stuff really.... but the kind of stuff I can check easily
No idea about the actual content though, so no comments there

I took the liberty of creating a new patch and renaming the files. If ok, could you upload them to the issue tracker?

Thanks a lot

[zgabrovski]

It is OK, n.p. I upload new file, but how to remove old one?

[BigChimp]

You can't remove the old one if you have bug reporter privileges. I'll remove the old one for you...

I also assigned it to somebody who I think is the right guy for Laz DB controls patches.

Thanks a lot for your hard work!

[zgabrovski]

It was a pleasure for me.
If I find other thinks, that I can improve, I will do.

[BigChimp]

Please do keep an eye on the bugtracker issue though, you might get some feedback there...