Executing external program

[Jurassic Pork]

more generic for this, a function :

Code: [Select]

function execCmd(cmd: string; wait : boolean) : integer;
// J.P 2013
var AProcess : TProcess;
var exitcode : integer;
begin
result := -1;
AProcess := TProcess.Create(nil);
try
{$IFDEF WIN32}
AProcess.Executable := 'cmd.exe' ;
AProcess.Parameters.DelimitedText :=  '/c "' + cmd + '"';
{$ENDIF}
{$IFDEF LINUX}
AProcess.Executable := 'bash' ;
AProcess.Parameters.DelimitedText :=  '-c "' + cmd + '"';
{$ENDIF}
if wait then AProcess.Options := AProcess.Options + [poWaitOnExit]; //  wait for the end of the process
AProcess.ShowWindow := swoHide;
AProcess.Execute;
Except
on E: Exception do
      ShowMessage('Error with cmd  : ' + E.message);  //Show Exception
end;
result := AProcess.ExitStatus;
Aprocess.Free;
end;
example to call the function :

Code: [Select]

var exitcode : integer;
begin
{$IFDEF WIN32}
execCmd('notepad.exe',false);
exitcode :=  execCmd('sort<f:\testsort.txt >f:\resultu.txt',true);
{$ENDIF}
{$IFDEF LINUX}
exitcode :=  execCmd('sort</home/user/testsort.txt >/home/user/result.txt',true);
{$ENDIF}
if (exitcode <> 0 ) then ShowMessage('Error exit code = ' + inttostr(exitcode));
end; 

[Sanchoyzer]

If I write to the console

Code: [Select]

/home/alex/Рабочий\ стол/project/myapp param1 param2 < /home/alex/Рабочий\ стол/data/in.file
everything works. But

Code: [Select]

AProcess.Executable := 'bash';
AProcess.Parameters.Text :=
  '-c "/home/alex/Рабочий\ стол/project/myapp param1 param2 < /home/alex/Рабочий\ стол/data/in.file"';
AProcess.Options := AProcess.Options + [poWaitOnExit];
AProcess.ShowWindow := swoHIDE;
AProcess.Execute;
has no effect. What is wrong?

[Jurassic Pork]

hello,

   --> try 

Code: [Select]

AProcess.Parameters.DelimitedText
in place of ;

Code: [Select]

AProcess.Parameters.Text

[Sanchoyzer]

hello,

   --> try 

Code: [Select]

AProcess.Parameters.DelimitedText
in place of ;

Code: [Select]

AProcess.Parameters.Text

Oops, this is my typo. Thanks

[Sanchoyzer]

Code: [Select]

function execCmd(cmd: string; wait : boolean) : integer;
...
{$IFDEF WIN32}
AProcess.Executable := 'cmd.exe' ;
AProcess.Parameters.DelimitedText :=  '/c "' + cmd + '"';
{$ENDIF}
...

If the variable 'cmd' contains a spaces ('C:\Documents and Settings\alex\Рабочий стол\test_prog_gui\myapp.exe param1 param2 < in.file'), then the launch will not work. Adding double quotes (C:\"Documents and Settings"\...) does not solve the problem.

[Jurassic Pork]

the ending double quote is in a wrong place in your case :

the command is  :

Code: [Select]

cmd /c "C:\Documents and Settings\alex\Рабочий стол\test_prog_gui\myapp.exe param1 param2 < in.file"
must be :

Code: [Select]

[code]cmd /c "C:\Documents and Settings\alex\Рабочий стол\test_prog_gui\myapp.exe" param1 param2 < in.file[/code]

you can also use  this for the variable cmd in your case : 

Code: [Select]

' "C:\Documents and Settings\alex\Рабочий стол\test_prog_gui\myapp.exe" param1 param2 < in.file'

[Sanchoyzer]

Code: [Select]

  AProcess := TProcess.Create(nil);
  try
    AProcess.Executable := 'cmd.exe';
    AProcess.Parameters.DelimitedText :=
      '/c "C:\Documents and Settings\alex\Рабочий стол\test_prog_gui\myapp.exe" param1 param2 < "C:\Documents and Settings\alex\Рабочий стол\test_prog_gui\in.file"';
    AProcess.Options := AProcess.Options + [poWaitOnExit];
    AProcess.ShowWindow := swoHide;
    AProcess.Execute;
  finally
     AProcess.Free;
  end; 
No effect

[User137]

You can't use spacebar as delimiter (did you even set so?), because second parameter contains spaces in path. You may use " " but it's Lazarus that reads, and doesn't understand it. By my assumption the parameters for TProcess are separated by line change, not space. So does this work?

Code: [Select]

  AProcess := TProcess.Create(nil);
  try
    AProcess.Executable := 'cmd.exe';
    AProcess.Parameters.Add('/c');
    AProcess.Parameters.Add('"C:\Documents and Settings\alex\Рабочий стол\test_prog_gui\myapp.exe"');
    AProcess.Parameters.Add('param1');
    AProcess.Parameters.Add('param2');
    //AProcess.Parameters.Add('<'); // maybe works without space, so combine with next parameter?
    AProcess.Parameters.Add('<"C:\Documents and Settings\alex\Рабочий стол\test_prog_gui\in.file"');
    AProcess.Options := AProcess.Options + [poWaitOnExit];
    AProcess.ShowWindow := swoHide;
    AProcess.Execute;
  finally
     AProcess.Free;
  end;Then i there is also TUTF8Process in unit UTF8Process.pas. Might be relevant or not, because your path contains non A..Z.

[Sanchoyzer]

Code: [Select]

  try
    AProcess.Executable := 'cmd.exe';
    AProcess.Parameters.Add('/c');
    AProcess.Parameters.Add('"C:\Documents and Settings\alex\Рабочий стол\test_prog_gui\myapp.exe"');
...


Code: [Select]

AProcess.Parameters.Add('myapp.exe'); -- ok
AProcess.Parameters.Add('"C:\Documents and Settings\alex\Рабочий стол\test_prog_gui\myapp.exe"'); -- failTProcessUTF8 has not changed the situation

[Jurassic Pork]

TProcessUTF8 has not changed the situation

Are you sure ? because for me this code doesn't work :

Code: [Select]

var AProcess : TProcess;
begin
AProcess := TProcess.Create(nil);
AProcess.Executable := 'F:\Téléchargements\led.exe';
AProcess.Options := AProcess.Options + [poUsePipes];
AProcess.ShowWindow := swoSHOW;
AProcess.Execute;
Error 2  File not found

but this one works ( add UTF8Process in the "uses" )  :

Code: [Select]

var AProcessUTF8 : TProcessUTF8;
begin
AProcessUTF8 := TProcessUTF8.Create(nil);
AProcessUTF8.Executable := 'F:\Téléchargements\led.exe';
AProcessUTF8.Options := AProcessUTF8.Options + [poUsePipes];
AProcessUTF8.ShowWindow := swoSHOW;
AProcessUTF8.Execute; my code page is 850

[Sanchoyzer]

Code works:

Code: [Select]

var
  AProcess: TProcessUTF8;
begin
  AProcess := TProcessUTF8.Create(nil);
  try
    AProcess.Executable := 'cmd.exe';
    AProcess.Parameters.Add('/c');
    AProcess.Parameters.Add('"myapp.exe"');
    AProcess.Parameters.Add('param1');
    AProcess.Parameters.Add('param2');
    AProcess.Parameters.Add('<in.file');

    AProcess.Options := AProcess.Options + [poWaitOnExit];
    AProcess.ShowWindow := swoHide;
    AProcess.Execute;
  finally
     AProcess.Free;
  end;
Code doesn't work:

Code: [Select]

var
  AProcess: TProcessUTF8;
begin
  AProcess := TProcessUTF8.Create(nil);
  try
    AProcess.Executable := 'cmd.exe';
    AProcess.Parameters.Add('/c');
    AProcess.Parameters.Add('"C:\Documents and Settings\alex\Рабочий стол\test_prog_gui\myapp.exe"');
    AProcess.Parameters.Add('param1');
    AProcess.Parameters.Add('param2');
    AProcess.Parameters.Add('<in.file');

    AProcess.Options := AProcess.Options + [poWaitOnExit];
    AProcess.ShowWindow := swoHide;
    AProcess.Execute;
  finally
     AProcess.Free;
  end;


[Jurassic Pork]

try this :

Code: [Select]

var
  AProcess: TProcessUTF8;
begin
  AProcess := TProcessUTF8.Create(nil);
  try
    AProcess.Commandline := 'cmd.exe /c "C:\Documents and Settings\alex\Рабочий стол\test_prog_gui\myapp.exe" param1 param2 < in.file';
    AProcess.Options := AProcess.Options + [poWaitOnExit];
    AProcess.ShowWindow := swoHide;
    AProcess.Execute;


[Sanchoyzer]

Something strange is going on...

It works

Code: [Select]

var
  AProcess: TProcessUTF8;
   prefix: string;
begin
  AProcess := TProcessUTF8.Create(nil);
  try
    prefix := 'C:\Documents and Settings\alex\Рабочий стол\test_prog_gui\';
    AProcess.Commandline := Format('cmd.exe /c "%s" %s param2 < %s',
        [prefix + 'myapp.exe', 'param1', 'data\in.file']);
...

It works

Code: [Select]

    AProcess.Commandline := Format('cmd.exe /c %s %s param2 < "%s"',
        ['myapp.exe', 'param1', prefix + 'data\in.file']);

It does not works

Code: [Select]

    AProcess.Commandline := Format('cmd.exe /c "%s" %s param2 < "%s"',
        [prefix + 'myapp.exe', 'param1', prefix + 'data\in.file']);