[SOLVED] Sysutils.GetTempfile seems to return empty file

[BigChimp]

This code in my patchwrangler project (patchmanagement.pas, around line 369):

Code: [Select]

      TempPatchFile := SysUtils.GetTempFilename(GetTempDir(false), 'pmg');
      //Note: SysUtils.GetTempFileName('','') doesn't seem to work!?!?
      if TempPatchFile = '' then
      begin
        {$IFDEF DEBUG}
        FLog.Add('Debug: FindCandidates: GetTempFileName failed; IOResult: '+inttostr(IOResult));
        {$ENDIF DEBUG}
        {$IFDEF UNIX}
        TempPatchFile:='/tmp/pw'+Chr(97+(Random(25)))+Chr(97+(Random(25)))+Chr(97+(Random(25)));
        {$ELSE}
        FLog.Add('Could not get temporary file. Aborting');
        Exit(false);
        {$ENDIF UNIX}
      end;
      Assert(TempPatchFile<>'', 'Sysutils.GetTempFileName must return a file name'); //seems to be a problem on Linux!??!
REFUSES to produce a temp filename. FPC fixes 2.6, Laz trunk, both on Win x86 and Linux x86.

Is it me again?

You can download the patchwrangler project source [1] and run it. On Windows the log will say

Could not get temporary file. Aborting

[1]
https://bitbucket.org/reiniero/patchwrangler/downloads
select branches, download.

[Cyrax]

Does using ExcludeTrailingBackslash(GetTempDir(false)) help?

EDIT: SysUtils.GetTempFilename(GetTempDir(false), 'pmg') works for me. Free Pascal trunk 2.7.1-r24977, Lazarus trunk 1.1-r41950

[BigChimp]

@Cyrax, tried:

Code: [Select]

      TempPatchFile := SysUtils.GetTempFilename(ExcludeTrailingPathDelimiter(GetTempDir(false)), 'pmg');
... didn't help any.

Also tried

Code: [Select]

TempPatchFile := SysUtils.GetTempFilename('', 'pmg');
without success.

[Cyrax]

Hmm, strange.

Just checked out, FPC fixes works here. Free Pascal trunk 2.6.3-r24984, Lazarus trunk 1.1 r41933.

[BigChimp]

Thanks Cyrax. Mmmph. Guess I'll have to double check my FPC version...
Edit: oops, yes, I wasn't uses fixes 2.6 but FPC trunk for some compiles in order to try and debug. I'll give it another go with Laz 1.0.10/FPC 2.6.2

[BigChimp]

Just ran delp ., removed all .exe and .obj files, recompiled with Laz 1.0.10/FPC 2.6.2 x86 Windows... same problem...

@Cyrax: what OS did you test it on?

[Cyrax]

Windows Server 2008 R2. I'm on admin account and my temp file directory location is system wide one. With necessary security permissions applied on it.

[BigChimp]

Ok, thanks.

I'm on Win 7, admin.

Guess it's time to test it on an older Windows version to make sure...
(Strange that it happens on my Debian Linux unstable as well though)

[BigChimp]

Solved thanks to Juha's help (see patchwrangler thread in the Third Party subforum).

As usual, PEBKAC/PICNIC involved - having an {$IFDEF} that influenced the program flow.

@Cyrax: thanks for the help!