add txt file contents to memo

[Zath]

My little program can currently open a directory with DirectoryEdit, display its contents in a FileListBox and doubleclick a line to show the name in a showmessage.
All very basic.

I would like to be able to doubleclick the filename and open the file to display its contents in a memobox or similar for editing.
The file will only be .txt.
Can anyone offer any help ?
Thanks.

Code: [Select]

unit Unit1;

{$mode objfpc}{$H+}

interface

uses
  Classes, SysUtils, FileUtil, ListFilterEdit, Forms, Controls, Graphics,
  Dialogs, StdCtrls, EditBtn, FileCtrl;

type

  { TForm1 }

  TForm1 = class(TForm)
    DirectoryEdit1: TDirectoryEdit;
    FileListBox1: TFileListBox;
    Memo1: TMemo;
    procedure DirectoryEdit1Change(Sender: TObject);
    procedure FileListBox1DblClick(Sender: TObject);
  private
    { private declarations }
  public
    { public declarations }
  end;

var
  Form1: TForm1;

implementation

{$R *.lfm}

{ TForm1 }

procedure TForm1.DirectoryEdit1Change(Sender: TObject);
begin
  FileListBox1.Directory:=DirectoryEdit1.Directory;
end;

procedure TForm1.FileListBox1DblClick(Sender: TObject);
begin
  showmessage(extractFileName(FileListbox1.filename));
end;

end.
   

[taazz]

Code: [Select]

procedure TForm1.FileListBox1DblClick(Sender: TObject);
begin
  //showmessage(extractFileName(FileListbox1.filename));
  Memo1.Lines.LoadFromFile(FileListbox1.filename);
end;


[typo]

Perhaps you will must convert UTF8 filenames:

Code: [Select]

Memo1.Lines.LoadFromFile(UTF8ToAnsi(FileListBox1.FileName));


[taazz]

No, Filename is of type string not utf8string this means that if there was a conversion needed it should have already been converted before it entered the file list. Farther more it would be problematic if every single component in the lcl used its own encoding, it paramount to use a single encoding for all the lcl otherwise it creates a lot of uncertainty in your code or simple put, it is a design error to have multiple encodings of strings.

[typo]

I only can load a memo with accented characters on filenames if I use UTF8ToAnsi.

[taazz]

depends how you got the filename it self, a constant for example, might need that if the source file is saved as a UTF8 if it saved as an ANSI then it shouldn't need it. In any case getting the filename from any lcl component should not require the use of string conversion it should be already in the default lcl string format for the widgetset at hand in case of windows and lcl 1.0.8 and FCP2.6.2 that should be ANSI.

In any other case it is a bug that need to be reported, keep in mind that utf8 specific component are excluded from the above statement but at the same time must be clearly marked as such and they must not be confused for the stock components of lcl.

[Zath]

Thanks Taazz, that's helped a lot and moved me on.

[Zath]

I now have the program working to locate a directory, list the .txt files and then display the contents of the selected file in a memobox.
How can I save changes made in the memobox directly to the text file ?
Is this possible or do I have to open the file and perform a save ?

Thanks.

[taazz]

memo1.llines.savetofile(FileListbox1.filename);

[Zath]

memo1.llines.savetofile(FileListbox1.filename);

As simple as that ?
Thanks big time.
I'll have to add an "are you sure" option methinks.

[taazz]

Yes the command will replace the contents of the file with what ever memo1 has at that time.

[Zath]

What would the best method be to prevent a user changing the selection in filelistbox if a change has been made in memo.
Currently I enable a button on memo change and buttonclick saves the changes. However, the filelist selection can be changed and the save would save to the new selected file and not the one actually loaded.
Removing the cursor doesn't prevent item selection.
I'm assuming a yes/no dialog window would be an answer but I'm still unsure what event I should assign this to to catch it.
I don't understand the EditDone event which, on the surface, seems the one to choose.

[taazz]

how about after you load the file in the memo you set an internal variable with the filename used to load the data and use that instead of the filebox1.filename?

[Zath]

how about after you load the file in the memo you set an internal variable with the filename used to load the data and use that instead of the filebox1.filename?

That's exactly what I did and it works a treat.
Now I need to stop the memo showing as changed when it loads the first text file.
I suppose it could load the first file on startup but that's not ideal.

[CM630]

I only can load a memo with accented characters on filenames if I use UTF8ToAnsi.

I usually use UTF8toSys, without it nothing works in 90% of the cases.

For example the following code does not work, because the file cannot be found

Code: [Select]

procedure TForm1.Button1Click(Sender: TObject);
var
  OpenDialog: TOpenDialog;
begin
  OpenDialog:= TOpenDialog.create(self);
  if OpenDialog.Execute then Memo1.Lines.LoadFromFile(OpenDialog.FileName);
end; while

Code: [Select]

Memo1.Lines.LoadFromFile(UTF8ToSys(OpenDialog.FileName)); is quite okay.

Code: [Select]

Memo1.Lines.LoadFromFile(FileListbox1.filename); cannot find the file, while

Code: [Select]

  Memo1.Lines.LoadFromFile(UTF8ToSys(FileListbox1.filename)); finds it.


Also, .LoadFromFile is not much usable. It is okay for UTF8 files, but for other cases I recommend using utf8tools.