How to call from a .txt file into an array record?

[Leledumbo]

I keep getting an external SIGSEGV with this code, is it because there are too many variables or something, I know its something to do with memory allocation.

It won't be due to too many variables (the compiler will reject first), neither with memory allocation (you'll get EOutOfMemory instead), but rather memory access. Have you turned on range checking? The only possibility I can see is that one of your array indexing is out of range.

[BigChimp]

Please post new questions in new threads, mention Lazarus+OS, see link to the faq in my signature below

Haven't looked at the code.

You can format your code first (source/jedi code format) so you get nice indenting etc that often shows errors already.

Also, try going through the code with the debugger (Run/Run or F9) to see where things go wrong.

Thanks

[Afrooman108]

How would I know if the issue was with the arrays, how can i fix this if it is the range check thing?

[Leledumbo]

How would I know if the issue was with the arrays, how can i fix this if it is the range check thing?

Just do as I say and run your program UNDER DEBUGGER, or at least activate also -gl then run your program. It will generate the error name/code and backtrace showing which line causes the error. Fix by modifying your code so the error doesn't happen again.

[Afrooman108]

When I run it with the debugger it doesn't say anything but a window pops up wit 'external sigsegv' and the assembler opens and shows me the address '40BE15'.

I'm using 32bit V1.0.6 with MINGW debugger.

[Afrooman108]

I get the same error with this.

Code: [Select]

Crun:=Datetostr(dat);
  SB:=1;
  SC:=2;
  SD:=3;
  SE:=4;
  SF:=5;





  for IP:=1 to 20 do begin
  If (A[IP].date[SB]=crun) or (A[IP].date[SC]=crun) or (A[IP].date[SD]=crun) or (A[IP].date[SE]=crun) or (A[IP].date[SF]=crun) then begin
 W:=W+1;
  end;

  If (B[IP].date[SB]=crun) or (B[IP].date[SC]=crun) or (B[IP].date[SD]=crun) or (B[IP].date[SE]=crun) or (B[IP].date[SF]=crun) then begin
       W:=W+1;
      end;

  If (C[IP].date[SB]=crun) or (C[IP].date[SC]=crun) or (C[IP].date[SD]=crun) or (C[IP].date[SE]=crun) or (C[IP].date[SF]=crun) then begin
     W:=W+1;
  end;

      If (D[IP].date[SB]=crun) or (D[IP].date[SC]=crun) or (D[IP].date[SD]=crun) or (D[IP].date[SE]=crun) or (D[IP].date[SF]=crun) then begin
     U:=U+1;
      end;

  If (E[IP].date[SB]=crun) or (E[IP].date[SC]=crun) or (E[IP].date[SD]=crun) or (E[IP].date[SE]=crun) or (E[IP].date[SF]=crun) then begin
     U:=U+1;
  end;

      If (F[IP].date[SB]=crun) or (F[IP].date[SC]=crun) or (F[IP].date[SD]=crun) or (F[IP].date[SE]=crun) or (F[IP].date[SF]=crun) then begin
      U:=U+1;
      end;

  If (G[IP].date[SB]=crun) or (G[IP].date[SC]=crun) or (G[IP].date[SD]=crun) or (G[IP].date[SE]=crun) or (G[IP].date[SF]=crun) then begin
  X:=X+1;
  end;

     If (H[IP].date[SB]=crun) or (H[IP].date[SC]=crun) or (H[IP].date[SD]=crun) or (H[IP].date[SE]=crun) or (H[IP].date[SF]=crun) then begin
     X:=X+1;
     end;

  If (I[IP].date[SB]=crun) or (I[IP].date[SC]=crun) or (I[IP].date[SD]=crun) or (I[IP].date[SE]=crun) or (I[IP].date[SF]=crun) then begin
  X:=X+1;
  end;

  If (J[IP].date[SB]=crun) or (J[IP].date[SC]=crun) or (J[IP].date[SD]=crun) or (J[IP].date[SE]=crun) or (J[IP].date[SF]=crun) then begin
  X:=X+1;
     end;

  If (K[IP].date[SB]=crun) or (K[IP].date[SC]=crun) or (K[IP].date[SD]=crun) or (K[IP].date[SE]=crun) or (K[IP].date[SF]=crun) then begin
  X:=X+1;
  end;
  end;

  writeln('£',(W*AtoC)+(U*DtoF)+(X*GtoK):8:2);
  readln(da5) 

[Peter_Vadasz]

Please take a look at your arrays declaration. A lot of arrays contains less elements than 20.
Oh, and take a look at this also: http://en.wikipedia.org/wiki/Don%27t_repeat_yourself

[Afrooman108]

Here is my set up for my variables, there are 11 arrays A-K

Code: [Select]

rec =
surname:array[1..5] of string
name:array[1..5] of string
date:array[1..5] of string
az
price


i have A:array[1..20] of rec


[User137]

Other than program being still horribly illogical in all possible ways, i don't see anything wrong with the code lines you showed, when it comes to indexing. Error is propably somewhere else. I already converted your whole app for dynamic arrays, but you just insist on using the static one...

I mean, trust me when i say,
A:array[1..20] of rec;
B:array[1..20] of rec;
C:array[1..20] of rec;
D:array[1..20] of rec;
E:array[1..20] of rec;
F:array[1..20] of rec;
G:array[1..20] of rec;
H:array[1..20] of rec;
I:array[1..20] of rec;
...
Z:array[1..20] of rec;
... Is not a database for any reasonable person. All you need is 1 array
mydata: array of rec;

[Afrooman108]

What is a dynamic array? How could i improve this?
I don't understand how it is illogical.

[taazz]

dynamic array declaration

Code: [Select]

var
  A: Array of rec;

Usage.....

Code: [Select]

SetLength(A, 20);
For Counter := Low(A) to High(A) do
  A[Counter] := MyCustomRec;

Clean Up

Code: [Select]

SetLlength(A,0);


[taazz]

I apologize, it will not happen again.

[Afrooman108]

Good.

[Afrooman108]

Nah, jus' messin'.

[User137]

I already converted your whole app for dynamic arrays...

Oops sorry, i mixed with another very similar thread. It shows some use of dynamic arrays though.

How could i improve this? I don't understand how it is illogical.

Lets say we have 5 different schools A, B, C, D, E, and we want to make simple array database of all the students in them. Would you go with 5 arrays "StudentA, StudentB...StudentC"? It is simpler to make with 1 array "student". For example a record:

Code: [Select]

type
  TStudent = record
    name, school: string;
    // add more data if needed...
  end;
  PStudent = ^TStudent;

var student: array of TStudent;

// Add 1 student
procedure AddStudent(const name, school: string);
var index: integer;
begin
  setlength(student, length(student)+1); // Increase array size by 1
  index:=high(student);
  student[index].name:=name;
  student[index].school:=school;
end;

// Print all students that study in school that is given in parameter
procedure PrintCertainSchool(const school: string);
var i: integer;
begin
  writeln('Students in ', school);
  for i:=0 to high(student) do
    if student[i].school=school then
      writeln(i, '. ', student[i].name);
  // Notice how i use indents to tell there starts a code block.
  // Every time there's 2 spaces, i could use begin..end pair if more
  // lines would be required.
end;And other thing that is illogical is the use of indents, there are spaces here and there. Lazarus converts them to spaces automatically, so it's certainly not a tab character messing with forum.

Other than that, you have written more code than before (we don't know what the program does at all), so giving more assistance might require posting the entire code again.