SOLVED: FPSZipper: improvements to FPC zipper?

[BigChimp]

Hi,

I've been looking at FPC bug 23482 TUnzipper cannot list and unpack archives > 2 GB
and looking if adding zip64 support may be feasible (for e.g. files > 4GB).

I found fpszipper.pp and noticed it has some changed compared to fpc trunk zipper. Some questions/remarks:
- supports comment field=> seems to extract this functionality to its own property??
- different handling of version required
- different handling of "zipbitflag" => is this some kind of indication of compression depending on format?
- it seems to have some fixes for big endian in tunzipper.readzipdirectory
When was this split from fpc zip,were the fixes already submitted to fpc (which bug report) and if not, would it make sense to still do so?
There've been recent fixes in the fpc zipper for 64 bit compatibility (see the bug report I mentioned) so having 1 file may be a good thing

Thanks,
BigChimp

[felipemdc]

My last change to this was a long time ago, so I dont remember anymore:

http://lazarus-ccr.svn.sourceforge.net/viewvc/lazarus-ccr/components/fpspreadsheet/fpszipper.pp?view=log

I think that I wanted a feature from fpc trunk, but I didnt want to drop support for older FPC versions. I doubt that I added any fixes without commiting them to fpc-trunk, but you can always check this. Probably this unit is no longer required as it was added in the times of FPC 2.5.1 and now we support a minumum of 2.6

[BigChimp]

Thanks, felipe, seems like most improvements are in 2.6 indeed.

Meanwhile, Marco implemented some fixes recently in fpc trunk that allow 2+ gig zip files..

Thanks again.