Possible TStringGrid issue

[Blaazen]

Maybe this is TStringGrid incompatibility cross platforms (working with OnDrawCell event).

Try attached project. You should see text in cell.

Does not work at Linux + Qt 4.7.1, Laz. 0.9.31 + fpc 2.5.1

[Blaazen]

After further analysis I maybe found patch.

Adding one line to grids.pas (line 8842) brings back previous functionality.

Code: [Select]

procedure TCustomDrawGrid.DrawCell(aCol,aRow: Integer; aRect: TRect;
  aState:TGridDrawState);
var
  OldDefaultDrawing: boolean;
begin
  if Assigned(OnDrawCell) and not(CsDesigning in ComponentState) then begin
    PrepareCanvas(aCol, aRow, aState);
    if DefaultDrawing then
      DefaultDrawCell(aCol, aRow, aRect, aState);
    OnDrawCell(Self,aCol,aRow,aRect,aState);
    DrawTextInCell(aCol,aRow,aRect,aState); //added
  end else begin ....  

(See another thread and screenshot from fredvs: http://www.lazarus.freepascal.org/index.php/topic,12589.msg65163/topicseen.html#new)

Now text in StringGrid is visible again when OnDrawCell event is assigned.

Seems work on both Qt and GTK2.

I'll post bugreport but tommorow, it's too late now.

[Blaazen]

I created bugreport http://bugs.freepascal.org/view.php?id=19043

[Fred vS]

Hello Mr Blaazen.

DrawTextInCell(aCol,aRow,aRect,aState); //added

Nice ! I will try it....

Thanks

[Fred vS]

Hello amigos.
Since last post of Mr Blaazen, this bug is still in Lazarus, even in version 1 RC 2 

Then it should be a good idea to add this in your /lcl/grids.pas code :

DrawTextInCell(aCol,aRow,aRect,aState) //added

Just like Mr Blaazen show us in earlier topics...

I have added also a variable, custgrid, so i can choose to redraw text or not...

first add this after procedure Register;

Code: [Select]

var

custgrid : shortint ;
and add this in procedure TCustomDrawGrid.DrawCell(aCol,aRow: Integer; aRect: TRect;
  aState:TGridDrawState);

Code: [Select]

procedure TCustomDrawGrid.DrawCell(aCol,aRow: Integer; aRect: TRect;
  aState:TGridDrawState);
var
  OldDefaultDrawing: boolean;
begin
  if Assigned(OnDrawCell) and not(CsDesigning in ComponentState) then begin
    PrepareCanvas(aCol, aRow, aState);
    if DefaultDrawing then
      DefaultDrawCell(aCol, aRow, aRect, aState);
    OnDrawCell(Self,aCol,aRow,aRect,aState);
if custgrid = 1 then DrawTextInCell(aCol,aRow,aRect,aState) //added
    end else begin
    OldDefaultDrawing:=FDefaultDrawing;
    FDefaultDrawing:=True;
    try
      PrepareCanvas(aCol, aRow, aState);
    finally
      FDefaultDrawing:=OldDefaultDrawing;
    end;
    DefaultDrawCell(aCol,aRow,aRect,aState);
  end;
  DrawCellGrid(aCol,aRow,aRect,aState);
end;

Then re-compile Lazarus.

And i hope that one day it gonna be fix so we do not need to change the source and recompile Lazarus...

[jujibo]

You can take a look at bugreport:

http://bugs.freepascal.org/view.php?id=19043

Status says closed. Read added notes.

[Fred vS]

Status says closed. Read added notes.

The status is closed, maybe, but the bug remains.
I have read that added notes long time ago, but without the patch, i cannot draw my cell and write text on in, even on brand new Lazarus versions...

[jesusr]

Previously, it worked as described, but later it was changed to the current behavior, the reason is for example when you draw a icon left aligned in the cell, if you do not draw also the text next to the icon, the automatic draw text would overwrite the icon. 

In this case is the whole cell background that is being painted and the text alignment set in OnPrepareCanvas may be right, but we don't have a way to tell the grid.

If somebody can envision a property, option, etc. So the grid can be instructed to always draw the text even on custom OnDrawCell, please submit a bug report with a feature resquest, if it includes an implementation patch, much better