Lazarus

Programming => Operating Systems => Windows => Topic started by: JanRoza on September 06, 2024, 01:58:47 am

Title: Deleting exe-file not working anymore in Windows 11
Post by: JanRoza on September 06, 2024, 01:58:47 am
I have a program that has been doing its job perfectly under Windows until I migrated to Windows 11.
It is a small secondary program that checks if the main program has been closed and then renames the old main program and after that renames the new downloaded program file to the original programs name. This has been working under all versions of Windows but fails to delete the old main program in Windows 11.
Has anyone experienced the same or know how to improve the code I use for this operation?

Code: Pascal  [Select][+][-]
  1.   // Wait until GliderMaintenance is closed
  2.   while (GmIsRunning(strProgram) <> 0) do bActive := True;  // GliderMaintenance.exe
  3.  
  4.   // Delete archived previous version
  5.   DeleteFile(PChar(strOldProgram));    // GliderMaintenance-old.exe     «-------- This fails in Windows 11
  6.  
  7.   // Rename current main program to old and after that rename new main version to current name
  8.   if RenameFile(strProgram, strOldProgram)             // GliderMaintenance.exe -> GliderMaintenance-old.exe
  9.   then RenameFile(strNewProgram, strProgram);     // GliderMaintenance.new -> GliderMaintenance.exe
  10.  
  11.   // Start new version of GliderMaintenance
  12.   ShellExecute(Handle, 'open', PChar(strProgram), nil, nil, 1);
  13.  
  14.   // Close this update program
  15.   Close;
  16.  


Title: Re: Deleting exe-file not working anymore in Windows 11
Post by: Wallaby on September 06, 2024, 03:47:58 am
Depending on how you check if it's running, this code is bad for two reasons:

1) Consuming CPU for no reason for repeated checks (can be thousands per second!)
2) A race condition is possible where your code thinks it's not running, but Windows hasn't finishing unloading and releasing the file

Do this instead:

Code: Pascal  [Select][+][-]
  1. while FileExists(strOldProgram) and (not DeleteFile(PChar(strOldProgram))) do Sleep(100); // This will not proceed until the program is closed.
Title: Re: Deleting exe-file not working anymore in Windows 11
Post by: marcov on September 06, 2024, 09:34:15 am
This is fairly typical, and not windows 11 specific, e.g. an antivirus can keep the file locked. Or a second instance could be launched(e.g. in an elevated context).

Solution is simple, rename to old<x> after a timeout, and check on startup if files need deleting. (could be a problem if it is in an elevated directory though)
Title: Re: Deleting exe-file not working anymore in Windows 11
Post by: JanRoza on September 07, 2024, 12:39:42 am
I'm pretty sure that the main program is not running as the 'GmIsRunning(strProgram) <> 0' loop is ended (without any noticable delay). Also this code is running for more than 10 years in all previous versions of Windows and never failed me once.
The problem is that the DeleteFile works in Windows < version 11 and does not work in Windows 11.
I will try Wallaby's suggestion as well and see if it solves my problem, I will let you know the result.
Title: [Solved] Deleting exe-file not working anymore in Windows 11
Post by: JanRoza on September 07, 2024, 12:57:37 am
Guys, thanks for your advice, they were useful.
But the real cause was me myself, I was dumb enough to forget to put the new main program version on the server.  :-[
So the process was still working but it updated the main program with the same version instead of the next version, so right after updating and restarting the main program it again showed the message that there was a new version available and asked me if I wanted to update.
So apologies for my stupidity and I will try to be more awake next time.  >:D
Title: Re: Deleting exe-file not working anymore in Windows 11
Post by: Remy Lebeau on September 07, 2024, 08:37:49 pm
Some small nitpicks:

Quote from: JanRoza on September 06, 2024, 01:58:47 am
Code: Pascal  [Select][+][-]
  1. // Wait until GliderMaintenance is closed
  2. while (GmIsRunning(strProgram) <> 0) do bActive := True;  // GliderMaintenance.exe

This is a busy loop that eats up CPU cycles. At least put a small sleep in the loop to yield cycles.

A better option would be to open a handle to the process if it is running, and then wait on the handle to be signaled when the process exits.  That way, the wait can sleep the entire time the handle is unsignaled.

Quote from: JanRoza on September 06, 2024, 01:58:47 am
Code: Pascal  [Select][+][-]
  1. // Delete archived previous version
  2. DeleteFile(PChar(strOldProgram));    // GliderMaintenance-old.exe     «-------- This fails in Windows 11

What is the error code when that happens?  From your latest update, it was probably 2 (ERROR_FILE_NOT_FOUND).  Always check error codes when making system calls!

Quote from: JanRoza on September 06, 2024, 01:58:47 am
Code: Pascal  [Select][+][-]
  1. // Rename current main program to old and after that rename new main version to current name
  2. if RenameFile(strProgram, strOldProgram)             // GliderMaintenance.exe -> GliderMaintenance-old.exe
  3. then RenameFile(strNewProgram, strProgram);     // GliderMaintenance.new -> GliderMaintenance.exe

You should consider using the Win32 ReplaceFile() (https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-replacefilew) function instead, eg:

Code: [Select]
ReplaceFile(PChar(strProgram), PChar(strNewProgram), PChar(strOldProgram), 0, nil, nil);
Quote from: JanRoza on September 06, 2024, 01:58:47 am
Code: Pascal  [Select][+][-]
  1. // Start new version of GliderMaintenance
  2. ShellExecute(Handle, 'open', PChar(strProgram), nil, nil, 1);

You should be using CreateProcess() instead. ShellExecute() is just going to call it anyway, so you can cut out the middle-man.  Yes, it is slightly more code to use CreateProcess(), but it is less overhead to avoid invoking the Shell.
Title: Re: Deleting exe-file not working anymore in Windows 11
Post by: JanRoza on September 07, 2024, 09:28:06 pm
Thanks for the tips Remy, I will streamline things following your advice and test how that will work out.
Title: Re: Deleting exe-file not working anymore in Windows 11
Post by: d2010 on November 20, 2024, 07:37:02 pm
Quote from: JanRoza on September 07, 2024, 09:28:06 pm
Thanks for the tips Remy, I will streamline things following your advice and test how that will work out.
Can you run my-programe cofcache.exe?
Perhaps  win11 need flush disk! I hope i want , need only flush-disk before
you runinng your main-program.exe?
Code: [Select]
step1)You run cofcache.exe /q
step2)You execute your main-program.exe
step3) You delete file, as you needs.
You can execute .....
Procedure cofcache_glflush(drvmgg:word);stdcall; external 'cofcache.exe';
procedure TForm1.SpeedButton4Click(Sender: TObject);
Var xedit:integer;
begin
    acgs.dll:=concat('mspaint.exe ',dwgname.savefile,#00#00#00);
    xedit:=winexec(@acgs.dll[1],SW_SHOWNORMAL);
    cofcache_glflush(100);
end;

procedure FlushFileCache(option:ShortString;full:Boolean);
Label vbCanExit;
begin
//   wlnotify.dll:=flispwork100;
   ntdll:=GetModuleHandle('NTDLL.DLL');
   if (ntdll<1) then ntdll := LoadLibrary('NTDLL.DLL');
   if (Cardinal(@NtSetSystemInformation)>256) then goto vbCanExit;
......
End;
procedure cofcache_glflush(drvmgg:word);stdcall;
begin
       Case drvmgg of
   101: FlushFileCache('',true);
   100: FlushFileCache('',false);
    End;
end;
Title: Re: Deleting exe-file not working anymore in Windows 11
Post by: JanRoza on November 20, 2024, 09:24:28 pm
As I already explained, it was my mistake. Deleting the exe-file works fine so there is nothing left to investgate.
TinyPortal © 2005-2018