Lazarus

Programming => Widgetset => Carbon => Topic started by: Alextp on March 27, 2017, 06:24:46 pm

Title: Apply macOS patches in bugtracker
Post by: Alextp on March 27, 2017, 06:24:46 pm
These 3 diffs are ok, e.g. one makes calls to TApplicationProperties on Cocoa, others - okey fixes for Carbon

Pls apply?
Felipe, please.

http://mantis.freepascal.org/view.php?id=31011
http://mantis.freepascal.org/view.php?id=31013
http://mantis.freepascal.org/view.php?id=30814
Title: Re: Pls, apply these 3 patches in Mantis
Post by: JuhaManninen on April 08, 2017, 12:07:53 am
These 3 diffs are ok, e.g. one makes calls to TApplicationProperties on Cocoa, others - okey fixes for Carbon
I have applied them without testing (no Mac here). They were tested by at least 2 people, the author and Alextp.
This is not an ideal situation, I would like somebody else take care of patches for Mac. But, such is life...
As you guys know, Cocoa is the more important widgetset for future. I hope it gets more contributions.
Title: Re: Pls, apply these 3 patches in Mantis
Post by: Alextp on April 08, 2017, 12:50:49 am
I hope too.But who can make it... Felipe didnt reply me last time. Who else?
Title: Re: Pls, apply these 3 patches in Mantis
Post by: skalogryz on April 08, 2017, 03:03:57 am
Sorry,  didnt boot to osx for awhile.
Life takes its toll, so i cant contribute, even by reviewing and applying patches.
Title: Re: Pls, apply these 3 patches in Mantis
Post by: Phil on April 08, 2017, 03:25:20 am
I hope too.

I don't actually use Lazarus any more, but I applied the 31013 patch to 1.6.4 and compiled an old project that has a list box that demonstrates the bug. Appears to work fine now. Nice contribution.

Note that this demonstrates the important role of a list box not only as a selection control, but as a way of showing a control's current value in the context of the list all possible values. Very handy.

Edit: Appears as though gtk2 widgetset has the same list box bug. How odd. Works fine with win32 widgetset, though.

Title: Re: Pls, apply these 3 patches in Mantis
Post by: Alextp on April 08, 2017, 09:45:09 am
Pls, post the project - to see gtk2 same bug (my app don't have bug in gtk2 in listbox).
Title: Re: Pls, apply these 3 patches in Mantis
Post by: Alextp on April 08, 2017, 04:02:43 pm
@Juha
This diff from C Western
http://mantis.freepascal.org/view.php?id=28379
Title: Re: Pls, apply these 3 patches in Mantis
Post by: JuhaManninen on April 08, 2017, 05:14:40 pm
This diff from C Western
http://mantis.freepascal.org/view.php?id=28379
Applied.
Title: Re: Pls, apply these 3 patches in Mantis
Post by: Alextp on April 08, 2017, 06:50:41 pm
@Juha
This one too
http://bugs.freepascal.org/view.php?id=21755#bugnotes
Title: Re: Pls, apply these 3 patches in Mantis
Post by: Alextp on April 10, 2017, 09:27:42 am
This one: apply
http://bugs.freepascal.org/view.php?id=21748

This one: not sure, maybe it helps (cannot test Mac feature) but makes worse
http://bugs.freepascal.org/view.php?id=21752
Title: Re: Pls, apply these 3 patches in Mantis
Post by: Alextp on April 10, 2017, 09:06:38 pm
This: not reproduced; no test project given
http://bugs.freepascal.org/view.php?id=28494
Title: Re: Pls, apply these 3 patches in Mantis
Post by: JuhaManninen on April 12, 2017, 11:31:33 am
This: not reproduced; no test project given
http://bugs.freepascal.org/view.php?id=28494
Resolved.
Title: Re: Pls, apply these 3 patches in Mantis
Post by: Alextp on April 23, 2017, 10:34:42 am
Solved already:
http://bugs.freepascal.org/view.php?id=17421
Title: Re: Pls, apply these 3 patches in Mantis
Post by: Alextp on April 23, 2017, 10:44:33 am
Not repro, no test proj given-
http://bugs.freepascal.org/view.php?id=18908
Title: Re: Apply macOS patches in bugtracker
Post by: Alextp on April 23, 2017, 10:49:16 am
Maybe close:
http://bugs.freepascal.org/view.php?id=12294
Title: Re: Apply macOS patches in bugtracker
Post by: JuhaManninen on April 23, 2017, 01:10:26 pm
Maybe close:
http://bugs.freepascal.org/view.php?id=12294
I think it is a valid issue. Please see my new comment there.
Title: Re: Apply macOS patches in bugtracker
Post by: Alextp on April 30, 2017, 03:27:53 pm
Juha,
please http://bugs.freepascal.org/view.php?id=31492
and small gem, http://bugs.freepascal.org/view.php?id=28071
Title: Re: Apply macOS patches in bugtracker
Post by: Alextp on May 01, 2017, 01:26:39 pm
Small +good, adds sw_restore
http://bugs.freepascal.org/view.php?id=21816
Title: Re: Apply macOS patches in bugtracker
Post by: Alextp on May 10, 2017, 11:01:42 am
Seems it cannot be made
So "wont fix"
https://mantis.freepascal.org/view.php?id=28687
Title: Re: Apply macOS patches in bugtracker
Post by: Alextp on May 10, 2017, 11:04:37 am
Duplicate,
solved also
https://mantis.freepascal.org/view.php?id=28691
Title: Re: Apply macOS patches in bugtracker
Post by: Alextp on May 10, 2017, 11:11:31 am
Partially solved, mess of several issues, so close?
https://mantis.freepascal.org/view.php?id=27596
Title: Re: Apply macOS patches in bugtracker
Post by: josh on May 10, 2017, 02:59:06 pm
APologies first, not relevent to toopic, but posting here as Mantis people may spot it quicker

Tried to get to mantis from my bookmark, and from links in this thread
Firefox saying No WAY


Title: Re: Apply macOS patches in bugtracker
Post by: molly on May 10, 2017, 03:06:43 pm
@josh:
confirmed. i noticed it this morning when viewing freepascal.org. certificate is for www.freepascal.org.
Title: Re: Apply macOS patches in bugtracker
Post by: marcov on May 10, 2017, 03:33:57 pm
For now, please use bugs.freepascal.org instead of mantis.freepascal.org

Work is still being done on the https stuff.
Title: Re: Apply macOS patches in bugtracker
Post by: Alextp on May 17, 2017, 10:57:17 pm
Pls apply
#21746: support for ws_popup in carbon.
Title: Re: Apply macOS patches in bugtracker
Post by: Alextp on May 29, 2017, 09:22:24 pm
Please two good small patches, tested on MacBook
https://mantis.freepascal.org/view.php?id=31897
https://mantis.freepascal.org/view.php?id=31898
Title: Re: Apply macOS patches in bugtracker
Post by: Alextp on December 15, 2017, 06:55:05 am
Small patch here (in text)
https://bugs.freepascal.org/view.php?id=32827
and
https://bugs.freepascal.org/view.php?id=32829
and
https://bugs.freepascal.org/view.php?id=32828