Lazarus

Programming => LCL => Topic started by: trev on June 15, 2019, 09:14:50 am

Title: [Solved] Very slow assigning a TStringList to a TMemo
Post by: trev on June 15, 2019, 09:14:50 am

I'm assigning a TStringList to a TMemo - there are 4,004 strings of between 10 and 15 characters. On macOS this takes around 33 seconds and "beach balls" the cursor. Using Delphi, the macOS application takes around 2 seconds (I'm porting my application from Delphi to Lazarus).

Code: [Select]

Memo.Lines := strList;

I don't see any way of speeding this up...

Title: Re: Very slow assigning a TStringList to a TMemo
Post by: SymbolicFrank on June 15, 2019, 09:18:41 am

Use TStrings.BeginUpdate and TStrings.EndUpdate. It turns off the display refresh.

Title: Re: Very slow assigning a TStringList to a TMemo
Post by: trev on June 15, 2019, 09:31:59 am

Quote from: SymbolicFrank on June 15, 2019, 09:18:41 am

Use TStrings.BeginUpdate and TStrings.EndUpdate. It turns off the display refresh.

There is no display. TStringList does not display; it is then assigned to Memo.Lines to avoid the delay of adding lines one by one to the Memo and also to sort the strings before adding.

Title: Re: Very slow assigning a TStringList to a TMemo
Post by: Thaddy on June 15, 2019, 10:19:31 am

Try memo.lines.text := stringlist.text, but plz do use beginupdate/endupdate. That's speed essential.

Title: Re: Very slow assigning a TStringList to a TMemo
Post by: howardpc on June 15, 2019, 11:01:48 am

Quote from: trev on June 15, 2019, 09:31:59 am

Quote from: SymbolicFrank on June 15, 2019, 09:18:41 am

Use TStrings.BeginUpdate and TStrings.EndUpdate. It turns off the display refresh.

There is no display. TStringList does not display; it is then assigned to Memo.Lines to avoid the delay of adding lines one by one to the Memo and also to sort the strings before adding.

There is a display. SymbolicFrank was writing about the Memo, not the strList.

Code: Pascal  [Select][+][-]

1. procedure TForm1.Button1Click(Sender: TObject);
2. var
3.   i: Integer;
4.   period: TTime;
5.   ts: TTimeStamp;
6. begin
7.   strList := TStringList.Create;
8.   try
9.     for i := 0 to 4000 do
10.       strList.Add('This is line number %d',[i]);
11.     period := Time;
12.     Memo1.Lines.BeginUpdate;
13.     Memo1.Lines := strList;
14.     Memo1.Lines.EndUpdate;
15.     ts := DateTimeToTimeStamp(Time - period);
16.     Memo1.Lines.Add('Operation took %d ms',[ts.Time]);
17.     Memo1.SelStart := Length(Memo1.Text);
18.   finally
19.      strList.Free;
20.   end;
21. end;

Title: Re: Very slow assigning a TStringList to a TMemo
Post by: trev on June 15, 2019, 03:01:16 pm

I did actually try it with the TMemo (and even the TStringList :) just in case.

Alas, no speed increase at all. See pic (I added your time code along with Begin/End around the Memo StringList assignment). The memo is not actually visible at the time its contents is added (clicking on the tabcontrol to show the memo causes it to read the file, sort the string, and then assign the memo).

Title: Re: Very slow assigning a TStringList to a TMemo
Post by: howardpc on June 15, 2019, 03:48:55 pm

If you are convinced you are not timing the process of constructing the strList, only timing the process of assigning the pre-built strList to your memo's Lines, then I think that either the implementation of BeginUpdate/EndUpdate or of Lines.Assign() for TMemo on MacOS is flawed. I know nothing about the underlying widget used on the Mac for a memo, but your result is ridiculous.

Copying 4,000 strings from one memory location to another, and then displaying the last 20 or so, should take only a few ms, even on old hardware with long strings (yours are fairly short).

Title: Re: Very slow assigning a TStringList to a TMemo
Post by: trev on June 15, 2019, 03:57:24 pm

Definitely convinced:

Code: Pascal  [Select][+][-]

1.           strList.Sort;
2.  
3.           period := Time;
4.           BitsMemo.Lines.BeginUpdate;
5.           BitsMemo.Lines := strList;
6.           BitsMemo.Lines.EndUpdate;
7.           ts := DateTimeToTimeStamp(Time - period);
8.           BitsMemo.Lines.Add('Operation took %d ms',[ts.Time]);
9.  

The hardware is a 2018 Mac mini with six-core 3.2-4.6GHz i7, so not old or slow :)

I'll go pester the Cocoa widget magician tomorrow.

Title: Re: Very slow assigning a TStringList to a TMemo
Post by: marcov on June 15, 2019, 04:05:02 pm

The code looks ok.

I'd do a

 BitsMemo.Lines.Assign(strList);

but that is not the problem I think.

Note GUI widgets might not react very well to huge amounts of items, depending on widgetset and implementation.

Title: Re: Very slow assigning a TStringList to a TMemo
Post by: ASerge on June 15, 2019, 09:41:38 pm

In Windows the fastes way is Memo.Text := StringList.Text

Title: Re: Very slow assigning a TStringList to a TMemo
Post by: trev on June 16, 2019, 01:29:33 am

Quote from: ASerge on June 15, 2019, 09:41:38 pm

In Windows the fastes way is Memo.Text := StringList.Text

Also in macOS  8-) Thankyou! See pic.

Title: Re: Very slow assigning a TStringList to a TMemo
Post by: Thaddy on June 16, 2019, 06:02:05 am

Quote from: ASerge on June 15, 2019, 09:41:38 pm

In Windows the fastes way is Memo.Text := StringList.Text

That's what I thought too, but note Marco's remark about assign. Internally the assignment := operator calls Assign, so that may be a little faster...

Title: Re: [Solved] Very slow assigning a TStringList to a TMemo
Post by: trev on June 16, 2019, 10:15:50 am

For the record:

Code: [Select]

BitsMemo.Lines.Assign(strList);

Operation took 28067 ms

Title: Re: [Solved] Very slow assigning a TStringList to a TMemo
Post by: Thaddy on June 16, 2019, 10:45:38 am

That is unexpected? Anyway in that case my first hunch was right.

Title: Re: Very slow assigning a TStringList to a TMemo
Post by: Remy Lebeau on June 18, 2019, 10:43:20 pm

Quote from: howardpc on June 15, 2019, 11:01:48 am

Code: Pascal  [Select][+][-]

1. Memo1.Lines.BeginUpdate;
2. Memo1.Lines := strList;
3. Memo1.Lines.EndUpdate;

I would expect the Lines property setter to call (Begin|End)Update() internally.  It does in Delphi (which simply calls FLines.Assign(), and then TStrings.Assign() handles the updating).

Quote from: howardpc on June 15, 2019, 11:01:48 am

Code: Pascal  [Select][+][-]

1. Memo1.SelStart := Length(Memo1.Text);

I would use the TMemo.GetTextLen() method instead of querying the Length of the Text property.  That way, it avoids having to actually read the full Text into memory first.

Code: Pascal  [Select][+][-]

1. Memo1.SelStart := Memo1.GetTextLen;