Forum > LCL

GetControlClassDefaultSize changed since rev. 25204

(1/2) > >>

Zoran:
Virtual class function TControl.GetControlClassDefaultSize seems to be changed in recent revision 25204, so that it's type is TSize instead of TPoint.

TSize and TPoint types are almost the same, so is there any improvement in this change? Code which calls it does not compile, and controls which override this function cannot compile.

Is this change nesessery? I admit that it is not too difficult to adjust the code, but... it breaks backwards compatibility, which is annoying.

Marc:
I guess it was needed somehow. And when changing, better do it now than when we reach 1.0

zeljko:
It's changed in r25204 by Paul, there's no explanation in svn log why it is so, I suppose it's for Delphi compatibility.

Zoran:

--- Quote from: Marc on May 05, 2010, 10:05:08 pm ---I guess it was needed somehow. And when changing, better do it now than when we reach 1.0

--- End quote ---

I agree, if it was needed somehow...


--- Quote from: zeljko on May 06, 2010, 05:52:33 am ---I suppose it's for Delphi compatibility.

--- End quote ---

Probably not -- Google on GetControlClassDefaultSize returns only Lazarus pages, so this function probably doesn't exist in Delphi.

Paul Ishenin:
Sorry for the change. We expected that it is not used anywhere outside LCL. There was no big need in the change except to use proper existing type for the size - TSize. TPoint should be used for coordinates return, not the size.

Navigation

[0] Message Index

[#] Next page

Go to full version