Recent

Author Topic: BidiMode improvments patch  (Read 6207 times)

Zaher

  • Hero Member
  • *****
  • Posts: 571
    • parmaja.com
BidiMode improvments patch
« on: May 24, 2009, 03:14:59 pm »
I know i touch a sensitive code but we can discuss about it.

Added TVisualCompont it is between TLCLComponent and and TControl, it has a properties and methods that have visual effect but still it unvisible at form. i will use it for BidiMode and ParentBidimode
TMenu, TPopupMenu, TScreen, TTrayIcon and TPopupNotifier and any component need bidimode , TTheme and TToolbar...

Now it can detect if the Component was inherited from TVisualComponent to make loop when BidiMode changed in the form/control.

Remove duplicating of implement the same code in both TControl and TMenu and every TComponent need the BidiMode.

I kept UseRightToLeftScrollBar in TControl

Added BidiMode to TApplication.

TApplicationProperties must *not* inherite it from TVisualComponent it is like TApplication have no ParentBidiMode

I used the forum for my patch, because i like to edit my posts, but i can use Mail-List if you wish.

Paul Ishenin

  • Sr. Member
  • ****
  • Posts: 274
Re: BidiMode improvments patch
« Reply #1 on: May 24, 2009, 04:47:29 pm »
I would leave class hierarchi as is. No idea what other developers think.

Zaher

  • Hero Member
  • *****
  • Posts: 571
    • parmaja.com
Re: BidiMode improvments patch
« Reply #2 on: May 24, 2009, 04:58:44 pm »
I can merge of BidiMode the into TLCLComponent.

Vincent Snijders

  • Administrator
  • Hero Member
  • *
  • Posts: 2661
    • My Lazarus wiki user page
Re: BidiMode improvments patch
« Reply #3 on: May 24, 2009, 07:11:48 pm »
For discussion with all developers, the mailing list is a better platform.

Zaher

  • Hero Member
  • *****
  • Posts: 571
    • parmaja.com
Re: BidiMode improvments patch
« Reply #4 on: May 24, 2009, 11:20:48 pm »
Ok, I will repost the patch and my post in mail the list.

Zaher

  • Hero Member
  • *****
  • Posts: 571
    • parmaja.com
Re: BidiMode improvments patch
« Reply #5 on: May 25, 2009, 05:11:11 pm »
I posted to mail list and there is a changes in the patch, and more touch sensitive code :P .

Thanks