[SOLVED] TimeStampToMSecs function returns an invalid value on win32

[korba812]

I just updated the win32 compiler (trunk) and noticed that timestamp database fields are incorrectly displayed. After analysis, the problem is TimeStampToMSecs function, which returns an invalid value. However, if I modify this function and use a constant cast to Int64 type then function returns correct value.

Code: Pascal  [Select][+][-]

1. program Project1;
2.  
3. uses
4.   SysUtils;
5.  
6. // from Sysutils.TimeStampToMSecs
7. function TimeStampToMSecs1(const TimeStamp: TTimeStamp): Int64;
8. begin
9.   result := TimeStamp.Time + timestamp.date * msecsperday;
10. end;
11.  
12. function TimeStampToMSecs2(const TimeStamp: TTimeStamp): Int64;
13. begin
14.   result := TimeStamp.Time + timestamp.date * Int64(msecsperday);
15. end;
16.  
17. var
18.   TS: TTimeStamp = (Time: 40811000; Date: 738998);
19.  
20. begin
21.   WriteLn(TimeStampToMSecs1(TS));
22.   WriteLn(TimeStampToMSecs2(TS));
23.   ReadLn;
24. end.
25.  

Where does the problem lie? Compiler bug or lack of casting in the TimeStampToMSecs function?

[alpine]

Where does the problem lie? Compiler bug or lack of casting in the TimeStampToMSecs function?

Arithmetic overflow into the first one. Obviously it is the casting.

BTW, compiler gives a hint:
project1.lpr(9,10) Hint: Converting the operands to "Int64" before doing the add could prevent overflow errors.

[korba812]

Ah, now I see. I just checked the stable release sources and there TimeStampToMSecs function returns a value of comp type. In trunk it has been changed to Int64 and indeed requires a cast. I will report this in the bugtraker.

..edit..

The problem has already been solved in trunk, and I accidentally use old sources... Sorry for the noise.