Is "FPC_FULLVERSION" not configured properly in some builds?

[TRon]

Isn't FPC_FULLVERSION not just a constant in FPC ???

Can't be, it's not documented.

https://www.freepascal.org/docs-html/current/rtl/index-8.html#SECTIONF

afaik it is not a constant. It is documented here and is actually a number (to be able to compare versions). Or you can use include

[rvk]

How does writeln(FPC_FULLVERSION) work then?

Where does FPC_FULLVERSION come from if it's only a define.
(I can't use any other defines like that)

O, forget my question.
It's a macro.
What line only works if macros is on ( {$MACRO ON}  ).

[Thaddy]

You do not need a macro, just a little compiler internals...

[qk]

Probably it means that some trunk change was merged back to the fixes (3.2.x ) branch, probably during the big merges of december. The $if needs to be adapted for that.

+1

My two cents, it might be sufficient to replace all occurrences of

Code: Pascal  [Select][+][-]

1. {$IF FPC_FULLVERSION<30301}

with

Code: Pascal  [Select][+][-]

1. {$IF FPC_FULLVERSION<30203}

into BGRABitmap and BGRAControls packages.

It seems to work.
Regards

The issue has already been reported and resolved in the development branch in that manner. 

[MarkMLl]

You do not need a macro, just a little compiler internals...

Does that expand FPC_FULLVERSION, which is what I asked?

MarkMLl

[Thaddy]

My code expands much more precise than the version macro.
E.g. the FULL_VERSION omits version data related to GIT and it omits the compiler build date and platform.
These are essential information if you are working with - or on - trunk/main.
But the normal approach would be the macro approach. If that is enough for you, use the macro.

[MarkMLl]

My code expands much more precise than the version macro.
E.g. the FULL_VERSION omits version data related to GIT and it omits the compiler build date and platform.
These are essential information if you are working with - or on - trunk/main.
But the normal approach would be the macro approach. If that is enough for you, use the macro.

Don't care about git etc., hence doesn't answer my question.

Sorry for generating noise.

MarkMLl

[rvk]

My code expands much more precise than the version macro.
E.g. the FULL_VERSION omits version data related to GIT and it omits the compiler build date and platform.

Mine (fresh from gitlab) doesn't show revision or git info (only compile date):

Result with fixes 3_0: FPC 3.2.3 [2024/02/26] for x86_64 - Win64
Result with trunk: FPC 3.3.1 [2024/02/27] for x86_64 - Win64

I'm not sure where your "FPC 3.3.1-15198-g71a46465c8-dirty [2024/02/19] for" comes from.

[cdbc]

Hi
The 'dirty' is a giveaway for FpcUpDeluxe compiled
Regards Benny

[Thaddy]

Mine shows today:
FPC 3.3.1-15286-g1966ce7c1c [2024/02/26] for x86_64 - Win64
Fresh from gitlab
and FPC 3.3.1-15286-g1966ce7c1c [2024/02/26] for x86_64 - Linux

[Thaddy]

Hi
The 'dirty' is a giveaway for FpcUpDeluxe compiled
Regards Benny

No it indicates my local repository is not clean. IOW code is compiled with my local changes.

That does not say that fpcupdeluxe can not have the same result.
And it can very well be that fpcupdeluxe adds the git info.

An older box gives me:
FPC 3.2.2+dfsg-20 [2023/03/30] for x86_64 - Linux
Which is at least also more informative than the macro.

In the past I also had code that the svn revision added to my builds (as per this forum and feature requests.

[rvk]

Mine shows today:
FPC 3.3.1-15286-g1966ce7c1c [2024/02/26] for x86_64 - Win64
Fresh from gitlab
and FPC 3.3.1-15286-g1966ce7c1c [2024/02/26] for x86_64 - Linux

Weird. Mine does not show the revision.
Even the freshly compiled fpc gives:

Free Pascal Compiler version 3.3.1 [2024/02/27] for x86_64
Copyright (c) 1993-2024 by Florian Klaempfl and others

How do you download from gitlab?? And where is this added?? (In which file)

I download with: "git clone https://gitlab.com/freepascal.org/fpc/source.git fpc"
Am I missing a step?

I also don't recognize the revision 15286 (which kinda looks like the old github numbering).
Gitlab uses numbers like "revision 8b400339".

[rvk]

Ha, I already see it in version.pas

Code: Pascal  [Select][+][-]

1. function full_version_string:string;
2. begin
3.   full_version_string := version_nr+'.'+release_nr+'.'+patch_nr+minorpatch
4. {$ifdef REVINC}
5.   +'-'+{$i revision.inc}
6. {$endif REVINC}
7.   ;
8. end;
9.  

So you have REVINC defined. I have not.
It's default seems to be off.
There also doesn't seem to be a revision.inc on gitlab.

[rvk]

Mine shows today:
FPC 3.3.1-15286-g1966ce7c1c [2024/02/26] for x86_64 - Win64
Fresh from gitlab
and FPC 3.3.1-15286-g1966ce7c1c [2024/02/26] for x86_64 - Linux

So you need to add REVINC=1 (or force) and REVSTR=<revision number> yourself during compilation of FPC.

"git describe" will give the correct revision.
3.3.1-15293-g8b40033964

I'll add it to my script 

[Thaddy]

Indeed, that's how I do it. (with revinc=force)