Improvement request

[440bx]

Hello,

FPC v3.2.2 currently emits an "Error: Illegal expression" message when it encounters an assignment statement with a missing ":", i.e,

Code: Pascal  [Select][+][-]

1. SomeVar = avalue;   { illegal expression - note missing ":" }

This is an easy mistake to make when porting C code to Pascal.  More often than not, the cause of the problem is evident (the missing ":") but, on occasion, after porting many lines of code, the reason can be overlooked resulting in a waste of time.

The request is therefore: if at all possible improve the error message to something along the lines of "possible ":" missing in assignment statement" or something along those lines.

Thank you.

[Kays]

The word note is in the imperative mood. “Pay attention!” Maybe you can’t see it but there ain’t no colon.

Your wording on the other hand is pretty suggestive. We don’t know what’s missing; there are multiple valid hypotheses.

[440bx]

there are multiple valid hypotheses.

My hypothesis is that you should follow Lincoln's advice.  It would serve you well.

[Leledumbo]

The request is therefore: if at all possible improve the error message to something along the lines of "possible ":" missing in assignment statement" or something along those lines.

In theory, it should be possible, as an explicitly handled case, like this one where it specifically handles proc():=. In this case, instead of falling into an else clause of a case statement, a case to handle _EQ should be added.

[Thaddy]

That is not an improvement, it is a fallacy.
"Fixing" mistakes by changing syntax is a mistake.
Not to mention that assignment does not  equal equality.
The same is the case in C , = vs ==. so shut up is the most kind expression I could find.

[xixixi]

I think it's a great improvement. If the statement is an (illegal) equality expression, a note could be added to "Illegal expression", like "Did you mean an assignment ':='?".

[440bx]

That is not an improvement, it is a fallacy.

You and Kay should get a room... make each other happy <chuckle>

[Thaddy]

That is not an improvement, it is a fallacy.

You and Kay should get a room... make each other happy <chuckle>

And you should be able to distinguish between assignment and comparison.

[dbannon]

Oh, come on, 440bx is not suggesting the compiler should go off and edit your source or anything like that. Just issue a more meaningful message. One that would be more helpful in the vast majority of cases.

Davo