[SOLVED] StringToHex might not return a result

[lagprogramming]

packages/fcl-hash/src/fphashutils.pp has the following function

Code: Pascal  [Select][+][-]

1. function StringToHex(const s: ansistring): ansistring;
2. begin
3.   if s='' then exit;
4.   BytesToHexStr(Result,@s[1],length(s));
5. end;

The code of this function might not assign a result.

[domasz]

Seems someone forgot 3 chars

Code: Pascal  [Select][+][-]

1.     function StringToHex(const s: ansistring): ansistring;
2.     begin
3.       if s='' then exit(s);
4.       BytesToHexStr(Result,@s[1],length(s));
5.     end;

[lagprogramming]

Seems someone forgot 3 chars

Code: Pascal  [Select][+][-]

1.     function StringToHex(const s: ansistring): ansistring;
2.     begin
3.       if s='' then exit(s);
4.       BytesToHexStr(Result,@s[1],length(s));
5.     end;

Maybe 4: exit('');
Edit: Should this function be allowed to return an empty string?  We'll see.

[Thaddy]

That is flawed indeed, use syutils and the helper ToHexString.

[AlexTP]

Posted to https://gitlab.com/freepascal.org/fpc/source/-/issues/40388