[SOLVED] Modification of TCDEdit's destructor

[lagprogramming]

lcl/customdrawncontrols.pas has the following destructor:

Code: Pascal  [Select][+][-]

1. destructor TCDEdit.Destroy;
2. begin
3.   inherited Destroy;
4.   FLines.Free;
5.   //FCaretTimer.Free; Don't free here because it is assigned with a owner
6. end;

inherited Destroy; is followed by a FLines.Free; line, where FLines is a TStringList.
The following patch modifies the destructor in order to free FLines before inherited Destroy;.

Code: Pascal  [Select][+][-]

1. diff --git a/lcl/customdrawncontrols.pas b/lcl/customdrawncontrols.pas
2. index d9b6bb2035..2b852abf5c 100644
3. --- a/lcl/customdrawncontrols.pas
4. +++ b/lcl/customdrawncontrols.pas
5. @@ -2044,8 +2044,8 @@ end;
6.  
7.  destructor TCDEdit.Destroy;
8.  begin
9. -  inherited Destroy;
10.    FLines.Free;
11. +  inherited Destroy;
12.    //FCaretTimer.Free; Don't free here because it is assigned with a owner
13.  end;

[Zvoni]

Interesting.
I was always under the impression, that Inherited Destroy; should always be called last in your own destructor  (meaning cleaning up your own mess before .... )

[AlexTP]

Posted to https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/40387