Can't place ATBinHex on form

[domasz]

I installed ATBinHex using Online Package Manager. I installed other packages that way and they work fine.
When I try to place ATBINHex on a form I get error:

Error moving component ATBinHex1: ATBinHex

My lazarus:
Lazarus 2.2.2 (rev lazarus_2_2_2) FPC 3.2.2 x86_64-win64-win32/win64

[balazsszekely]

@domasz

Next time please do the following:

1. Build Lazarus with profile Debug IDE
2. Open package atbinhex_package.lpk, go to Compiler Option->Custom Option. Add $(IDEBuildOptions) to options, so you can debug the package
3. Open lazarus.lpi(IDE folder) then run the project, this will open another instance of Lazarus
4. Drop a TATBinHex component to the form, the first instance will break
5. Open Edit->Debug Window->Call Stack, notice that the issue originates from TATBinHex Redraw method(see attached image)
6. Redraw will call method HideScrollbars, which internally will call a ChangeBound, which will fail because no parent window is available at this moment.  A possible solution is to check if parent is nil:

Code: Pascal  [Select][+][-]

1. procedure TATBinHex.HideScrollbars;
2. var
3.   si: TScrollInfo;
4. begin
5.   if Self.Parent = nil then //<-- add this
6.     Exit; //and this
7.   FillChar(si, SizeOf(si), 0);
8.   with si do
9.   begin
10.     cbSize := SizeOf(si);
11.     fMask := SIF_ALL;
12.   end;
13.   SetScrollInfo(Handle, SB_VERT, si, True);
14.   SetScrollInfo(Handle, SB_HORZ, si, True);
15. end;

7. Create a patch and report your findings to forum user AlexTP, so he can fix it on githbuh(https://github.com/Alexey-T/ATBinHex-Lazarus)
8. After the package is fixed, I can update in OPM

[domasz]

Thanks, GetMem!

[AlexTP]

Applied the fix to Github.
Next time, please ping me on Github! I don't always read here.

[balazsszekely]

I also updated the OPM repository.

[domasz]

Thank you both.
I thought the problem is on my end, something in my not-so-latest Lazarus or in configuration. That's why I didn't just write to AlexTP.