Lazarus
Home
Help
TinyPortal
Search
Login
Register
Lazarus
»
Forum
»
Programming
»
LCL
»
TSynEdit crashes when loading text
Free Pascal
Website
Downloads
Wiki
Documentation
Bugtracker
Mailing List
Lazarus
Website
Downloads (Laz+FPC)
Packages (OPM)
FAQ
Wiki
Documentation (RTL/FCL/LCL)
Bugtracker
CCR Bugs
IRC channel
GIT
Mailing List
Other languages
Foundation
Website
Useful Wiki Links
Project Roadmap
Getting the Source
Screenshots
How to use the forum
About donations (wiki)
Bookstore
Computer Math and Games in Pascal
(preview)
Lazarus Handbook
Search
Advanced search
Recent
Question for people who h...
by
BrassGear
[
Today
at 11:12:50 am]
how to see what command s...
by
Key-Real
[
Today
at 11:12:48 am]
Warning: Source OS Redefi...
by
Key-Real
[
Today
at 11:07:49 am]
I just released a commerc...
by
BrassGear
[
Today
at 11:05:12 am]
How to: create DLL file f...
by
KodeZwerg
[
Today
at 10:53:20 am]
Assign (textfile) not com...
by
Thaddy
[
Today
at 10:51:18 am]
Text orientation in TMemo...
by
wp
[
Today
at 10:27:54 am]
InstallAware Using Lazaru...
by
marcov
[
Today
at 10:05:26 am]
Slow copying of small str...
by
Nitorami
[
Today
at 09:43:56 am]
Linux Workspaces -- StayO...
by
AmatCoder
[
Today
at 08:21:27 am]
Demoscene The Champs Crac...
by
Lulu
[
Today
at 08:15:12 am]
Azure sql database will n...
by
paweld
[
Today
at 07:24:47 am]
Find child controls by na...
by
Handoko
[
Today
at 04:17:05 am]
location of non visual co...
by
VisualLab
[April 17, 2024, 11:58:55 pm]
For-in loop over constant...
by
Joanna
[April 17, 2024, 11:57:15 pm]
Lazarus editor feature re...
by
440bx
[April 17, 2024, 11:49:08 pm]
How would you define a fi...
by
wp
[April 17, 2024, 11:04:00 pm]
Directx9 with mylogo insi...
by
KodeZwerg
[April 17, 2024, 11:03:54 pm]
Lazarus for Windows on aa...
by
Wallaby
[April 17, 2024, 10:25:46 pm]
[SOLVED] TDbf table, Leve...
by
1HuntnMan
[April 17, 2024, 10:03:16 pm]
Doomed name
by
Martin_fr
[April 17, 2024, 09:09:52 pm]
lazarus-project_3.2.0-0_a...
by
midigark
[April 17, 2024, 06:09:40 pm]
TBGRABitmap.TextSize retu...
by
circular
[April 17, 2024, 05:24:04 pm]
BUG REPORT: Unable to gen...
by
gasensor
[April 17, 2024, 05:10:20 pm]
[solved]FP IDE(FP.exe) fa...
by
gasensor
[April 17, 2024, 04:45:40 pm]
« previous
next »
Print
Pages: [
1
]
Author
Topic: TSynEdit crashes when loading text (Read 1175 times)
domasz
Sr. Member
Posts: 435
TSynEdit crashes when loading text
«
on:
June 01, 2023, 08:13:29 pm »
When I click this button twice the program crashes. Might be something with highlighters (TSynMultiSyn, TSynPHPSyn, TSynHTMLSyn).
Code: Pascal
[Select]
[+]
[-]
procedure
TForm1
.
Button1Click
(
Sender
:
TObject
)
;
var
Str
:
String
;
L
:
TStringList
;
begin
L
:
=
TStringList
.
Create
;
L
.
LoadFromFile
(
'test.htm'
)
;
Str
:
=
L
.
Text
;
L
.
Free
;
SynEdit1
.
Text
:
=
Str
;
//crashes
end
;
Code: Pascal
[Select]
[+]
[-]
object
SynMultiSyn1
:
TSynMultiSyn
Enabled
=
False
Schemes
=
<
item
StartExpr
=
'<style>'
EndExpr
=
'</style>'
Highlighter
=
SynCssSyn1
MarkerAttri
.
Background
=
clNone
MarkerAttri
.
Foreground
=
16744448
end
item
StartExpr
=
'<\?php'
EndExpr
=
'\?>'
Highlighter
=
SynPHPSyn1
MarkerAttri
.
Background
=
clNone
MarkerAttri
.
Foreground
=
16512
end>
DefaultHighlighter
=
SynHTMLSyn1
Left
=
592
Top
=
40
end
Attached is super simple demo.
Logged
Martin_fr
Administrator
Hero Member
Posts: 9864
Debugger - SynEdit - and more
Re: TSynEdit crashes when loading text
«
Reply #1 on:
June 01, 2023, 08:25:21 pm »
I can reproduce...
It seems something in the Multi-HL. Not sure yet
Logged
From the wiki:
Ide Tools, Code completion and more
/
IDE cool features
/
Debugger Status
Martin_fr
Administrator
Hero Member
Posts: 9864
Debugger - SynEdit - and more
Re: TSynEdit crashes when loading text
«
Reply #2 on:
June 01, 2023, 08:30:46 pm »
Ideally report on the bug tracker please
Logged
From the wiki:
Ide Tools, Code completion and more
/
IDE cool features
/
Debugger Status
domasz
Sr. Member
Posts: 435
Re: TSynEdit crashes when loading text
«
Reply #3 on:
June 01, 2023, 08:35:39 pm »
Quote from: Martin_fr on June 01, 2023, 08:30:46 pm
Ideally report on the bug tracker please
Not sure if I did it right. Don't know how to post files there.
https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/40292
Logged
Martin_fr
Administrator
Hero Member
Posts: 9864
Debugger - SynEdit - and more
Re: TSynEdit crashes when loading text
«
Reply #4 on:
June 01, 2023, 08:40:39 pm »
ok, thanks
Logged
From the wiki:
Ide Tools, Code completion and more
/
IDE cool features
/
Debugger Status
Martin_fr
Administrator
Hero Member
Posts: 9864
Debugger - SynEdit - and more
Re: TSynEdit crashes when loading text
«
Reply #5 on:
June 02, 2023, 07:34:05 pm »
A temporary patch. I still need to do some testing.
Code: Diff
[Select]
[+]
[-]
diff --git a/components/synedit/synhighlightermulti.pas b/components/synedit/synhighlightermulti.pas
index 1343e
5d554
..ca662dc37d
100644
--- a/components/synedit/synhighlightermulti.pas
+++ b/components/synedit/synhighlightermulti.pas
@@ -
845
,
22
+
845
,
22
@@ procedure TSynHLightMultiVirtualLines.RealLinesDeleted
(
AIndex, ACount: Integer
)
;
// Real-lines starting in the middle of the Section
CountInSection := Min
(
AIndex + ACount, p^.EndPos.y +
1
)
- AIndex;
FirstVLine := p^.VirtualLine + AIndex - p^.StartPos.y;
- PrevEndVLine := p^.VirtualLine + p^.EndPos.y - p^.EndPos.y;
+ PrevEndVLine := p^.VirtualLine + p^.EndPos.y - p^.StartPos.y;
p^.EndPos.y := p^.EndPos.y - CountInSection;
inc
(
i
)
;
if i = FSectionList.Count then begin
DelVLines;
exit;
end;
p := FSectionList.PSections
[
i
]
;
VLineCount := CountInSection;
end;
while p^.EndPos.y < AIndex + ACount do begin
// Completly delete node
(
All Real lines deleted
)
VLineCount := VLineCount + p^.EndPos.y - p^.StartPos.y +
1
;
if PrevEndVLine = p^.VirtualLine then
dec
(
VLineCount
)
;
- PrevEndVLine := p^.VirtualLine + p^.EndPos.y - p^.EndPos.y;
+ PrevEndVLine := p^.VirtualLine + p^.EndPos.y - p^.StartPos.y;
FSectionList.Delete
(
i
)
;
if i = FSectionList.Count then begin
DelVLines;
Logged
From the wiki:
Ide Tools, Code completion and more
/
IDE cool features
/
Debugger Status
domasz
Sr. Member
Posts: 435
Re: TSynEdit crashes when loading text
«
Reply #6 on:
June 02, 2023, 08:46:13 pm »
Seems to work great, thank you for such a quick fix!
I tried it with hundreds of files from real websites and I found no problems.
«
Last Edit: June 02, 2023, 09:55:33 pm by domasz
»
Logged
Martin_fr
Administrator
Hero Member
Posts: 9864
Debugger - SynEdit - and more
Re: TSynEdit crashes when loading text
«
Reply #7 on:
June 03, 2023, 09:37:47 pm »
Found a few other issues too. For patch, see the commit mentioned in the reported issue.
Logged
From the wiki:
Ide Tools, Code completion and more
/
IDE cool features
/
Debugger Status
Print
Pages: [
1
]
« previous
next »
Lazarus
»
Forum
»
Programming
»
LCL
»
TSynEdit crashes when loading text
TinyPortal
© 2005-2018