Lazarus
Home
Help
TinyPortal
Search
Login
Register
Lazarus
»
Forum
»
Programming
»
LCL
»
TSynEdit crashes when loading text
Free Pascal
Website
Downloads
Wiki
Documentation
Bugtracker
Mailing List
Lazarus
Website
Downloads (Laz+FPC)
Packages (OPM)
FAQ
Wiki
Documentation (RTL/FCL/LCL)
Bugtracker
CCR Bugs
IRC channel
GIT
Mailing List
Other languages
Foundation
Website
Useful Wiki Links
Project Roadmap
Getting the Source
Screenshots
How to use the forum
About donations (wiki)
Bookstore
Computer Math and Games in Pascal
(preview)
Lazarus Handbook
Search
Advanced search
Recent
Does anyone know why thes...
by
TYDQ
[
Today
at 02:36:08 pm]
Who is Indy mattias?
by
jollytall
[
Today
at 02:27:19 pm]
How to: create DLL file f...
by
TRon
[
Today
at 02:26:53 pm]
A fairly simple sound sol...
by
paweld
[
Today
at 01:46:11 pm]
Demoscene The Champs Crac...
by
KodeZwerg
[
Today
at 01:45:18 pm]
Database standards OR Am ...
by
paweld
[
Today
at 01:07:33 pm]
Access violation when ope...
by
Чебурашка
[
Today
at 12:27:34 pm]
Step-into the field sette...
by
Martin_fr
[
Today
at 11:31:48 am]
Access violation when re-...
by
Chris Osborne
[
Today
at 11:31:25 am]
AI, NLP and CAI: Text Gen...
by
Dzandaa
[
Today
at 11:03:26 am]
dwindows for Android
by
PierceNg
[
Today
at 10:54:44 am]
create system unit from s...
by
Laksen
[
Today
at 10:53:57 am]
how to get class and meth...
by
cdbc
[
Today
at 10:52:22 am]
[Solved] Find child contr...
by
Joanna
[
Today
at 09:53:43 am]
FpDebug unexpected Assemb...
by
Marc
[
Today
at 08:46:38 am]
Offical launch of the 1 B...
by
Handoko
[
Today
at 07:59:07 am]
Big Numbers Math
by
iLya2IK
[
Today
at 07:13:20 am]
Lazarus for Windows on aa...
by
dbannon
[
Today
at 07:02:55 am]
BUG REPORT: Unable to gen...
by
dbannon
[
Today
at 06:29:49 am]
what to do if my target M...
by
Laksen
[
Today
at 12:49:12 am]
For-in loop over constant...
by
ASerge
[
Today
at 12:36:09 am]
Converting a string/index...
by
TRon
[April 18, 2024, 11:56:37 pm]
exclude ALL packages from...
by
PascalDragon
[April 18, 2024, 11:33:29 pm]
Poll: Watches and Display...
by
440bx
[April 18, 2024, 10:55:14 pm]
Have anyone develop UEFI ...
by
PascalDragon
[April 18, 2024, 10:14:15 pm]
« previous
next »
Print
Pages: [
1
]
Author
Topic: TSynEdit crashes when loading text (Read 1181 times)
domasz
Sr. Member
Posts: 435
TSynEdit crashes when loading text
«
on:
June 01, 2023, 08:13:29 pm »
When I click this button twice the program crashes. Might be something with highlighters (TSynMultiSyn, TSynPHPSyn, TSynHTMLSyn).
Code: Pascal
[Select]
[+]
[-]
procedure
TForm1
.
Button1Click
(
Sender
:
TObject
)
;
var
Str
:
String
;
L
:
TStringList
;
begin
L
:
=
TStringList
.
Create
;
L
.
LoadFromFile
(
'test.htm'
)
;
Str
:
=
L
.
Text
;
L
.
Free
;
SynEdit1
.
Text
:
=
Str
;
//crashes
end
;
Code: Pascal
[Select]
[+]
[-]
object
SynMultiSyn1
:
TSynMultiSyn
Enabled
=
False
Schemes
=
<
item
StartExpr
=
'<style>'
EndExpr
=
'</style>'
Highlighter
=
SynCssSyn1
MarkerAttri
.
Background
=
clNone
MarkerAttri
.
Foreground
=
16744448
end
item
StartExpr
=
'<\?php'
EndExpr
=
'\?>'
Highlighter
=
SynPHPSyn1
MarkerAttri
.
Background
=
clNone
MarkerAttri
.
Foreground
=
16512
end>
DefaultHighlighter
=
SynHTMLSyn1
Left
=
592
Top
=
40
end
Attached is super simple demo.
Logged
Martin_fr
Administrator
Hero Member
Posts: 9868
Debugger - SynEdit - and more
Re: TSynEdit crashes when loading text
«
Reply #1 on:
June 01, 2023, 08:25:21 pm »
I can reproduce...
It seems something in the Multi-HL. Not sure yet
Logged
From the wiki:
Ide Tools, Code completion and more
/
IDE cool features
/
Debugger Status
Martin_fr
Administrator
Hero Member
Posts: 9868
Debugger - SynEdit - and more
Re: TSynEdit crashes when loading text
«
Reply #2 on:
June 01, 2023, 08:30:46 pm »
Ideally report on the bug tracker please
Logged
From the wiki:
Ide Tools, Code completion and more
/
IDE cool features
/
Debugger Status
domasz
Sr. Member
Posts: 435
Re: TSynEdit crashes when loading text
«
Reply #3 on:
June 01, 2023, 08:35:39 pm »
Quote from: Martin_fr on June 01, 2023, 08:30:46 pm
Ideally report on the bug tracker please
Not sure if I did it right. Don't know how to post files there.
https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/40292
Logged
Martin_fr
Administrator
Hero Member
Posts: 9868
Debugger - SynEdit - and more
Re: TSynEdit crashes when loading text
«
Reply #4 on:
June 01, 2023, 08:40:39 pm »
ok, thanks
Logged
From the wiki:
Ide Tools, Code completion and more
/
IDE cool features
/
Debugger Status
Martin_fr
Administrator
Hero Member
Posts: 9868
Debugger - SynEdit - and more
Re: TSynEdit crashes when loading text
«
Reply #5 on:
June 02, 2023, 07:34:05 pm »
A temporary patch. I still need to do some testing.
Code: Diff
[Select]
[+]
[-]
diff --git a/components/synedit/synhighlightermulti.pas b/components/synedit/synhighlightermulti.pas
index 1343e
5d554
..ca662dc37d
100644
--- a/components/synedit/synhighlightermulti.pas
+++ b/components/synedit/synhighlightermulti.pas
@@ -
845
,
22
+
845
,
22
@@ procedure TSynHLightMultiVirtualLines.RealLinesDeleted
(
AIndex, ACount: Integer
)
;
// Real-lines starting in the middle of the Section
CountInSection := Min
(
AIndex + ACount, p^.EndPos.y +
1
)
- AIndex;
FirstVLine := p^.VirtualLine + AIndex - p^.StartPos.y;
- PrevEndVLine := p^.VirtualLine + p^.EndPos.y - p^.EndPos.y;
+ PrevEndVLine := p^.VirtualLine + p^.EndPos.y - p^.StartPos.y;
p^.EndPos.y := p^.EndPos.y - CountInSection;
inc
(
i
)
;
if i = FSectionList.Count then begin
DelVLines;
exit;
end;
p := FSectionList.PSections
[
i
]
;
VLineCount := CountInSection;
end;
while p^.EndPos.y < AIndex + ACount do begin
// Completly delete node
(
All Real lines deleted
)
VLineCount := VLineCount + p^.EndPos.y - p^.StartPos.y +
1
;
if PrevEndVLine = p^.VirtualLine then
dec
(
VLineCount
)
;
- PrevEndVLine := p^.VirtualLine + p^.EndPos.y - p^.EndPos.y;
+ PrevEndVLine := p^.VirtualLine + p^.EndPos.y - p^.StartPos.y;
FSectionList.Delete
(
i
)
;
if i = FSectionList.Count then begin
DelVLines;
Logged
From the wiki:
Ide Tools, Code completion and more
/
IDE cool features
/
Debugger Status
domasz
Sr. Member
Posts: 435
Re: TSynEdit crashes when loading text
«
Reply #6 on:
June 02, 2023, 08:46:13 pm »
Seems to work great, thank you for such a quick fix!
I tried it with hundreds of files from real websites and I found no problems.
«
Last Edit: June 02, 2023, 09:55:33 pm by domasz
»
Logged
Martin_fr
Administrator
Hero Member
Posts: 9868
Debugger - SynEdit - and more
Re: TSynEdit crashes when loading text
«
Reply #7 on:
June 03, 2023, 09:37:47 pm »
Found a few other issues too. For patch, see the commit mentioned in the reported issue.
Logged
From the wiki:
Ide Tools, Code completion and more
/
IDE cool features
/
Debugger Status
Print
Pages: [
1
]
« previous
next »
Lazarus
»
Forum
»
Programming
»
LCL
»
TSynEdit crashes when loading text
TinyPortal
© 2005-2018