Lazarus
Home
Help
TinyPortal
Search
Login
Register
Lazarus
»
Forum
»
Programming
»
LCL
»
TSynEdit crashes when loading text
Free Pascal
Website
Downloads
Wiki
Documentation
Bugtracker
Mailing List
Lazarus
Website
Downloads (Laz+FPC)
Packages (OPM)
FAQ
Wiki
Documentation (RTL/FCL/LCL)
Bugtracker
CCR Bugs
IRC channel
GIT
Mailing List
Other languages
Foundation
Website
Useful Wiki Links
Project Roadmap
Getting the Source
Screenshots
How to use the forum
About donations (wiki)
Bookstore
Computer Math and Games in Pascal
(preview)
Lazarus Handbook
Search
Advanced search
Recent
A question on Modula2 vs ...
by
Joanna
[
Today
at 01:36:43 am]
lamw
by
desconocido
[
Today
at 12:58:09 am]
Initiaiizing records by c...
by
Thaddy
[
Today
at 12:23:13 am]
scanline example
by
speter
[
Today
at 12:12:12 am]
android
by
desconocido
[
Today
at 12:03:24 am]
Best way to exchange data...
by
Hansvb
[March 18, 2024, 10:24:54 pm]
Pack
by
domasz
[March 18, 2024, 10:24:35 pm]
Fairtris 2: The Ultimate ...
by
furious programming
[March 18, 2024, 10:23:58 pm]
Here's some Pong game. Su...
by
Darie
[March 18, 2024, 10:22:49 pm]
IsManagedType problem, do...
by
PascalDragon
[March 18, 2024, 10:05:44 pm]
Conflict when static link...
by
tetrastes
[March 18, 2024, 10:05:28 pm]
Indeed TCustomApplication...
by
PascalDragon
[March 18, 2024, 10:00:49 pm]
"fpc.cfg is missing" (not...
by
AxBen
[March 18, 2024, 09:50:52 pm]
Interesting discovery wit...
by
wp
[March 18, 2024, 09:11:23 pm]
Use Lazarus 3.2 with FPC ...
by
AxBen
[March 18, 2024, 08:56:42 pm]
More Normal Mode for Laza...
by
RayoGlauco
[March 18, 2024, 08:55:53 pm]
How to make a watermarked...
by
loaded
[March 18, 2024, 08:37:24 pm]
Introducing a "using" key...
by
VisualLab
[March 18, 2024, 08:26:22 pm]
Code completion items
by
Martin_fr
[March 18, 2024, 08:26:17 pm]
Poll: Watches and Display...
by
Martin_fr
[March 18, 2024, 07:36:59 pm]
[Solved] Help with sql
by
Zvoni
[March 18, 2024, 05:46:32 pm]
TBGRABitmap.TextSize retu...
by
circular
[March 18, 2024, 04:40:11 pm]
Еличка - a simple calcula...
by
gidesa
[March 18, 2024, 04:16:43 pm]
Combined pointer style
by
wp
[March 18, 2024, 03:42:17 pm]
LazBuild console programm...
by
TRon
[March 18, 2024, 03:19:25 pm]
« previous
next »
Print
Pages: [
1
]
Author
Topic: TSynEdit crashes when loading text (Read 1153 times)
domasz
Sr. Member
Posts: 413
TSynEdit crashes when loading text
«
on:
June 01, 2023, 08:13:29 pm »
When I click this button twice the program crashes. Might be something with highlighters (TSynMultiSyn, TSynPHPSyn, TSynHTMLSyn).
Code: Pascal
[Select]
[+]
[-]
procedure
TForm1
.
Button1Click
(
Sender
:
TObject
)
;
var
Str
:
String
;
L
:
TStringList
;
begin
L
:
=
TStringList
.
Create
;
L
.
LoadFromFile
(
'test.htm'
)
;
Str
:
=
L
.
Text
;
L
.
Free
;
SynEdit1
.
Text
:
=
Str
;
//crashes
end
;
Code: Pascal
[Select]
[+]
[-]
object
SynMultiSyn1
:
TSynMultiSyn
Enabled
=
False
Schemes
=
<
item
StartExpr
=
'<style>'
EndExpr
=
'</style>'
Highlighter
=
SynCssSyn1
MarkerAttri
.
Background
=
clNone
MarkerAttri
.
Foreground
=
16744448
end
item
StartExpr
=
'<\?php'
EndExpr
=
'\?>'
Highlighter
=
SynPHPSyn1
MarkerAttri
.
Background
=
clNone
MarkerAttri
.
Foreground
=
16512
end>
DefaultHighlighter
=
SynHTMLSyn1
Left
=
592
Top
=
40
end
Attached is super simple demo.
Logged
Martin_fr
Administrator
Hero Member
Posts: 9754
Debugger - SynEdit - and more
Re: TSynEdit crashes when loading text
«
Reply #1 on:
June 01, 2023, 08:25:21 pm »
I can reproduce...
It seems something in the Multi-HL. Not sure yet
Logged
From the wiki:
Ide Tools, Code completion and more
/
IDE cool features
/
Debugger Status
Martin_fr
Administrator
Hero Member
Posts: 9754
Debugger - SynEdit - and more
Re: TSynEdit crashes when loading text
«
Reply #2 on:
June 01, 2023, 08:30:46 pm »
Ideally report on the bug tracker please
Logged
From the wiki:
Ide Tools, Code completion and more
/
IDE cool features
/
Debugger Status
domasz
Sr. Member
Posts: 413
Re: TSynEdit crashes when loading text
«
Reply #3 on:
June 01, 2023, 08:35:39 pm »
Quote from: Martin_fr on June 01, 2023, 08:30:46 pm
Ideally report on the bug tracker please
Not sure if I did it right. Don't know how to post files there.
https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/40292
Logged
Martin_fr
Administrator
Hero Member
Posts: 9754
Debugger - SynEdit - and more
Re: TSynEdit crashes when loading text
«
Reply #4 on:
June 01, 2023, 08:40:39 pm »
ok, thanks
Logged
From the wiki:
Ide Tools, Code completion and more
/
IDE cool features
/
Debugger Status
Martin_fr
Administrator
Hero Member
Posts: 9754
Debugger - SynEdit - and more
Re: TSynEdit crashes when loading text
«
Reply #5 on:
June 02, 2023, 07:34:05 pm »
A temporary patch. I still need to do some testing.
Code: Diff
[Select]
[+]
[-]
diff --git a/components/synedit/synhighlightermulti.pas b/components/synedit/synhighlightermulti.pas
index 1343e
5d554
..ca662dc37d
100644
--- a/components/synedit/synhighlightermulti.pas
+++ b/components/synedit/synhighlightermulti.pas
@@ -
845
,
22
+
845
,
22
@@ procedure TSynHLightMultiVirtualLines.RealLinesDeleted
(
AIndex, ACount: Integer
)
;
// Real-lines starting in the middle of the Section
CountInSection := Min
(
AIndex + ACount, p^.EndPos.y +
1
)
- AIndex;
FirstVLine := p^.VirtualLine + AIndex - p^.StartPos.y;
- PrevEndVLine := p^.VirtualLine + p^.EndPos.y - p^.EndPos.y;
+ PrevEndVLine := p^.VirtualLine + p^.EndPos.y - p^.StartPos.y;
p^.EndPos.y := p^.EndPos.y - CountInSection;
inc
(
i
)
;
if i = FSectionList.Count then begin
DelVLines;
exit;
end;
p := FSectionList.PSections
[
i
]
;
VLineCount := CountInSection;
end;
while p^.EndPos.y < AIndex + ACount do begin
// Completly delete node
(
All Real lines deleted
)
VLineCount := VLineCount + p^.EndPos.y - p^.StartPos.y +
1
;
if PrevEndVLine = p^.VirtualLine then
dec
(
VLineCount
)
;
- PrevEndVLine := p^.VirtualLine + p^.EndPos.y - p^.EndPos.y;
+ PrevEndVLine := p^.VirtualLine + p^.EndPos.y - p^.StartPos.y;
FSectionList.Delete
(
i
)
;
if i = FSectionList.Count then begin
DelVLines;
Logged
From the wiki:
Ide Tools, Code completion and more
/
IDE cool features
/
Debugger Status
domasz
Sr. Member
Posts: 413
Re: TSynEdit crashes when loading text
«
Reply #6 on:
June 02, 2023, 08:46:13 pm »
Seems to work great, thank you for such a quick fix!
I tried it with hundreds of files from real websites and I found no problems.
«
Last Edit: June 02, 2023, 09:55:33 pm by domasz
»
Logged
Martin_fr
Administrator
Hero Member
Posts: 9754
Debugger - SynEdit - and more
Re: TSynEdit crashes when loading text
«
Reply #7 on:
June 03, 2023, 09:37:47 pm »
Found a few other issues too. For patch, see the commit mentioned in the reported issue.
Logged
From the wiki:
Ide Tools, Code completion and more
/
IDE cool features
/
Debugger Status
Print
Pages: [
1
]
« previous
next »
Lazarus
»
Forum
»
Programming
»
LCL
»
TSynEdit crashes when loading text
TinyPortal
© 2005-2018