Lazarus
Home
Help
TinyPortal
Search
Login
Register
Lazarus
»
Forum
»
Programming
»
Widgetset
»
CustomDrawn
»
[SOLVED] class function TCDWSButton.GetText doesn't return a result
Free Pascal
Website
Downloads
Wiki
Documentation
Bugtracker
Mailing List
Lazarus
Website
Downloads (Laz+FPC)
Packages (OPM)
FAQ
Wiki
Documentation (RTL/FCL/LCL)
Bugtracker
CCR Bugs
IRC channel
GIT
Mailing List
Other languages
Foundation
Website
Useful Wiki Links
Project Roadmap
Getting the Source
Screenshots
How to use the forum
About donations (wiki)
Bookstore
Computer Math and Games in Pascal
(preview)
Lazarus Handbook
Search
Advanced search
Recent
how to tweek fpmake to co...
by
marcov
[
Today
at 08:29:16 pm]
A fairly simple sound sol...
by
VisualLab
[
Today
at 07:46:18 pm]
Quirky windows
by
ASerge
[
Today
at 07:07:16 pm]
Parameter passing odditie...
by
ASerge
[
Today
at 06:59:05 pm]
add new targets to make
by
Key-Real
[
Today
at 06:44:32 pm]
[Request] Demo Scene Sub ...
by
Gigatron
[
Today
at 06:29:39 pm]
Unlocking Files
by
KodeZwerg
[
Today
at 06:03:08 pm]
[SOLVED] trunk bug for mi...
by
Key-Real
[
Today
at 05:56:32 pm]
Demo Scene Bitmap Font Sc...
by
Gigatron
[
Today
at 05:56:27 pm]
Compile/Convert Delphi pr...
by
Martin_fr
[
Today
at 05:43:11 pm]
Generics - correct syntax
by
Thaddy
[
Today
at 05:40:59 pm]
Lazarus for Windows on aa...
by
msintle
[
Today
at 05:32:42 pm]
InstallAware Using Lazaru...
by
msintle
[
Today
at 05:26:36 pm]
Xcode Command Line Tools ...
by
Joseph
[
Today
at 05:16:39 pm]
Offical launch of the 1 B...
by
Hartmut
[
Today
at 04:49:29 pm]
what to do if my target M...
by
nickysn
[
Today
at 04:16:02 pm]
compiler error in unit
by
paule32
[
Today
at 03:49:50 pm]
Can function be used for ...
by
VisualLab
[
Today
at 02:15:30 pm]
Multithreading - synchron...
by
mika
[
Today
at 01:48:51 pm]
May be useful to somebody
by
KodeZwerg
[
Today
at 12:38:22 pm]
match automatic highlight...
by
Чебурашка
[
Today
at 11:35:14 am]
Tchart with dual numbers ...
by
wp
[
Today
at 10:48:18 am]
Debugger crashes with App...
by
Martin_fr
[
Today
at 09:29:46 am]
Copyrights Q
by
BrassGear
[
Today
at 09:13:14 am]
[SOLVED] how to build the...
by
Key-Real
[
Today
at 09:12:33 am]
« previous
next »
Print
Pages: [
1
]
Author
Topic: [SOLVED] class function TCDWSButton.GetText doesn't return a result (Read 1995 times)
lagprogramming
Sr. Member
Posts: 406
[SOLVED] class function TCDWSButton.GetText doesn't return a result
«
on:
March 27, 2023, 11:40:25 am »
lcl/interfaces/customdrawn/customdrawnwsstdctrls.pas contains the following function. It can be noticed that it doesn't return a result.
Code: Pascal
[Select]
[+]
[-]
class
function
TCDWSButton
.
GetText
(
const
AWinControl
:
TWinControl
;
var
AText
:
String
)
:
Boolean
;
var
lCDWinControl
:
TCDWinControl
;
begin
lCDWinControl
:
=
TCDWinControl
(
AWinControl
.
Handle
)
;
if
lCDWinControl
.
CDControl
=
nil
then
Exit
;
AText
:
=
TCDIntfButton
(
lCDWinControl
.
CDControl
)
.
Caption
;
end
;
New code mimics result assignment of class function TCDWSCustomEdit.GetText
Code: Pascal
[Select]
[+]
[-]
class
function
TCDWSButton
.
GetText
(
const
AWinControl
:
TWinControl
;
var
AText
:
String
)
:
Boolean
;
var
lCDWinControl
:
TCDWinControl
;
begin
Result
:
=
False
;
lCDWinControl
:
=
TCDWinControl
(
AWinControl
.
Handle
)
;
if
lCDWinControl
.
CDControl
=
nil
then
Exit
;
AText
:
=
TCDIntfButton
(
lCDWinControl
.
CDControl
)
.
Caption
;
Result
:
=
True
;
end
;
«
Last Edit: March 30, 2023, 06:21:01 pm by lagprogramming
»
Logged
Bart
Hero Member
Posts: 5290
Re: class function TCDWSButton.GetText doesn't return a result
«
Reply #1 on:
March 27, 2023, 11:59:12 am »
Please report in the bugtracker and attach your patch (as a proper diff).
Bart
Logged
lagprogramming
Sr. Member
Posts: 406
Re: class function TCDWSButton.GetText doesn't return a result
«
Reply #2 on:
March 27, 2023, 04:49:53 pm »
Here is a patch
Code: Pascal
[Select]
[+]
[-]
diff
--
git a
/
lcl
/
interfaces
/
customdrawn
/
customdrawnwsstdctrls
.
pas
b
/
lcl
/
interfaces
/
customdrawn
/
customdrawnwsstdctrls
.
pas
index
795ca36d3e
..
1a90af04e9
100644
---
a
/
lcl
/
interfaces
/
customdrawn
/
customdrawnwsstdctrls
.
pas
+++
b
/
lcl
/
interfaces
/
customdrawn
/
customdrawnwsstdctrls
.
pas
@@
-
1704
,
9
+
1704
,
11
@@
class
function
TCDWSButton
.
GetText
(
const
AWinControl
:
TWinControl
;
var
lCDWinControl
:
TCDWinControl
;
begin
+
Result
:
=
False
;
lCDWinControl
:
=
TCDWinControl
(
AWinControl
.
Handle
)
;
if
lCDWinControl
.
CDControl
=
nil
then
Exit
;
AText
:
=
TCDIntfButton
(
lCDWinControl
.
CDControl
)
.
Caption
;
+
Result
:
=
True
;
end
;
class
procedure
TCDWSButton
.
SetText
(
const
AWinControl
:
TWinControl
;
Logged
Bart
Hero Member
Posts: 5290
Re: class function TCDWSButton.GetText doesn't return a result
«
Reply #3 on:
March 27, 2023, 06:27:52 pm »
Please put it in the bugtracker, so it won't be forgotten.
I know next to nothing about CD widgetset.
Bart
Logged
wp
Hero Member
Posts: 11923
Re: class function TCDWSButton.GetText doesn't return a result
«
Reply #4 on:
March 30, 2023, 03:49:05 pm »
Like Bart I have no experience with customdrawn WS, but since your solution is obvious and straightforward, I committed it. But please, report issues in the bugtracker where it is easier for us to trace regressions and side-effects.
Logged
Print
Pages: [
1
]
« previous
next »
Lazarus
»
Forum
»
Programming
»
Widgetset
»
CustomDrawn
»
[SOLVED] class function TCDWSButton.GetText doesn't return a result
TinyPortal
© 2005-2018