Dark Theme in my program?

[d7_2_laz]

Yes, fix #5 was a bad surprise for me. I just had been busy to write an answer.
- good listview behaviour went lost
- statusbar vert. var still not visible.
The version from april 07 had been basically fine.
I responded in Github.

[zamtmn]

We need to use one code. I have to compare several different versions of files, it problem((

[d7_2_laz]

See simply your version from April 07 as base. For the listview.

For statusbar,  try within the paint routine:

Code: Pascal  [Select][+][-]

1. X:= 1;
2. LCanvas.Font.Color:= clWhite;
3. for Index:= 0 to StatusBar.Panels.Count - 1 do
4. begin
5.   APanel:= StatusBar.Panels[Index];
6.   LCanvas.TextOut(X+1, (StatusBar.Height - LCanvas.TextHeight('Ag')) div 2, APanel.Text);
7.   X+= APanel.Width;
8.   //LCanvas.Pen.Color:= SysColor[COLOR_BTNFACE];   // Won't work at all
9.   LCanvas.Pen.Color:= SysColor[COLOR_INACTIVECAPTIONTEXT];
10.   //LCanvas.Line(x-2, ps.rcPaint.Top, x-2, ps.rcPaint.Bottom);
11.   LCanvas.Line(x-2, ps.rcPaint.Top+3, x-2, ps.rcPaint.Bottom-4);  // Not quite so high
12. end;
13.  

The concrete color for the vertical bar surely needs to be optimized, a second vertical bar line too. I had no better result yet

[furious programming]

I closed it with a commit, there was a link to the forum in the commit text, I had nothing to add there, except to say thank you again))
Can you open the complaint again?

I can't, because I'm not an owner of this repository, so I have no power to do this. That's why I suggest to discuss about the issues there, and here keep the general discusion about the package, ideas, problems etc.

TStatusBar doesn't have a frame, suggest a concrete color

Standard StatusBar has a line on the top, maybe I should not call this frame. Anyway, in a standard theme, separators have the same color as this top-line but, in dark theme, separators are much brighter. Try to use this color.

[d7_2_laz]

To my experiences yesterday there's a limited access to the colors during paint within the theming.
I exxperienced to see the color (of the verical bar) either white or not at all.

Actually i see a more basic problem (with the latest fix). It's x-pos as deriived from a panel's with is kind of unreliable. Wouldn't know yet how to solve.

[furious programming]

To my experiences yesterday there's a limited access to the colors during paint within the theming.

Currently you are using the SysColor[COLOR_GRAYTEXT] to paint the separator lines, which is two times brighter than the top line of the status bar. Try to use something close to the RGB 85,85,85.

Actually i see a more basic problem (with the latest fix). It's x-pos as deriived from a panel's with is kind of unreliable. Wouldn't know yet how to solve.

In the case of serious problems with rendering separators, maybe it would be better to not render them at all. For now better is to have clean and readable statusbar, instead of fully but incorrectly rendered. We should also discuss about creating regular releases with the list of things done (fixed). Also, the repository needs the readme.md with the list of currently working features, so everyone will see the value of the package and the progress of work will be clearly visible.

[d7_2_laz]

Sorry about my last remark concerning the separator's x-pos ... that was my bad as i just recognized.

[d7_2_laz]

Try to use something close to the RGB 85,85,85.

Test:

Code: Pascal  [Select][+][-]

1.      //LCanvas.Pen.Color:= SysColor[COLOR_GRAYTEXT];
2.       LCanvas.Pen.Color:= RGBToColor(85, 85, 85);

==> Would be possible, but imo useless. What's the benefit of such a marker that one cannot recognize without a magnifying glass?

[zamtmn]

I'll add, it's not difficult. Butwe will have to collect all these values and create a centralized palette. the fewer digital values used, the better

[KodeZwerg]

What's the benefit of such a marker that one cannot recognize without a magnifying glass?

I guess because I am on Windows that I am total used to such markers and believe it or not, I do not need any kind of tool to recognize such so on that point I am full with furious programming

[furious programming]

What's the benefit of such a marker that one cannot recognize without a magnifying glass?

In the original (native) theme, the separators are also barely visible.

Separators should not be clearly visible, because the are not as important as the text of its panels.

I'll add, it's not difficult. Butwe will have to collect all these values and create a centralized palette. the fewer digital values used, the better

IMO the centralized palette is a must-have — it will simplify the development.

If we talk about the colors palette, I strongly suggest to use only custom colors, without asking the system for them. Just define an array with colors, fill them with constant values (using RGBToColor function) and use everywhere in the package source code. This will allow the IDE to look the same in every user's environment.

[d7_2_laz]

Centralized palette or not - if we begin to burden this task by making things less readable - only for to keep a kind of "theme-compliancy",  without having the chance to stop that resp. to preserve preferences, i'll out of this thread. This is not mine.

[furious programming]

What do you mean? One array with all palette colors will de facto increase the readability and will make the development easier. Currently we have a little mess, some colors are read from the array, some are hardcoded in the methods code — this is not the good idea.

[d7_2_laz]

If we begin to make things less readable - only for to keep a kind of "theme-compliancy" -,  without having the chance to stop that resp. to preserve preferences, it's useless for me.

[furious programming]

Ok, so do what you thing is best. If I will not like something, I will just change the source code of my local copy of the package. Win-Win.