Forum > Designer
"TestAll" project issues
JuhaManninen:
--- Quote from: Aruna on February 05, 2023, 12:43:17 pm ---So I am guessing the commit I must go back to is commit 95ca76e85edc433d7d03f14daf28aafbcd92fa36 Author: mattias <nc-gaertnma@netcologne.de> Date: Sat Oct 1 00:38:04 2005 +0000 ?
--- End quote ---
Don't go so far in history. See the third post in this thread for details.
Aruna:
--- Quote from: JuhaManninen on February 05, 2023, 01:52:03 pm ---
--- Quote from: Aruna on February 05, 2023, 12:43:17 pm ---So I am guessing the commit I must go back to is commit 95ca76e85edc433d7d03f14daf28aafbcd92fa36 Author: mattias <nc-gaertnma@netcologne.de> Date: Sat Oct 1 00:38:04 2005 +0000 ?
--- End quote ---
Don't go so far in history. See the third post in this thread for details.
--- End quote ---
Oh my goodness you told me exactly what to do but I did not understand this at that time, I do now. Thank you Juha.
JuhaManninen:
I added the latest TestAll project from "main" examples/ directory to lcl/tests in c1e41c6f962c. Please test.
Why does it test only a small subset of LCL controls? The name TestAll is misleading. Can you Aruna please take a look?
Further code improvements must happen as patches or merge requests.
Aruna:
--- Quote from: JuhaManninen on February 17, 2023, 03:36:10 pm ---I added the latest TestAll project from "main" examples/ directory to lcl/tests in c1e41c6f962c. Please test.
--- End quote ---
Juha thank you very much but what you added does not have the necessary git history. You can see this below.
--- Code: Bash [+][-]window.onload = function(){var x1 = document.getElementById("main_content_section"); if (x1) { var x = document.getElementsByClassName("geshi");for (var i = 0; i < x.length; i++) { x[i].style.maxHeight='none'; x[i].style.height = Math.min(x[i].clientHeight+15,306)+'px'; x[i].style.resize = "vertical";}};} ---aruna@debian:/media/aruna/linux-next/lazarus$ git log lcl/tests/testall/testall.lpicommit c1e41c6f962ce308ed3d81ea50b230be49a19f0fAuthor: Juha <juha@lazarus-ide.org>Date: Fri Feb 17 16:16:35 2023 +0200 LCL: Restore TestAll project but this time in lcl/tests directory.aruna@debian:/media/aruna/linux-next/lazarus$ I was busy with work I did not have time to fix this. I will do so soon.
--- Quote from: JuhaManninen on February 17, 2023, 03:36:10 pm ---Why does it test only a small subset of LCL controls? The name TestAll is misleading. Can you Aruna please take a look?
--- End quote ---
This was how I found the original source. Only 4 controls were tested the others had placeholders but someone has to write code to test. If you go through testallform_include.inc starting at line 117 you will see the reason why. Some code is below.
--- Code: Pascal [+][-]window.onload = function(){var x1 = document.getElementById("main_content_section"); if (x1) { var x = document.getElementsByClassName("geshi");for (var i = 0; i < x.length; i++) { x[i].style.maxHeight='none'; x[i].style.height = Math.min(x[i].clientHeight+15,306)+'px'; x[i].style.resize = "vertical";}};} --- taCompImplemented: Array[taComponents] of Boolean = ( True, //tacTarrow, True, //tacTbitbtn, True, //tacTbutton, True, //tacTbuttonpanel, False, //tacTcalcedit, False, //tacTcalendar, False, //tacTcheckbox, False, //tacTcheckcombobox, False, //tacTcheckgroup, False, //tacTchecklistbox, False, //tacTcolorbox,
--- Quote from: JuhaManninen on February 17, 2023, 03:36:10 pm ---Further code improvements must happen as patches or merge requests.
--- End quote ---
Understood and will comply. Thank you Juha.
Aruna:
Please disregard my concerns about the commit history in the earlier reply. I just found out about git log --follow and this shows me the history.
--- Code: Pascal [+][-]window.onload = function(){var x1 = document.getElementById("main_content_section"); if (x1) { var x = document.getElementsByClassName("geshi");for (var i = 0; i < x.length; i++) { x[i].style.maxHeight='none'; x[i].style.height = Math.min(x[i].clientHeight+15,306)+'px'; x[i].style.resize = "vertical";}};} ---git log --follow ../lcl/tests/testallform.pp
I have no idea if this will work every time but it does work for me for now. Sadly I am unable to use git blame as there is no direct commit history, I am trying to figure a work around. Maybe more experienced folks can suggest ways to do so?
--- Quote from: JuhaManninen on February 17, 2023, 03:36:10 pm ---Why does it test only a small subset of LCL controls? The name TestAll is misleading. Can you Aruna please take a look?
--- End quote ---
I took a look using git log testallform_include.inc and the reason why is shown in line #6 given below..
--- Code: Text [+][-]window.onload = function(){var x1 = document.getElementById("main_content_section"); if (x1) { var x = document.getElementsByClassName("geshi");for (var i = 0; i < x.length; i++) { x[i].style.maxHeight='none'; x[i].style.height = Math.min(x[i].clientHeight+15,306)+'px'; x[i].style.resize = "vertical";}};} ---commit 96ba7a6b4036f65806c2720da31331a29de63e1dAuthor: bart <9132501-flyingsheep@users.noreply.gitlab.com>Date: Sat Mar 5 13:09:33 2016 +0000 Examples: TestAll: - make dummy procedures for all tests and call them in the menu's onclick event - fix typo - refactor - cleanup git-svn-id: trunk@51826 -
Navigation
[0] Message Index
[*] Previous page